Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
58ee1738
Commit
58ee1738
authored
Feb 14, 2022
by
Robert May
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Enable repository API rate limit cache
Changelog: performance
parent
f536b8cd
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
1 addition
and
21 deletions
+1
-21
config/feature_flags/development/api_caching_rate_limit_repository_compare.yml
...development/api_caching_rate_limit_repository_compare.yml
+0
-8
lib/api/repositories.rb
lib/api/repositories.rb
+1
-2
spec/requests/api/repositories_spec.rb
spec/requests/api/repositories_spec.rb
+0
-11
No files found.
config/feature_flags/development/api_caching_rate_limit_repository_compare.yml
deleted
100644 → 0
View file @
f536b8cd
---
name
:
api_caching_rate_limit_repository_compare
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/64407
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/334264
milestone
:
'
14.1'
type
:
development
group
:
group::source code
default_enabled
:
true
lib/api/repositories.rb
View file @
58ee1738
...
...
@@ -171,7 +171,6 @@ module API
optional
:straight
,
type:
Boolean
,
desc:
'Comparison method, `true` for direct comparison between `from` and `to` (`from`..`to`), `false` to compare using merge base (`from`...`to`)'
,
default:
false
end
get
':id/repository/compare'
,
urgency: :low
do
ff_enabled
=
Feature
.
enabled?
(
:api_caching_rate_limit_repository_compare
,
user_project
,
default_enabled: :yaml
)
target_project
=
fetch_target_project
(
current_user
,
user_project
,
params
)
if
target_project
.
blank?
...
...
@@ -180,7 +179,7 @@ module API
cache_key
=
compare_cache_key
(
current_user
,
user_project
,
target_project
,
declared_params
)
cache_action
_if
(
ff_enabled
,
cache_key
,
expires_in:
1
.
minute
)
do
cache_action
(
cache_key
,
expires_in:
1
.
minute
)
do
compare
=
CompareService
.
new
(
user_project
,
params
[
:to
]).
execute
(
target_project
,
params
[
:from
],
straight:
params
[
:straight
])
if
compare
...
...
spec/requests/api/repositories_spec.rb
View file @
58ee1738
...
...
@@ -561,17 +561,6 @@ RSpec.describe API::Repositories do
let
(
:request
)
{
get
api
(
route
,
guest
)
}
end
end
context
'api_caching_rate_limit_repository_compare is disabled'
do
before
do
stub_feature_flags
(
api_caching_rate_limit_repository_compare:
false
)
end
it_behaves_like
'repository compare'
do
let
(
:project
)
{
create
(
:project
,
:public
,
:repository
)
}
let
(
:current_user
)
{
nil
}
end
end
end
describe
'GET /projects/:id/repository/contributors'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment