Further review changes

app/assets/javascripts/notes/components/issue_comment_form.vue

@@ -266,9 +266,9 @@
               <div class="error-alert"></div>
 
               <issue-warning
-                v-if="hasIssueWarning(getIssueData)"
-                :is-locked="isIssueLocked(getIssueData)"
-                :is-confidential="isIssueConfidential(getIssueData)"
+                v-if="hasWarning(getIssueData)"
+                :is-locked="isLocked(getIssueData)"
+                :is-confidential="isConfidential(getIssueData)"
               />
 
               <markdown-field
@@ -276,7 +276,6 @@
                 :markdown-docs-path="markdownDocsPath"
                 :quick-actions-docs-path="quickActionsDocsPath"
                 :add-spacing-classes="false"
-                :is-confidential-issue="isIssueConfidential(getIssueData)"
                 ref="markdownField">
                 <textarea
                   id="note-body"

app/assets/javascripts/notes/components/issue_note_form.vue

@@ -129,9 +129,9 @@
       class="edit-note common-note-form js-quick-submit gfm-form">
 
       <issue-warning
-        v-if="hasIssueWarning(getIssueData)"
-        :is-locked="isIssueLocked(getIssueData)"
-        :is-confidential="isIssueConfidential(getIssueData)"
+        v-if="hasWarning(getIssueData)"
+        :is-locked="isLocked(getIssueData)"
+        :is-confidential="isConfidential(getIssueData)"
       />
 
       <markdown-field

app/assets/javascripts/notes/mixins/issuable_state.js

 export default {
   methods: {
-    isIssueConfidential(issue) {
+    isConfidential(issue) {
       return !!issue.confidential;
     },
 
-    isIssueLocked(issue) {
+    isLocked(issue) {
       return !!issue.discussion_locked;
     },
 
-    hasIssueWarning(issue) {
-      return this.isIssueConfidential(issue) || this.isIssueLocked(issue);
+    hasWarning(issue) {
+      return this.isConfidential(issue) || this.isLocked(issue);
     },
   },
 };