Commit 5f99deea authored by Furkan Ayhan's avatar Furkan Ayhan

Enable AllowImplicitReturn:false for Rails/SaveBang rubocop rule

This rule prevents usage of nonbang actions inside block/method.
This commit also adds ActionDispatch::TestRequest into AllowedReceivers,
in order to prevent accidental usage of bang operator.
parent 333c6d55
...@@ -471,6 +471,8 @@ Rails/TimeZone: ...@@ -471,6 +471,8 @@ Rails/TimeZone:
# WIP: See https://gitlab.com/gitlab-org/gitlab/-/issues/220040 # WIP: See https://gitlab.com/gitlab-org/gitlab/-/issues/220040
Rails/SaveBang: Rails/SaveBang:
Enabled: true Enabled: true
AllowImplicitReturn: false
AllowedReceivers: ['ActionDispatch::TestRequest']
Include: Include:
- 'spec/**/*.rb' - 'spec/**/*.rb'
- 'ee/spec/**/*.rb' - 'ee/spec/**/*.rb'
......
This diff is collapsed.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment