Change iid argument to ID_TYPE for graphQL queries

We use ID_TYPE for id arguments
and we should do the same for iid

app/assets/javascripts/mr_popover/queries/merge_request.query.graphql

-query mergeRequest($projectPath: ID!, $mergeRequestIID: String!) {
+query mergeRequest($projectPath: ID!, $mergeRequestIID: ID!) {
   project(fullPath: $projectPath) {
     mergeRequest(iid: $mergeRequestIID) {
       createdAt

app/assets/javascripts/sidebar/queries/sidebarDetails.query.graphql

-query ($fullPath: ID!, $iid: String!) {
+query ($fullPath: ID!, $iid: ID!) {
   project (fullPath: $fullPath) {
     issue (iid: $iid) {
       iid

app/assets/javascripts/sidebar/queries/sidebarDetailsForHealthStatusFeatureFlag.query.graphql

-query ($fullPath: ID!, $iid: String!) {
+query ($fullPath: ID!, $iid: ID!) {
   project (fullPath: $fullPath) {
     issue (iid: $iid) {
       iid

app/graphql/mutations/issues/base.rb

@@ -9,7 +9,7 @@ module Mutations
                required: true,
                description: "The project the issue to mutate is in"
 
-      argument :iid, GraphQL::STRING_TYPE,
+      argument :iid, GraphQL::ID_TYPE,
                required: true,
                description: "The iid of the issue to mutate"
 

app/graphql/mutations/merge_requests/base.rb

@@ -9,7 +9,7 @@ module Mutations
                required: true,
                description: "The project the merge request to mutate is in"
 
-      argument :iid, GraphQL::STRING_TYPE,
+      argument :iid, GraphQL::ID_TYPE,
                required: true,
                description: "The iid of the merge request to mutate"
 

app/graphql/resolvers/issues_resolver.rb

@@ -2,11 +2,11 @@
 
 module Resolvers
   class IssuesResolver < BaseResolver
-    argument :iid, GraphQL::STRING_TYPE,
+    argument :iid, GraphQL::ID_TYPE,
               required: false,
               description: 'IID of the issue. For example, "1"'
 
-    argument :iids, [GraphQL::STRING_TYPE],
+    argument :iids, [GraphQL::ID_TYPE],
               required: false,
               description: 'List of IIDs of issues. For example, [1, 2]'
     argument :state, Types::IssuableStateEnum,

app/graphql/resolvers/merge_requests_resolver.rb

@@ -2,11 +2,11 @@
 
 module Resolvers
   class MergeRequestsResolver < BaseResolver
-    argument :iid, GraphQL::STRING_TYPE,
+    argument :iid, GraphQL::ID_TYPE,
               required: false,
               description: 'The IID of the merge request, e.g., "1"'
 
-    argument :iids, [GraphQL::STRING_TYPE],
+    argument :iids, [GraphQL::ID_TYPE],
               required: false,
               description: 'The list of IIDs of issues, e.g., [1, 2]'
 

app/graphql/types/ci/pipeline_type.rb

@@ -11,7 +11,7 @@ module Types
 
       field :id, GraphQL::ID_TYPE, null: false,
             description: 'ID of the pipeline'
-      field :iid, GraphQL::STRING_TYPE, null: false,
+      field :iid, GraphQL::ID_TYPE, null: false,
             description: 'Internal ID of the pipeline'
 
       field :sha, GraphQL::STRING_TYPE, null: false,

app/graphql/types/merge_request_type.rb

@@ -14,7 +14,7 @@ module Types
 
     field :id, GraphQL::ID_TYPE, null: false,
           description: 'ID of the merge request'
-    field :iid, GraphQL::STRING_TYPE, null: false,
+    field :iid, GraphQL::ID_TYPE, null: false,
           description: 'Internal ID of the merge request'
     field :title, GraphQL::STRING_TYPE, null: false,
           description: 'Title of the merge request'

doc/api/graphql/reference/gitlab_schema.graphql

@@ -3677,7 +3677,7 @@ input IssueSetConfidentialInput {
   """
   The iid of the issue to mutate
   """
-  iid: String!
+  iid: ID!
 
   """
   The project the issue to mutate is in
@@ -3722,7 +3722,7 @@ input IssueSetDueDateInput {
   """
   The iid of the issue to mutate
   """
-  iid: String!
+  iid: ID!
 
   """
   The project the issue to mutate is in
@@ -3762,7 +3762,7 @@ input IssueSetWeightInput {
   """
   The iid of the issue to mutate
   """
-  iid: String!
+  iid: ID!
 
   """
   The project the issue to mutate is in
@@ -4070,7 +4070,7 @@ type MergeRequest implements Noteable {
   """
   Internal ID of the merge request
   """
-  iid: String!
+  iid: ID!
 
   """
   Commit SHA of the merge request if merge is in progress
@@ -4470,7 +4470,7 @@ input MergeRequestSetAssigneesInput {
   """
   The iid of the merge request to mutate
   """
-  iid: String!
+  iid: ID!
 
   """
   The operation to perform. Defaults to REPLACE.
@@ -4515,7 +4515,7 @@ input MergeRequestSetLabelsInput {
   """
   The iid of the merge request to mutate
   """
-  iid: String!
+  iid: ID!
 
   """
   The Label IDs to set. Replaces existing labels by default.
@@ -4565,7 +4565,7 @@ input MergeRequestSetLockedInput {
   """
   The iid of the merge request to mutate
   """
-  iid: String!
+  iid: ID!
 
   """
   Whether or not to lock the merge request.
@@ -4610,7 +4610,7 @@ input MergeRequestSetMilestoneInput {
   """
   The iid of the merge request to mutate
   """
-  iid: String!
+  iid: ID!
 
   """
   The milestone to assign to the merge request.
@@ -4655,7 +4655,7 @@ input MergeRequestSetSubscriptionInput {
   """
   The iid of the merge request to mutate
   """
-  iid: String!
+  iid: ID!
 
   """
   The project the merge request to mutate is in
@@ -4700,7 +4700,7 @@ input MergeRequestSetWipInput {
   """
   The iid of the merge request to mutate
   """
-  iid: String!
+  iid: ID!
 
   """
   The project the merge request to mutate is in
@@ -5270,7 +5270,7 @@ type Pipeline {
   """
   Internal ID of the pipeline
   """
-  iid: String!
+  iid: ID!
 
   """
   SHA of the pipeline's commit
@@ -5548,12 +5548,12 @@ type Project {
     """
     IID of the issue. For example, "1"
     """
-    iid: String
+    iid: ID
 
     """
     List of IIDs of issues. For example, [1, 2]
     """
-    iids: [String!]
+    iids: [ID!]
 
     """
     Labels applied to this issue
@@ -5643,12 +5643,12 @@ type Project {
     """
     IID of the issue. For example, "1"
     """
-    iid: String
+    iid: ID
 
     """
     List of IIDs of issues. For example, [1, 2]
     """
-    iids: [String!]
+    iids: [ID!]
 
     """
     Labels applied to this issue
@@ -5718,12 +5718,12 @@ type Project {
     """
     The IID of the merge request, e.g., "1"
     """
-    iid: String
+    iid: ID
 
     """
     The list of IIDs of issues, e.g., [1, 2]
     """
-    iids: [String!]
+    iids: [ID!]
   ): MergeRequest
 
   """
@@ -5748,12 +5748,12 @@ type Project {
     """
     The IID of the merge request, e.g., "1"
     """
-    iid: String
+    iid: ID
 
     """
     The list of IIDs of issues, e.g., [1, 2]
     """
-    iids: [String!]
+    iids: [ID!]
 
     """
     Returns the last _n_ elements from the list.
@@ -8031,7 +8031,7 @@ input UpdateIssueInput {
   """
   The iid of the issue to mutate
   """
-  iid: String!
+  iid: ID!
 
   """
   The project the issue to mutate is in

doc/api/graphql/reference/gitlab_schema.json

@@ -702,7 +702,7 @@
                   "description": "IID of the issue. For example, \"1\"",
                   "type": {
                     "kind": "SCALAR",
-                    "name": "String",
+                    "name": "ID",
                     "ofType": null
                   },
                   "defaultValue": null
@@ -718,7 +718,7 @@
                       "name": null,
                       "ofType": {
                         "kind": "SCALAR",
-                        "name": "String",
+                        "name": "ID",
                         "ofType": null
                       }
                     }
@@ -881,7 +881,7 @@
                   "description": "IID of the issue. For example, \"1\"",
                   "type": {
                     "kind": "SCALAR",
-                    "name": "String",
+                    "name": "ID",
                     "ofType": null
                   },
                   "defaultValue": null
@@ -897,7 +897,7 @@
                       "name": null,
                       "ofType": {
                         "kind": "SCALAR",
-                        "name": "String",
+                        "name": "ID",
                         "ofType": null
                       }
                     }
@@ -1156,7 +1156,7 @@
                   "description": "The IID of the merge request, e.g., \"1\"",
                   "type": {
                     "kind": "SCALAR",
-                    "name": "String",
+                    "name": "ID",
                     "ofType": null
                   },
                   "defaultValue": null
@@ -1172,7 +1172,7 @@
                       "name": null,
                       "ofType": {
                         "kind": "SCALAR",
-                        "name": "String",
+                        "name": "ID",
                         "ofType": null
                       }
                     }
@@ -1197,7 +1197,7 @@
                   "description": "The IID of the merge request, e.g., \"1\"",
                   "type": {
                     "kind": "SCALAR",
-                    "name": "String",
+                    "name": "ID",
                     "ofType": null
                   },
                   "defaultValue": null
@@ -1213,7 +1213,7 @@
                       "name": null,
                       "ofType": {
                         "kind": "SCALAR",
-                        "name": "String",
+                        "name": "ID",
                         "ofType": null
                       }
                     }
@@ -14273,7 +14273,7 @@
                 "name": null,
                 "ofType": {
                   "kind": "SCALAR",
-                  "name": "String",
+                  "name": "ID",
                   "ofType": null
                 }
               },
@@ -16052,7 +16052,7 @@
                 "name": null,
                 "ofType": {
                   "kind": "SCALAR",
-                  "name": "String",
+                  "name": "ID",
                   "ofType": null
                 }
               },
@@ -20820,7 +20820,7 @@
                 "name": null,
                 "ofType": {
                   "kind": "SCALAR",
-                  "name": "String",
+                  "name": "ID",
                   "ofType": null
                 }
               },
@@ -20950,7 +20950,7 @@
                 "name": null,
                 "ofType": {
                   "kind": "SCALAR",
-                  "name": "String",
+                  "name": "ID",
                   "ofType": null
                 }
               },
@@ -21080,7 +21080,7 @@
                 "name": null,
                 "ofType": {
                   "kind": "SCALAR",
-                  "name": "String",
+                  "name": "ID",
                   "ofType": null
                 }
               },
@@ -21246,7 +21246,7 @@
                 "name": null,
                 "ofType": {
                   "kind": "SCALAR",
-                  "name": "String",
+                  "name": "ID",
                   "ofType": null
                 }
               },
@@ -21423,7 +21423,7 @@
                 "name": null,
                 "ofType": {
                   "kind": "SCALAR",
-                  "name": "String",
+                  "name": "ID",
                   "ofType": null
                 }
               },
@@ -21553,7 +21553,7 @@
                 "name": null,
                 "ofType": {
                   "kind": "SCALAR",
-                  "name": "String",
+                  "name": "ID",
                   "ofType": null
                 }
               },
@@ -21679,7 +21679,7 @@
                 "name": null,
                 "ofType": {
                   "kind": "SCALAR",
-                  "name": "String",
+                  "name": "ID",
                   "ofType": null
                 }
               },
@@ -21809,7 +21809,7 @@
                 "name": null,
                 "ofType": {
                   "kind": "SCALAR",
-                  "name": "String",
+                  "name": "ID",
                   "ofType": null
                 }
               },
@@ -21939,7 +21939,7 @@
                 "name": null,
                 "ofType": {
                   "kind": "SCALAR",
-                  "name": "String",
+                  "name": "ID",
                   "ofType": null
                 }
               },
@@ -24375,7 +24375,7 @@
                 "name": null,
                 "ofType": {
                   "kind": "SCALAR",
-                  "name": "String",
+                  "name": "ID",
                   "ofType": null
                 }
               },

doc/api/graphql/reference/index.md

@@ -608,7 +608,7 @@ Autogenerated return type of MarkAsSpamSnippet
 | `forceRemoveSourceBranch` | Boolean | Indicates if the project settings will lead to source branch deletion after merge |
 | `headPipeline` | Pipeline | The pipeline running on the branch HEAD of the merge request |
 | `id` | ID! | ID of the merge request |
-| `iid` | String! | Internal ID of the merge request |
+| `iid` | ID! | Internal ID of the merge request |
 | `inProgressMergeCommitSha` | String | Commit SHA of the merge request if merge is in progress |
 | `mergeCommitMessage` **{warning-solid}** | String | **Deprecated:** Renamed to defaultMergeCommitMessage |
 | `mergeCommitSha` | String | SHA of the merge request commit (set once merged) |
@@ -812,7 +812,7 @@ Information about pagination in a connection.
 | `duration` | Int | Duration of the pipeline in seconds |
 | `finishedAt` | Time | Timestamp of the pipeline's completion |
 | `id` | ID! | ID of the pipeline |
-| `iid` | String! | Internal ID of the pipeline |
+| `iid` | ID! | Internal ID of the pipeline |
 | `sha` | String! | SHA of the pipeline's commit |
 | `startedAt` | Time | Timestamp when the pipeline was started |
 | `status` | PipelineStatusEnum! | Status of the pipeline (CREATED, WAITING_FOR_RESOURCE, PREPARING, PENDING, RUNNING, FAILED, SUCCESS, CANCELED, SKIPPED, MANUAL, SCHEDULED) |

doc/development/api_graphql_styleguide.md

@@ -541,7 +541,7 @@ argument :project_path, GraphQL::ID_TYPE,
          required: true,
          description: "The project the merge request to mutate is in"
 
-argument :iid, GraphQL::STRING_TYPE,
+argument :iid, GraphQL::ID_TYPE,
          required: true,
          description: "The iid of the merge request to mutate"
 

ee/app/assets/javascripts/design_management/graphql/queries/getDesign.query.graphql

 #import "../fragments/design.fragment.graphql"
 #import "~/graphql_shared/fragments/author.fragment.graphql"
 
-query getDesign($fullPath: ID!, $iid: String!, $atVersion: ID, $filenames: [String!]) {
+query getDesign($fullPath: ID!, $iid: ID!, $atVersion: ID, $filenames: [String!]) {
   project(fullPath: $fullPath) {
     id
     issue(iid: $iid) {

ee/app/assets/javascripts/design_management/graphql/queries/permissions.query.graphql

-query permissions($fullPath: ID!, $iid: String!) {
+query permissions($fullPath: ID!, $iid: ID!) {
   project(fullPath: $fullPath) {
     id
     issue(iid: $iid) {

ee/app/assets/javascripts/design_management/graphql/queries/project.query.graphql

 #import "../fragments/designList.fragment.graphql"
 #import "../fragments/version.fragment.graphql"
 
-query project($fullPath: ID!, $iid: String!, $atVersion: ID) {
+query project($fullPath: ID!, $iid: ID!, $atVersion: ID) {
   project(fullPath: $fullPath) {
     id
     issue(iid: $iid) {

ee/app/assets/javascripts/sidebar/queries/sidebarDetails.query.graphql

-query ($fullPath: ID!, $iid: String!) {
+query ($fullPath: ID!, $iid: ID!) {
   project (fullPath: $fullPath) {
     issue (iid: $iid) {
       iid

ee/app/assets/javascripts/sidebar/queries/sidebarDetailsForHealthStatusFeatureFlag.query.graphql

-query ($fullPath: ID!, $iid: String!) {
+query ($fullPath: ID!, $iid: ID!) {
   project (fullPath: $fullPath) {
     issue (iid: $iid) {
       healthStatus