Merge branch 'fix-jira-user-agent' into 'master'

Fix user agent string for Hosted Jira

Closes #10737

See merge request gitlab-org/gitlab-ee!10545

ee/changelogs/unreleased/fix-jira-user-agent.yml

+---
+title: Fix user agent string for Hosted Jira
+merge_request: 10545
+author:
+type: fixed

ee/lib/gitlab/jira/middleware.rb

@@ -4,7 +4,7 @@ module Gitlab
   module Jira
     class Middleware
       def self.jira_dvcs_connector?(env)
-        env['HTTP_USER_AGENT']&.start_with?('JIRA DVCS Connector')
+        env['HTTP_USER_AGENT']&.downcase&.start_with?('jira dvcs connector')
       end
 
       def initialize(app)

ee/spec/lib/gitlab/jira/middleware_spec.rb

@@ -10,6 +10,10 @@ describe Gitlab::Jira::Middleware do
       expect(described_class.jira_dvcs_connector?('HTTP_USER_AGENT' => jira_user_agent)).to eq(true)
     end
 
+    it 'returns true if user agent starts with "Jira DVCS Connector"' do
+      expect(described_class.jira_dvcs_connector?('HTTP_USER_AGENT' => 'Jira DVCS Connector')).to eq(true)
+    end
+
     it 'returns false when not DVCS connector' do
       expect(described_class.jira_dvcs_connector?('HTTP_USER_AGENT' => 'pokemon')).to eq(false)
     end