Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
6309f06b
Commit
6309f06b
authored
Sep 05, 2019
by
Rémy Coutable
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Document the new :sidekiq_inline trait
Signed-off-by:
Rémy Coutable
<
remy@rymai.me
>
parent
a59d10e3
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
10 additions
and
3 deletions
+10
-3
doc/development/testing_guide/best_practices.md
doc/development/testing_guide/best_practices.md
+10
-3
No files found.
doc/development/testing_guide/best_practices.md
View file @
6309f06b
...
...
@@ -357,9 +357,16 @@ However, if a spec makes direct Redis calls, it should mark itself with the
`:clean_gitlab_redis_queues`
traits as appropriate.
Sidekiq jobs are typically not run in specs, but this behaviour can be altered
in each spec through the use of
`perform_enqueued_jobs`
blocks. Any spec that
causes Sidekiq jobs to be pushed to Redis should use the
`:sidekiq`
trait, to
ensure that they are removed once the spec completes.
in each spec through the use of
`perform_enqueued_jobs`
blocks.
Any spec that causes Sidekiq jobs to be pushed to Redis should use the
`:sidekiq_inline`
trait, to ensure that they are removed once the spec completes.
The
`:sidekiq_might_not_need_inline`
trait was added when
[
Sidekiq inline mode was
changed to fake mode
](
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31662
)
to all the examples that needed Sidekiq to actually process jobs. Examples with
this trait should be either fixed to not rely on Sidekiq processing jobs, or their
`:sidekiq_might_not_need_inline`
trait should be updated to
`:sidekiq_inline`
if the
processing of background jobs is needed/expected.
#### Filesystem
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment