Merge branch 'rails-logger-cop-6' into 'master'

Use applogger in cache attrs and highest role ruby files

See merge request gitlab-org/gitlab!32189

app/models/concerns/cacheable_attributes.rb

@@ -55,7 +55,7 @@ module CacheableAttributes
       current_without_cache.tap { |current_record| current_record&.cache! }
     rescue => e
       if Rails.env.production?
-        Rails.logger.warn("Cached record for #{name} couldn't be loaded, falling back to uncached record: #{e}") # rubocop:disable Gitlab/RailsLogger
+        Gitlab::AppLogger.warn("Cached record for #{name} couldn't be loaded, falling back to uncached record: #{e}")
       else
         raise e
       end

app/models/concerns/update_highest_role.rb

@@ -29,9 +29,7 @@ module UpdateHighestRole
         UpdateHighestRoleWorker.perform_in(HIGHEST_ROLE_JOB_DELAY, update_highest_role_attribute)
       else
         # use same logging as ExclusiveLeaseGuard
-        # rubocop:disable Gitlab/RailsLogger
-        Rails.logger.error('Cannot obtain an exclusive lease. There must be another instance already in execution.')
-        # rubocop:enable Gitlab/RailsLogger
+        Gitlab::AppLogger.error('Cannot obtain an exclusive lease. There must be another instance already in execution.')
       end
     end
   end

changelogs/unreleased/rails-logger-cop-6.yml

+---
+title: Use applogger in cache attrs and highest role ruby files
+merge_request: 32189
+author: Rajendra Kadam
+type: fixed

spec/models/concerns/cacheable_attributes_spec.rb

@@ -135,7 +135,7 @@ describe CacheableAttributes do
         end
 
         it 'returns an uncached record and logs a warning' do
-          expect(Rails.logger).to receive(:warn).with("Cached record for TestClass couldn't be loaded, falling back to uncached record: Redis::BaseError")
+          expect(Gitlab::AppLogger).to receive(:warn).with("Cached record for TestClass couldn't be loaded, falling back to uncached record: Redis::BaseError")
 
           expect(MinimalTestClass.current).to eq(:last)
         end
@@ -147,7 +147,7 @@ describe CacheableAttributes do
         end
 
         it 'returns an uncached record and logs a warning' do
-          expect(Rails.logger).not_to receive(:warn)
+          expect(Gitlab::AppLogger).not_to receive(:warn)
 
           expect { MinimalTestClass.current }.to raise_error(Redis::BaseError)
         end