Merge branch 'remove-latest-feature-flags-in-ci-templates' into 'master'

Remove unnecessary CI tempalte latest redirect feature flags

See merge request gitlab-org/gitlab!71997

config/feature_flags/development/redirect_to_latest_template_jobs_browser_performance_testing.yml

----
-name: redirect_to_latest_template_jobs_browser_performance_testing
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/63144
-rollout_issue_url: 
-milestone: '14.0'
-type: development
-group: group::pipeline authoring
-default_enabled: false

config/feature_flags/development/redirect_to_latest_template_security_api_fuzzing.yml

----
-name: redirect_to_latest_template_security_api_fuzzing
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/63144
-rollout_issue_url: 
-milestone: '14.0'
-type: development
-group: group::pipeline authoring
-default_enabled: false

config/feature_flags/development/redirect_to_latest_template_security_dast.yml

----
-name: redirect_to_latest_template_security_dast
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/63144
-rollout_issue_url: 
-milestone: '14.0'
-type: development
-group: group::pipeline authoring
-default_enabled: false

config/feature_flags/development/redirect_to_latest_template_terraform.yml

----
-name: redirect_to_latest_template_terraform
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/63144
-rollout_issue_url: 
-milestone: '14.0'
-type: development
-group: group::pipeline authoring
-default_enabled: false

config/feature_flags/development/redirect_to_latest_template_verify_browser_performance.yml

----
-name: redirect_to_latest_template_verify_browser_performance
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/63144
-rollout_issue_url: 
-milestone: '14.0'
-type: development
-group: group::pipeline authoring
-default_enabled: false

doc/development/cicd/templates.md

@@ -325,8 +325,14 @@ projects on `gitlab.com`:
 After you're confident the latest template can be moved to stable:
 
 1. Update the stable template with the content of the latest version.
+1. Remove the migration template from `Gitlab::Template::GitlabCiYmlTemplate::TEMPLATES_WITH_LATEST_VERSION` const.
 1. Remove the corresponding feature flag.
 
+NOTE:
+Feature flags are enabled by default in RSpec, so all tests are performed
+against the latest templates. You should also test the stable templates
+with `stub_feature_flags(redirect_to_latest_template_<name>: false)`.
+
 ### Further reading
 
 There is an [open issue](https://gitlab.com/gitlab-org/gitlab/-/issues/17716) about

ee/lib/ee/gitlab/template/gitlab_ci_yml_template.rb

@@ -6,9 +6,7 @@ module EE
       module GitlabCiYmlTemplate
         extend ActiveSupport::Concern
 
-        EE_TEMPLATES_WITH_LATEST_VERSION = {
-          'Verify/Browser-Performance' => true
-        }.freeze
+        EE_TEMPLATES_WITH_LATEST_VERSION = {}.freeze
 
         class_methods do
           extend ::Gitlab::Utils::Override

ee/spec/lib/ee/gitlab/ci/templates/templates_spec.rb

@@ -8,14 +8,6 @@ RSpec.describe "CI YML Templates" do
 
   let(:all_templates) { Gitlab::Template::GitlabCiYmlTemplate.all.map(&:full_name) }
 
-  before do
-    stub_feature_flags(
-      redirect_to_latest_template_terraform: false,
-      redirect_to_latest_template_security_dast: false,
-      redirect_to_latest_template_security_api_fuzzing: false,
-      redirect_to_latest_template_jobs_browser_performance_testing: false)
-  end
-
   shared_examples 'require default stages to be included' do
     it 'require default stages to be included' do
       expect(subject.stages).to include(*Gitlab::Ci::Config::Entry::Stages.default)

ee/spec/lib/gitlab/ci/templates/Verify/browser_performance_testing_gitlab_ci_yaml_spec.rb

@@ -30,7 +30,6 @@ RSpec.describe 'Verify/Browser-Performance.gitlab-ci.yml' do
 
     before do
       stub_ci_pipeline_yaml_file(template)
-      stub_feature_flags(redirect_to_latest_template_verify_browser_performance: false)
       allow_next_instance_of(Ci::BuildScheduleWorker) do |worker|
         allow(worker).to receive(:perform).and_return(true)
       end

lib/gitlab/template/gitlab_ci_yml_template.rb

@@ -6,11 +6,7 @@ module Gitlab
       BASE_EXCLUDED_PATTERNS = [%r{\.latest\.}].freeze
 
       TEMPLATES_WITH_LATEST_VERSION = {
-        'Jobs/Browser-Performance-Testing' => true,
-        'Jobs/Build' => true,
-        'Security/API-Fuzzing' => true,
-        'Security/DAST' => true,
-        'Terraform' => true
+        'Jobs/Build' => true
       }.freeze
 
       def description

spec/lib/gitlab/ci/templates/templates_spec.rb

@@ -13,13 +13,6 @@ RSpec.describe 'CI YML Templates' do
     excluded + ["Terraform.gitlab-ci.yml"]
   end
 
-  before do
-    stub_feature_flags(
-      redirect_to_latest_template_terraform: false,
-      redirect_to_latest_template_security_api_fuzzing: false,
-      redirect_to_latest_template_security_dast: false)
-  end
-
   shared_examples 'require default stages to be included' do
     it 'require default stages to be included' do
       expect(subject.stages).to include(*Gitlab::Ci::Config::Entry::Stages.default)