Merge branch '11467-remove-feature-flag-for-visual-review-app-button' into 'master'

Resolve "Remove feature flag for Visual Review App Button"

Closes #11467

See merge request gitlab-org/gitlab-ee!14958

app/assets/javascripts/vue_merge_request_widget/components/mr_widget_pipeline_container.vue

@@ -60,7 +60,7 @@ export default {
       return this.isPostMerge ? this.mr.mergePipeline : this.mr.pipeline;
     },
     showVisualReviewAppLink() {
-      return Boolean(this.mr.visualReviewFF && this.mr.visualReviewAppAvailable);
+      return this.mr.visualReviewAppAvailable;
     },
     showMergeTrainInfo() {
       return _.isNumber(this.mr.mergeTrainIndex);

ee/app/assets/javascripts/vue_merge_request_widget/stores/mr_widget_store.js

@@ -30,8 +30,7 @@ export default class MergeRequestStore extends CEMergeRequestStore {
     this.canCreateMergeRequest = Boolean(this.createVulnerabilityFeedbackMergeRequestPath);
     this.canDismissVulnerability = Boolean(this.createVulnerabilityFeedbackDismissalPath);
     this.canCreateFeedback = data.can_create_feedback || false;
-    this.visualReviewAppAvailable = data.visual_review_app_available;
-    this.visualReviewFF = gon && gon.features && gon.features.visualReviewApp;
+    this.visualReviewAppAvailable = Boolean(data.visual_review_app_available);
     this.appUrl = gon && gon.gitlab_url;
 
     this.initCodeclimate(data);

ee/app/controllers/ee/projects/merge_requests_controller.rb

@@ -8,10 +8,6 @@ module EE
       APPROVAL_RENDERING_ACTIONS = [:approve, :approvals, :unapprove].freeze
 
       prepended do
-        before_action only: [:show] do
-          push_frontend_feature_flag(:visual_review_app, merge_request.project, default_enabled: true)
-        end
-
         before_action :whitelist_query_limiting_ee_merge, only: [:merge]
         before_action :whitelist_query_limiting_ee_show, only: [:show]
       end

ee/changelogs/unreleased/11467-remove-feature-flag-for-visual-review-app-button.yml

+---
+title: Remove visual review app feature flag
+merge_request: 14958
+author:
+type: fixed