Merge branch 'sy-rename-project-dashboard' into 'master'

Renames the ProjectDashboards to name the team uses CustomDashboards

See merge request gitlab-org/gitlab!27431

app/services/metrics/dashboard/clone_dashboard_service.rb

@@ -6,7 +6,7 @@ module Metrics
   module Dashboard
     class CloneDashboardService < ::BaseService
       ALLOWED_FILE_TYPE = '.yml'
-      USER_DASHBOARDS_DIR = ::Metrics::Dashboard::ProjectDashboardService::DASHBOARD_ROOT
+      USER_DASHBOARDS_DIR = ::Metrics::Dashboard::CustomDashboardService::DASHBOARD_ROOT
 
       class << self
         def allowed_dashboard_templates
@@ -52,7 +52,7 @@ module Metrics
       def dashboard_details
         {
           path: new_dashboard_path,
-          display_name: ::Metrics::Dashboard::ProjectDashboardService.name_for_path(new_dashboard_path),
+          display_name: ::Metrics::Dashboard::CustomDashboardService.name_for_path(new_dashboard_path),
           default: false,
           system_dashboard: false
         }

app/services/metrics/dashboard/project_dashboard_service.rb → app/services/metrics/dashboard/custom_dashboard_service.rb

@@ -5,7 +5,7 @@
 # Use Gitlab::Metrics::Dashboard::Finder to retrive dashboards.
 module Metrics
   module Dashboard
-    class ProjectDashboardService < ::Metrics::Dashboard::BaseService
+    class CustomDashboardService < ::Metrics::Dashboard::BaseService
       DASHBOARD_ROOT = ".gitlab/dashboards"
 
       class << self

app/services/metrics/dashboard/update_dashboard_service.rb

@@ -7,7 +7,7 @@ module Metrics
       include Stepable
 
       ALLOWED_FILE_TYPE = '.yml'
-      USER_DASHBOARDS_DIR = ::Metrics::Dashboard::ProjectDashboardService::DASHBOARD_ROOT
+      USER_DASHBOARDS_DIR = ::Metrics::Dashboard::CustomDashboardService::DASHBOARD_ROOT
 
       steps :check_push_authorized,
         :check_branch_name,
@@ -117,7 +117,7 @@ module Metrics
       def dashboard_details
         {
           path: update_dashboard_path,
-          display_name: ::Metrics::Dashboard::ProjectDashboardService.name_for_path(update_dashboard_path),
+          display_name: ::Metrics::Dashboard::CustomDashboardService.name_for_path(update_dashboard_path),
           default: false,
           system_dashboard: false
         }

lib/gitlab/metrics/dashboard/finder.rb

@@ -78,7 +78,7 @@ module Gitlab
           end
 
           def project_service
-            ::Metrics::Dashboard::ProjectDashboardService
+            ::Metrics::Dashboard::CustomDashboardService
           end
 
           def self_monitoring_service

lib/gitlab/metrics/dashboard/service_selector.rb

@@ -20,7 +20,7 @@ module Gitlab
             ::Metrics::Dashboard::SystemDashboardService,
             ::Metrics::Dashboard::PodDashboardService,
             ::Metrics::Dashboard::SelfMonitoringDashboardService,
-            ::Metrics::Dashboard::ProjectDashboardService
+            ::Metrics::Dashboard::CustomDashboardService
           ].freeze
 
           # Returns a class which inherits from the BaseService

spec/lib/gitlab/metrics/dashboard/service_selector_spec.rb

@@ -15,7 +15,7 @@ describe Gitlab::Metrics::Dashboard::ServiceSelector do
     context 'when just the dashboard path is provided' do
       let(:arguments) { { dashboard_path: '.gitlab/dashboards/test.yml' } }
 
-      it { is_expected.to be Metrics::Dashboard::ProjectDashboardService }
+      it { is_expected.to be Metrics::Dashboard::CustomDashboardService }
 
       context 'when the path is for the system dashboard' do
         let(:arguments) { { dashboard_path: system_dashboard_path } }

spec/services/metrics/dashboard/project_dashboard_service_spec.rb → spec/services/metrics/dashboard/custom_dashboard_service_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Metrics::Dashboard::ProjectDashboardService, :use_clean_rails_memory_store_caching do
+describe Metrics::Dashboard::CustomDashboardService, :use_clean_rails_memory_store_caching do
   include MetricsDashboardHelpers
 
   let_it_be(:user) { create(:user) }