Commit 6bd7e1b8 authored by Shinya Maeda's avatar Shinya Maeda

Add tests for Release Link API

Add tests for the API and add a couple of tests

Add

revert

revert
parent 124905e2
......@@ -14,6 +14,9 @@ module API
requires :id, type: String, desc: 'The ID of a project'
end
resource 'projects/:id', requirements: API::NAMESPACE_OR_PROJECT_REQUIREMENTS do
params do
requires :tag_name, type: String, desc: 'The name of the tag', as: :tag
end
resource 'releases/:tag_name', requirements: RELEASE_ENDPOINT_REQUIREMETS do
resource :assets do
desc 'Get a list of links of a release' do
......@@ -26,20 +29,7 @@ module API
get 'links' do
authorize! :read_release, release
present paginate(release.links), with: Entities::Releases::Link
end
desc 'Get a link detail of a release' do
detail 'This feature was introduced in GitLab 11.7.'
success Entities::Releases::Link
end
params do
requires :link_id, type: String, desc: 'The id of the link'
end
get 'links/:link_id' do
authorize! :read_release, release
present link, with: Entities::Releases::Link
present paginate(release.links.sorted), with: Entities::Releases::Link
end
desc 'Create a link of a release' do
......@@ -58,27 +48,40 @@ module API
if new_link.persisted?
present new_link, with: Entities::Releases::Link
else
render_api_error!(result[:message], result[:http_status])
render_api_error!(new_link.errors.messages, 400)
end
end
params do
requires :link_id, type: String, desc: 'The id of the link'
end
resource 'links/:link_id' do
desc 'Get a link detail of a release' do
detail 'This feature was introduced in GitLab 11.7.'
success Entities::Releases::Link
end
get do
authorize! :read_release, release
present link, with: Entities::Releases::Link
end
desc 'Update a link of a release' do
detail 'This feature was introduced in GitLab 11.7.'
success Entities::Releases::Link
end
params do
requires :link_id, type: Integer, desc: 'The id of the link'
optional :name, type: String, desc: 'The name of the link'
optional :url, type: String, desc: 'The URL of the link'
at_least_one_of :name, :url
end
put 'links/:link_id' do
put do
authorize! :update_release, release
if link.update(declared_params(include_missing: false))
present link, with: Entities::Releases::Link
else
render_api_error!(result[:message], result[:http_status])
render_api_error!(link.errors.messages, 400)
end
end
......@@ -86,16 +89,14 @@ module API
detail 'This feature was introduced in GitLab 11.7.'
success Entities::Releases::Link
end
params do
requires :link_id, type: Integer, desc: 'The id of the link'
end
put 'links/:link_id' do
delete do
authorize! :destroy_release, release
if link.destroy
present link, with: Entities::Releases::Link
else
render_api_error!(result[:message], result[:http_status])
render_api_error!(link.errors.messages, 400)
end
end
end
end
......@@ -104,7 +105,7 @@ module API
helpers do
def release
@release ||= user_project.releases.find_by_tag(params[:tag_name])
@release ||= user_project.releases.find_by_tag!(params[:tag])
end
def link
......
......@@ -15,15 +15,7 @@
},
"assets": {
"count": { "type": "integer" },
"links": {
"type": "array",
"items": {
"id": "integer",
"name": "string",
"url": "string",
"external": "boolean"
}
},
"links": { "$ref": "release/links.json" },
"sources": {
"type": "array",
"items": {
......
{
"type": "object",
"required": ["name", "url"],
"properties": {
"id": { "type": "integer" },
"name": { "type": "string" },
"url": { "type": "string" },
"external": { "type": "boolean" }
},
"additionalProperties": false
}
{
"type": "array",
"items": { "$ref": "link.json" }
}
This diff is collapsed.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment