Merge branch 'rspec-empty-line-after-letitbe-ee-spec-serializers' into 'master'

Fix RSpec/EmptyLineAfterFinalLetItBe for ee/spec/serializers

See merge request gitlab-org/gitlab!58362

.rubocop_manual_todo.yml

@@ -607,17 +607,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - ee/spec/requests/callout_spec.rb
     - ee/spec/requests/git_http_geo_spec.rb
     - ee/spec/requests/repositories/git_http_controller_spec.rb
-    - ee/spec/serializers/clusters/environment_serializer_spec.rb
-    - ee/spec/serializers/dependency_entity_spec.rb
-    - ee/spec/serializers/dependency_list_serializer_spec.rb
-    - ee/spec/serializers/ee/issue_board_entity_spec.rb
-    - ee/spec/serializers/ee/issue_entity_spec.rb
-    - ee/spec/serializers/ee/issue_sidebar_extras_entity_spec.rb
-    - ee/spec/serializers/member_entity_spec.rb
-    - ee/spec/serializers/merge_request_poll_widget_entity_spec.rb
-    - ee/spec/serializers/merge_request_widget_entity_spec.rb
-    - ee/spec/serializers/status_page/incident_comment_entity_spec.rb
-    - ee/spec/serializers/vulnerabilities/feedback_entity_spec.rb
     - ee/spec/services/alert_management/extract_alert_payload_fields_service_spec.rb
     - ee/spec/services/alert_management/process_prometheus_alert_service_spec.rb
     - ee/spec/services/approval_rules/create_service_spec.rb

ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-serializers.yml

+---
+title: Fix RSpec/EmptyLineAfterFinalLetItBe rubocop offenses in ee/spec/serializers
+merge_request: 58362
+author: Abdul Wadood @abdulwd
+type: fixed

ee/spec/serializers/clusters/environment_serializer_spec.rb

@@ -8,6 +8,7 @@ RSpec.describe Clusters::EnvironmentSerializer do
   let_it_be(:user) { create(:user) }
   let_it_be(:project) { create(:project, namespace: user.namespace) }
   let_it_be(:cluster) { create(:cluster) }
+
   let(:resource) { create(:environment, project: project) }
 
   let(:json_entity) do

ee/spec/serializers/dependency_entity_spec.rb

@@ -7,6 +7,7 @@ RSpec.describe DependencyEntity do
     subject { described_class.represent(dependency, request: request).as_json }
 
     let_it_be(:user) { create(:user) }
+
     let(:project) { create(:project, :repository, :private) }
     let(:request) { double('request') }
     let(:dependency) { build(:dependency, :with_vulnerabilities, :with_licenses, :indirect) }

ee/spec/serializers/dependency_list_serializer_spec.rb

@@ -5,6 +5,7 @@ require 'spec_helper'
 RSpec.describe DependencyListSerializer do
   let_it_be(:project) { create(:project, :repository, :private) }
   let_it_be(:user) { create(:user) }
+
   let(:ci_build) { create(:ee_ci_build, :success) }
   let(:dependencies) { [build(:dependency, :with_vulnerabilities, :with_licenses)] }
 

ee/spec/serializers/ee/issue_board_entity_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe IssueBoardEntity do
   let_it_be(:project) { create(:project) }
   let_it_be(:issue) { create(:issue, project: project) }
   let_it_be(:user) { create(:user) }
+
   let(:request) { double('request', current_user: user) }
   let(:blocked_ids) { [] }
 

ee/spec/serializers/ee/issue_entity_spec.rb

@@ -8,6 +8,7 @@ RSpec.describe IssueEntity do
   let_it_be(:user) { create(:user) }
   let_it_be(:blocking_issue) { create(:issue, project: project) }
   let_it_be(:blocked_issue) { create(:issue, project: project) }
+
   let(:request) { double('request', current_user: user) }
 
   before_all do

ee/spec/serializers/ee/issue_sidebar_extras_entity_spec.rb

@@ -7,6 +7,7 @@ RSpec.describe IssueSidebarExtrasEntity do
   let_it_be(:project) { create(:project, group: group) }
   let_it_be(:user) { create(:user) }
   let_it_be(:issue, reload: true) { create(:issue, :confidential, project: project) }
+
   let(:request) { double('request', current_user: user) }
 
   subject { described_class.new(issue, request: request).as_json }

ee/spec/serializers/member_entity_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe MemberEntity do
   let_it_be(:current_user) { create(:user) }
+
   let(:entity) { described_class.new(member, { current_user: current_user, group: group }) }
   let(:entity_hash) { entity.as_json }
 

ee/spec/serializers/merge_request_poll_widget_entity_spec.rb

@@ -8,6 +8,7 @@ RSpec.describe MergeRequestPollWidgetEntity do
   let_it_be(:user) { create(:user) }
   let_it_be(:project) { create :project, :repository }
   let_it_be(:merge_request, reload: true) { create(:merge_request, source_project: project, target_project: project) }
+
   let(:request) { double('request', current_user: user) }
 
   before do

ee/spec/serializers/merge_request_widget_entity_spec.rb

@@ -9,6 +9,7 @@ RSpec.describe MergeRequestWidgetEntity do
   let_it_be(:project, reload: true) { create :project, :repository }
   let_it_be(:merge_request, reload: true) { create(:merge_request, source_project: project, target_project: project) }
   let_it_be(:pipeline, reload: true) { create(:ci_empty_pipeline, project: project) }
+
   let(:request) { double('request', current_user: user) }
 
   before do

ee/spec/serializers/status_page/incident_comment_entity_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe StatusPage::IncidentCommentEntity do
   let_it_be(:note, reload: true) { create(:note, note: ':ok:') }
+
   let(:json) { subject.as_json }
   let(:issue) { instance_double(Issue, iid: 1) }
 

ee/spec/serializers/vulnerabilities/feedback_entity_spec.rb

@@ -5,6 +5,7 @@ require 'spec_helper'
 RSpec.describe Vulnerabilities::FeedbackEntity do
   let_it_be(:user) { create(:user) }
   let_it_be(:project) { create(:project) }
+
   let(:request) { double('request') }
   let(:entity) { described_class.represent(feedback, request: request) }