Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
6e3b4495
Commit
6e3b4495
authored
Nov 11, 2020
by
peterhegman
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Enable `vue_group_members_list` FF by default
Default enabled for now, will be fully removed in 13.7
parent
f8320e27
Changes
5
Show whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
7 additions
and
13 deletions
+7
-13
app/views/groups/group_members/index.html.haml
app/views/groups/group_members/index.html.haml
+1
-1
changelogs/unreleased/241194-enable-vue_group_members_list-ff-by-default.yml
...ed/241194-enable-vue_group_members_list-ff-by-default.yml
+5
-0
config/feature_flags/development/vue_group_members_list.yml
config/feature_flags/development/vue_group_members_list.yml
+1
-1
qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb
...s/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb
+0
-6
qa/qa/specs/features/ee/browser_ui/1_manage/group/share_group_with_group_spec.rb
.../browser_ui/1_manage/group/share_group_with_group_spec.rb
+0
-5
No files found.
app/views/groups/group_members/index.html.haml
View file @
6e3b4495
...
...
@@ -3,7 +3,7 @@
-
show_invited_members
=
can_manage_members
&&
@invited_members
.
exists?
-
show_access_requests
=
can_manage_members
&&
@requesters
.
exists?
-
invited_active
=
params
[
:search_invited
].
present?
||
params
[
:invited_members_page
].
present?
-
vue_members_list_enabled
=
Feature
.
enabled?
(
:vue_group_members_list
,
@group
)
-
vue_members_list_enabled
=
Feature
.
enabled?
(
:vue_group_members_list
,
@group
,
default_enabled:
true
)
-
current_user_is_group_owner
=
@group
&&
@group
.
has_owner?
(
current_user
)
-
form_item_label_css_class
=
'label-bold gl-mr-2 gl-mb-0 gl-py-2 align-self-md-center'
...
...
changelogs/unreleased/241194-enable-vue_group_members_list-ff-by-default.yml
0 → 100644
View file @
6e3b4495
---
title
:
Enable `vue_group_members_list` feature flag by default
merge_request
:
47427
author
:
type
:
changed
config/feature_flags/development/vue_group_members_list.yml
View file @
6e3b4495
...
...
@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/241194
milestone
:
'
13.4'
type
:
development
group
:
group::access
default_enabled
:
fals
e
default_enabled
:
tru
e
qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb
View file @
6e3b4495
...
...
@@ -87,8 +87,6 @@ module QA
context
'Add user, change access level, remove user'
,
:requires_admin
,
testcase:
'https://gitlab.com/gitlab-org/quality/testcases/-/issues/734'
do
before
do
Runtime
::
Feature
.
enable
(
'vue_group_members_list'
,
group:
group
)
sign_in
group
.
visit!
Page
::
Group
::
Menu
.
perform
(
&
:click_group_members_item
)
...
...
@@ -99,10 +97,6 @@ module QA
end
end
after
do
Runtime
::
Feature
.
disable
(
'vue_group_members_list'
,
group:
group
)
end
it_behaves_like
'audit event'
,
[
'Added user access as Guest'
,
'Changed access level'
,
'Removed user access'
]
end
...
...
qa/qa/specs/features/ee/browser_ui/1_manage/group/share_group_with_group_spec.rb
View file @
6e3b4495
...
...
@@ -32,11 +32,6 @@ module QA
before
do
source_group_with_members
.
add_member
(
maintainer_user
,
Resource
::
Members
::
AccessLevel
::
MAINTAINER
)
Runtime
::
Feature
.
enable
(
'vue_group_members_list'
,
group:
target_group_with_project
)
end
after
do
Runtime
::
Feature
.
disable
(
'vue_group_members_list'
,
group:
target_group_with_project
)
end
it
'can be shared with another group with correct access level'
,
:requires_admin
,
testcase:
'https://gitlab.com/gitlab-org/quality/testcases/-/issues/945'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment