Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
6f2d7fa9
Commit
6f2d7fa9
authored
Oct 19, 2018
by
George Tsiolis
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove tooltip on sidebar text buttons
parent
82bd2a0b
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
14 additions
and
2 deletions
+14
-2
app/assets/javascripts/sidebar/components/todo_toggle/todo.vue
...ssets/javascripts/sidebar/components/todo_toggle/todo.vue
+4
-1
ee/changelogs/unreleased/gt-remove-tooltip-on-sidebar-text-buttons.yml
.../unreleased/gt-remove-tooltip-on-sidebar-text-buttons.yml
+5
-0
spec/javascripts/sidebar/todo_spec.js
spec/javascripts/sidebar/todo_spec.js
+5
-1
No files found.
app/assets/javascripts/sidebar/components/todo_toggle/todo.vue
View file @
6f2d7fa9
...
...
@@ -48,6 +48,9 @@ export default {
buttonLabel
()
{
return
this
.
isTodo
?
MARK_TEXT
:
TODO_TEXT
;
},
buttonTooltip
()
{
return
!
this
.
collapsed
?
undefined
:
this
.
buttonLabel
;
},
collapsedButtonIconClasses
()
{
return
this
.
isTodo
?
'
todo-undone
'
:
''
;
},
...
...
@@ -67,7 +70,7 @@ export default {
<button
v-tooltip
:class=
"buttonClasses"
:title=
"button
Label
"
:title=
"button
Tooltip
"
:aria-label=
"buttonLabel"
:data-issuable-id=
"issuableId"
:data-issuable-type=
"issuableType"
...
...
ee/changelogs/unreleased/gt-remove-tooltip-on-sidebar-text-buttons.yml
0 → 100644
View file @
6f2d7fa9
---
title
:
Remove tooltip on sidebar text buttons
merge_request
:
8021
author
:
George Tsiolis
type
:
other
spec/javascripts/sidebar/todo_spec.js
View file @
6f2d7fa9
...
...
@@ -116,7 +116,7 @@ describe('SidebarTodo', () => {
const
dataAttributes
=
{
issuableId
:
'
1
'
,
issuableType
:
'
epic
'
,
originalTitle
:
'
Mark todo as done
'
,
originalTitle
:
''
,
placement
:
'
left
'
,
container
:
'
body
'
,
boundary
:
'
viewport
'
,
...
...
@@ -130,6 +130,10 @@ describe('SidebarTodo', () => {
});
});
it
(
'
check button label computed property
'
,
()
=>
{
expect
(
vm
.
buttonLabel
).
toEqual
(
'
Mark todo as done
'
);
});
it
(
'
renders button label element when `collapsed` prop is `false`
'
,
()
=>
{
const
buttonLabelEl
=
vm
.
$el
.
querySelector
(
'
span.issuable-todo-inner
'
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment