Commit 7065bb3e authored by Filipa Lacerda's avatar Filipa Lacerda

Fix vue broken test

parent c28df4bc
...@@ -218,8 +218,10 @@ ...@@ -218,8 +218,10 @@
:img-size="40" :img-size="40"
/> />
</div> </div>
<div class="js-main-target-form timeline-content timeline-content-form common-note-form"> <div >
<form> <form
class="js-main-target-form timeline-content timeline-content-form common-note-form"
@submit="handleSave(true)">
<markdown-field <markdown-field
:markdown-preview-url="markdownPreviewUrl" :markdown-preview-url="markdownPreviewUrl"
:markdown-docs="markdownDocsUrl" :markdown-docs="markdownDocsUrl"
...@@ -228,7 +230,7 @@ ...@@ -228,7 +230,7 @@
<textarea <textarea
id="note-body" id="note-body"
name="note[note]" name="note[note]"
class="note-textarea js-gfm-input markdown-area" class="note-textarea js-gfm-input js-autosize markdown-area"
data-supports-quick-actions="true" data-supports-quick-actions="true"
aria-label="Description" aria-label="Description"
v-model="note" v-model="note"
...@@ -300,8 +302,7 @@ ...@@ -300,8 +302,7 @@
</ul> </ul>
</div> </div>
<button <button
type="button" type="submit"
@click="handleSave(true)"
v-if="canUpdateIssue" v-if="canUpdateIssue"
:class="actionButtonClassNames" :class="actionButtonClassNames"
class="btn btn-nr btn-comment btn-comment-and-close"> class="btn btn-nr btn-comment btn-comment-and-close">
......
...@@ -118,7 +118,8 @@ ...@@ -118,7 +118,8 @@
</div> </div>
<div class="flash-container timeline-content"></div> <div class="flash-container timeline-content"></div>
<form <form
class="edit-note common-note-form js-vue-quick-submit"> class="edit-note common-note-form"
@submit="handleUpdate">
<markdown-field <markdown-field
:markdown-preview-url="markdownPreviewUrl" :markdown-preview-url="markdownPreviewUrl"
:markdown-docs="markdownDocsUrl" :markdown-docs="markdownDocsUrl"
...@@ -141,8 +142,7 @@ ...@@ -141,8 +142,7 @@
</markdown-field> </markdown-field>
<div class="note-form-actions clearfix"> <div class="note-form-actions clearfix">
<button <button
type="button" type="submit"
@click="handleUpdate"
:disabled="isDisabled" :disabled="isDisabled"
class="btn btn-nr btn-save"> class="btn btn-nr btn-save">
{{saveButtonTitle}} {{saveButtonTitle}}
......
...@@ -38,19 +38,19 @@ import '~/behaviors/quick_submit'; ...@@ -38,19 +38,19 @@ import '~/behaviors/quick_submit';
return expect(this.spies.submit).not.toHaveBeenTriggered(); return expect(this.spies.submit).not.toHaveBeenTriggered();
}); });
it('disables input of type submit', function() { it('disables input of type submit', function() {
const submitButton = $('.js-vue-quick-submit input[type=submit]'); const submitButton = $('.js-quick-submit input[type=submit]');
this.textarea.trigger(keydownEvent()); this.textarea.trigger(keydownEvent());
expect(submitButton).toBeDisabled(); expect(submitButton).toBeDisabled();
}); });
it('disables button of type submit', function() { it('disables button of type submit', function() {
const submitButton = $('.js-vue-quick-submit input[type=submit]'); const submitButton = $('.js-quick-submit input[type=submit]');
this.textarea.trigger(keydownEvent()); this.textarea.trigger(keydownEvent());
expect(submitButton).toBeDisabled(); expect(submitButton).toBeDisabled();
}); });
it('only clicks one submit', function() { it('only clicks one submit', function() {
const existingSubmit = $('.js-vue-quick-submit input[type=submit]'); const existingSubmit = $('.js-quick-submit input[type=submit]');
// Add an extra submit button // Add an extra submit button
const newSubmit = $('<button type="submit">Submit it</button>'); const newSubmit = $('<button type="submit">Submit it</button>');
newSubmit.insertAfter(this.textarea); newSubmit.insertAfter(this.textarea);
......
...@@ -18,8 +18,7 @@ describe('issue placeholder system note component', () => { ...@@ -18,8 +18,7 @@ describe('issue placeholder system note component', () => {
it('should render system note placeholder with plain text', () => { it('should render system note placeholder with plain text', () => {
const vm = mountComponent('This is a placeholder'); const vm = mountComponent('This is a placeholder');
expect(vm.$el.tagName).toEqua('LI'); expect(vm.$el.tagName).toEqual('LI');
expect(vm.$el.querySelector('.timeline-content em').textContent.trim()).toEqual('This is a placeholder');
expect(vm.$el.querySelector('.timeline-content i').textContent.trim()).toEqua('This is a placeholder');
}); });
}); });
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment