Raise an error if creating the MergeRequestDiff fails

7639b580 · Nick Thomas · 0a70ba17 · 7639b580
Commit 7639b580 authored Jun 10, 2019 by Nick Thomas
Show whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

app/models/merge_request.rb app/models/merge_request.rb +1 -1

No files found.
--- a/app/models/merge_request.rb
+++ b/app/models/merge_request.rb
@@ -668,7 +668,7 @@ class MergeRequest < ApplicationRecord

    # n+1: https://gitlab.com/gitlab-org/gitlab-ce/issues/37435
    Gitlab::GitalyClient.allow_n_plus_1_calls do
-      merge_request_diffs.create
+      merge_request_diffs.create!
      reload_merge_request_diff
    end
  end