Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
7710235e
Commit
7710235e
authored
Jun 17, 2017
by
Gabriel Mazetto
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Added specs for failures in Geo repository sync and update services
parent
c5c2af93
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
12 additions
and
5 deletions
+12
-5
spec/services/geo/repository_sync_service_spec.rb
spec/services/geo/repository_sync_service_spec.rb
+4
-4
spec/services/geo/repository_update_service_spec.rb
spec/services/geo/repository_update_service_spec.rb
+8
-1
No files found.
spec/services/geo/repository_sync_service_spec.rb
View file @
7710235e
...
@@ -207,20 +207,20 @@ describe Geo::RepositorySyncService, services: true do
...
@@ -207,20 +207,20 @@ describe Geo::RepositorySyncService, services: true do
end
end
context
'when Gitlab::Shell::Error is raised'
do
context
'when Gitlab::Shell::Error is raised'
do
let
(
:project
)
{
create
(
:
project_empty_repo
)
}
let
(
:project
)
{
create
(
:
empty_project
)
}
it
'rescues exception'
do
it
'rescues exception'
do
allow
(
subject
).
to
receive
(
:fetch_project_repository
).
and_raise
(
Gitlab
::
Shell
::
Error
)
expect
(
subject
).
to
receive
(
:fetch_project_repository
).
and_raise
(
Gitlab
::
Shell
::
Error
)
expect
{
subject
.
execute
}.
not_to
raise_error
expect
{
subject
.
execute
}.
not_to
raise_error
end
end
end
end
context
'when Gitlab::Git::Repository::NoRepository is raised'
do
context
'when Gitlab::Git::Repository::NoRepository is raised'
do
let
(
:project
)
{
create
(
:
project_empty_repo
)
}
let
(
:project
)
{
create
(
:
empty_project
)
}
it
'rescues exception and fires after_create hook'
do
it
'rescues exception and fires after_create hook'
do
allow
(
subject
).
to
receive
(
:fetch_project_repository
).
and_raise
(
Gitlab
::
Git
::
Repository
::
NoRepository
)
expect
(
subject
).
to
receive
(
:fetch_project_repository
).
and_raise
(
Gitlab
::
Git
::
Repository
::
NoRepository
)
expect_any_instance_of
(
Repository
).
to
receive
(
:after_create
)
expect_any_instance_of
(
Repository
).
to
receive
(
:after_create
)
expect
{
subject
.
execute
}.
not_to
raise_error
expect
{
subject
.
execute
}.
not_to
raise_error
...
...
spec/services/geo/repository_update_service_spec.rb
View file @
7710235e
...
@@ -50,10 +50,17 @@ describe Geo::RepositoryUpdateService, services: true do
...
@@ -50,10 +50,17 @@ describe Geo::RepositoryUpdateService, services: true do
subject
.
execute
subject
.
execute
end
end
it
'
does not raise exception when git failures occur
s'
do
it
'
rescues Gitlab::Shell::Error failure
s'
do
expect
(
project
.
repository
).
to
receive
(
:fetch_geo_mirror
).
and_raise
(
Gitlab
::
Shell
::
Error
)
expect
(
project
.
repository
).
to
receive
(
:fetch_geo_mirror
).
and_raise
(
Gitlab
::
Shell
::
Error
)
expect
{
subject
.
execute
}.
not_to
raise_error
expect
{
subject
.
execute
}.
not_to
raise_error
end
end
it
'rescues Gitlab::Git::Repository::NoRepository failures and fires after_create hook'
do
expect
(
project
.
repository
).
to
receive
(
:fetch_geo_mirror
).
and_raise
(
Gitlab
::
Git
::
Repository
::
NoRepository
)
expect_any_instance_of
(
Repository
).
to
receive
(
:after_create
)
expect
{
subject
.
execute
}.
not_to
raise_error
end
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment