Merge branch 'remove-pages-tar-support' into 'master'

Remove support for legacy tar.gz pages artifacts

See merge request gitlab-org/gitlab-ce!18090

app/services/projects/update_pages_service.rb

@@ -74,25 +74,13 @@ module Projects
     end
 
     def extract_archive!(temp_path)
-      if artifacts.ends_with?('.tar.gz') || artifacts.ends_with?('.tgz')
-        extract_tar_archive!(temp_path)
-      elsif artifacts.ends_with?('.zip')
+      if artifacts.ends_with?('.zip')
         extract_zip_archive!(temp_path)
       else
         raise InvaildStateError, 'unsupported artifacts format'
       end
     end
 
-    def extract_tar_archive!(temp_path)
-      build.artifacts_file.use_file do |artifacts_path|
-        results = Open3.pipeline(%W(gunzip -c #{artifacts_path}),
-                                %W(dd bs=#{BLOCK_SIZE} count=#{blocks}),
-                                %W(tar -x -C #{temp_path} #{SITE_PATH}),
-                                err: '/dev/null')
-        raise FailedToExtractError, 'pages failed to extract' unless results.compact.all?(&:success?)
-      end
-    end
-
     def extract_zip_archive!(temp_path)
       raise InvaildStateError, 'missing artifacts metadata' unless build.artifacts_metadata?
 

changelogs/unreleased/remove-pages-tar-support.yml

+---
+title: Remove support for legacy tar.gz pages artifacts
+merge_request: 18090
+author:
+type: deprecated

spec/services/projects/update_pages_service_spec.rb

@@ -21,10 +21,8 @@ describe Projects::UpdatePagesService do
   end
 
   context 'legacy artifacts' do
-    %w(tar.gz zip).each do |format|
-      let(:extension) { format }
+    let(:extension) { 'zip' }
 
-      context "for valid #{format}" do
     before do
       build.update_attributes(legacy_artifacts_file: file)
       build.update_attributes(legacy_artifacts_metadata: metadata)
@@ -91,8 +89,6 @@ describe Projects::UpdatePagesService do
         .to raise_error(Projects::UpdatePagesService::FailedToExtractError)
     end
   end
-    end
-  end
 
   context 'for new artifacts' do
     context "for a valid job" do