Merge branch 'more-frozen-string-enable-lib' into 'master'

Enable more frozen string in lib/**/*.rb

See merge request gitlab-org/gitlab-ce!22174

changelogs/unreleased/more-frozen-string-enable-lib.yml

+---
+title: Enable more frozen string in lib/**/*.rb
+merge_request:
+author: gfyoung
+type: performance

lib/after_commit_queue.rb

+# frozen_string_literal: true
+
 module AfterCommitQueue
   extend ActiveSupport::Concern
 

lib/backup.rb

+# frozen_string_literal: true
+
 module Backup
   Error = Class.new(StandardError)
 end

lib/banzai.rb

+# frozen_string_literal: true
+
 module Banzai
   # if you need to render markdown, then you probably need to post_process as well,
   # such as removing references that the current user doesn't have

lib/banzai/color_parser.rb

+# frozen_string_literal: true
+
 module Banzai
   module ColorParser
     ALPHA = /0(?:\.\d+)?|\.\d+|1(?:\.0+)?/ # 0.0..1.0

lib/banzai/commit_renderer.rb

+# frozen_string_literal: true
+
 module Banzai
   module CommitRenderer
     ATTRIBUTES = [:description, :title].freeze

lib/banzai/cross_project_reference.rb

+# frozen_string_literal: true
+
 module Banzai
   # Common methods for ReferenceFilters that support an optional cross-project
   # reference.

lib/banzai/filter.rb

+# frozen_string_literal: true
+
 module Banzai
   module Filter
     def self.[](name)

lib/banzai/filter/markdown_engines/common_mark.rb

+# frozen_string_literal: true
+
 # `CommonMark` markdown engine for GitLab's Banzai markdown filter.
 # This module is used in Banzai::Filter::MarkdownFilter.
 # Used gem is `commonmarker` which is a ruby wrapper for libcmark (CommonMark parser)

lib/banzai/filter/markdown_engines/redcarpet.rb

+# frozen_string_literal: true
+
 # `Redcarpet` markdown engine for GitLab's Banzai markdown filter.
 # This module is used in Banzai::Filter::MarkdownFilter.
 # Used gem is `redcarpet` which is a ruby library for markdown processing.

lib/banzai/filter/wiki_link_filter/rewriter.rb

+# frozen_string_literal: true
+
 module Banzai
   module Filter
     class WikiLinkFilter < HTML::Pipeline::Filter

lib/banzai/filter_array.rb

+# frozen_string_literal: true
+
 module Banzai
   class FilterArray < Array
     # Insert a value immediately after another value

lib/banzai/issuable_extractor.rb

+# frozen_string_literal: true
+
 module Banzai
   # Extract references to issuables from multiple documents
 

lib/banzai/object_renderer.rb

+# frozen_string_literal: true
+
 module Banzai
   # Class for rendering multiple objects (e.g. Note instances) in a single pass,
   # using +render_field+ to benefit from caching in the database. Rendering and

lib/banzai/pipeline.rb

+# frozen_string_literal: true
+
 module Banzai
   module Pipeline
     def self.[](name)

lib/banzai/pipeline/ascii_doc_pipeline.rb

+# frozen_string_literal: true
+
 module Banzai
   module Pipeline
     class AsciiDocPipeline < BasePipeline

lib/banzai/pipeline/atom_pipeline.rb

+# frozen_string_literal: true
+
 module Banzai
   module Pipeline
     class AtomPipeline < FullPipeline

lib/banzai/pipeline/base_pipeline.rb

+# frozen_string_literal: true
+
 module Banzai
   module Pipeline
     class BasePipeline

lib/banzai/pipeline/broadcast_message_pipeline.rb

+# frozen_string_literal: true
+
 module Banzai
   module Pipeline
     class BroadcastMessagePipeline < DescriptionPipeline

lib/banzai/pipeline/combined_pipeline.rb

+# frozen_string_literal: true
+
 module Banzai
   module Pipeline
     module CombinedPipeline

lib/banzai/pipeline/commit_description_pipeline.rb

+# frozen_string_literal: true
+
 module Banzai
   module Pipeline
     class CommitDescriptionPipeline < SingleLinePipeline

lib/banzai/pipeline/description_pipeline.rb

+# frozen_string_literal: true
+
 module Banzai
   module Pipeline
     class DescriptionPipeline < FullPipeline

lib/banzai/pipeline/email_pipeline.rb

+# frozen_string_literal: true
+
 module Banzai
   module Pipeline
     class EmailPipeline < FullPipeline

lib/banzai/pipeline/full_pipeline.rb

+# frozen_string_literal: true
+
 module Banzai
   module Pipeline
     class FullPipeline < CombinedPipeline.new(PlainMarkdownPipeline, GfmPipeline)

lib/banzai/pipeline/gfm_pipeline.rb

+# frozen_string_literal: true
+
 module Banzai
   module Pipeline
     class GfmPipeline < BasePipeline

lib/banzai/pipeline/markup_pipeline.rb

+# frozen_string_literal: true
+
 module Banzai
   module Pipeline
     class MarkupPipeline < BasePipeline

lib/banzai/pipeline/note_pipeline.rb

+# frozen_string_literal: true
+
 module Banzai
   module Pipeline
     class NotePipeline < FullPipeline

lib/banzai/pipeline/plain_markdown_pipeline.rb

+# frozen_string_literal: true
+
 module Banzai
   module Pipeline
     class PlainMarkdownPipeline < BasePipeline

lib/banzai/pipeline/post_process_pipeline.rb

+# frozen_string_literal: true
+
 module Banzai
   module Pipeline
     class PostProcessPipeline < BasePipeline

lib/banzai/pipeline/pre_process_pipeline.rb

+# frozen_string_literal: true
+
 module Banzai
   module Pipeline
     class PreProcessPipeline < BasePipeline

lib/banzai/pipeline/relative_link_pipeline.rb

+# frozen_string_literal: true
+
 module Banzai
   module Pipeline
     class RelativeLinkPipeline < BasePipeline

lib/banzai/pipeline/single_line_pipeline.rb

+# frozen_string_literal: true
+
 module Banzai
   module Pipeline
     class SingleLinePipeline < GfmPipeline

lib/banzai/pipeline/wiki_pipeline.rb

+# frozen_string_literal: true
+
 module Banzai
   module Pipeline
     class WikiPipeline < FullPipeline

lib/banzai/querying.rb

+# frozen_string_literal: true
+
 module Banzai
   module Querying
     module_function

lib/banzai/redactor.rb

+# frozen_string_literal: true
+
 module Banzai
   # Class for removing Markdown references a certain user is not allowed to
   # view.

lib/banzai/reference_extractor.rb

+# frozen_string_literal: true
+
 module Banzai
   # Extract possible GFM references from an arbitrary String for further processing.
   class ReferenceExtractor

lib/banzai/reference_parser.rb

+# frozen_string_literal: true
+
 module Banzai
   module ReferenceParser
     # Returns the reference parser class for the given type

lib/banzai/reference_parser/base_parser.rb

+# frozen_string_literal: true
+
 module Banzai
   module ReferenceParser
     # Base class for reference parsing classes.

lib/banzai/reference_parser/commit_parser.rb

+# frozen_string_literal: true
+
 module Banzai
   module ReferenceParser
     class CommitParser < BaseParser

lib/banzai/reference_parser/commit_range_parser.rb

+# frozen_string_literal: true
+
 module Banzai
   module ReferenceParser
     class CommitRangeParser < BaseParser

lib/banzai/reference_parser/directly_addressed_user_parser.rb

+# frozen_string_literal: true
+
 module Banzai
   module ReferenceParser
     class DirectlyAddressedUserParser < UserParser

lib/banzai/reference_parser/epic_parser.rb

+# frozen_string_literal: true
+
 module Banzai
   module ReferenceParser
     # The actual parser is implemented in the EE mixin

lib/banzai/reference_parser/external_issue_parser.rb

+# frozen_string_literal: true
+
 module Banzai
   module ReferenceParser
     class ExternalIssueParser < BaseParser

lib/banzai/reference_parser/issuable_parser.rb

+# frozen_string_literal: true
+
 module Banzai
   module ReferenceParser
     class IssuableParser < BaseParser

lib/banzai/reference_parser/issue_parser.rb

+# frozen_string_literal: true
+
 module Banzai
   module ReferenceParser
     class IssueParser < IssuableParser

lib/banzai/reference_parser/label_parser.rb

+# frozen_string_literal: true
+
 module Banzai
   module ReferenceParser
     class LabelParser < BaseParser

lib/banzai/reference_parser/merge_request_parser.rb

+# frozen_string_literal: true
+
 module Banzai
   module ReferenceParser
     class MergeRequestParser < IssuableParser

lib/banzai/reference_parser/milestone_parser.rb

+# frozen_string_literal: true
+
 module Banzai
   module ReferenceParser
     class MilestoneParser < BaseParser

lib/banzai/reference_parser/snippet_parser.rb

+# frozen_string_literal: true
+
 module Banzai
   module ReferenceParser
     class SnippetParser < BaseParser

lib/banzai/reference_parser/user_parser.rb

+# frozen_string_literal: true
+
 module Banzai
   module ReferenceParser
     class UserParser < BaseParser

lib/banzai/renderer.rb

+# frozen_string_literal: true
+
 module Banzai
   module Renderer
     # Convert a Markdown String into an HTML-safe String of HTML

lib/banzai/renderer/common_mark/html.rb

+# frozen_string_literal: true
+
 module Banzai
   module Renderer
     module CommonMark

lib/banzai/renderer/redcarpet/html.rb

+# frozen_string_literal: true
+
 module Banzai
   module Renderer
     module Redcarpet

lib/banzai/request_store_reference_cache.rb

+# frozen_string_literal: true
+
 module Banzai
   module RequestStoreReferenceCache
     def cached_call(request_store_key, cache_key, path: [])

lib/bitbucket/client.rb

+# frozen_string_literal: true
+
 module Bitbucket
   class Client
     attr_reader :connection

lib/bitbucket/collection.rb

+# frozen_string_literal: true
+
 module Bitbucket
   class Collection < Enumerator
     def initialize(paginator)

lib/bitbucket/connection.rb

+# frozen_string_literal: true
+
 module Bitbucket
   class Connection
     DEFAULT_API_VERSION = '2.0'.freeze

lib/bitbucket/error/unauthorized.rb

+# frozen_string_literal: true
+
 module Bitbucket
   module Error
     Unauthorized = Class.new(StandardError)

lib/bitbucket/page.rb

+# frozen_string_literal: true
+
 module Bitbucket
   class Page
     attr_reader :attrs, :items

lib/bitbucket/paginator.rb

+# frozen_string_literal: true
+
 module Bitbucket
   class Paginator
     PAGE_LENGTH = 50 # The minimum length is 10 and the maximum is 100.

lib/bitbucket/representation/base.rb

+# frozen_string_literal: true
+
 module Bitbucket
   module Representation
     class Base

lib/bitbucket/representation/comment.rb

+# frozen_string_literal: true
+
 module Bitbucket
   module Representation
     class Comment < Representation::Base

lib/bitbucket/representation/issue.rb

+# frozen_string_literal: true
+
 module Bitbucket
   module Representation
     class Issue < Representation::Base

lib/bitbucket/representation/pull_request.rb

+# frozen_string_literal: true
+
 module Bitbucket
   module Representation
     class PullRequest < Representation::Base

lib/bitbucket/representation/pull_request_comment.rb

+# frozen_string_literal: true
+
 module Bitbucket
   module Representation
     class PullRequestComment < Comment

lib/bitbucket/representation/repo.rb

+# frozen_string_literal: true
+
 module Bitbucket
   module Representation
     class Repo < Representation::Base

lib/bitbucket/representation/user.rb

+# frozen_string_literal: true
+
 module Bitbucket
   module Representation
     class User < Representation::Base

lib/carrier_wave_string_file.rb

+# frozen_string_literal: true
+
 class CarrierWaveStringFile < StringIO
   def original_filename
     ""

lib/constraints/feature_constrainer.rb

+# frozen_string_literal: true
+
 module Constraints
   class FeatureConstrainer
     attr_reader :feature

lib/constraints/group_url_constrainer.rb

+# frozen_string_literal: true
+
 module Constraints
   class GroupUrlConstrainer
     def matches?(request)

lib/constraints/project_url_constrainer.rb

+# frozen_string_literal: true
+
 module Constraints
   class ProjectUrlConstrainer
     def matches?(request)

lib/constraints/user_url_constrainer.rb

+# frozen_string_literal: true
+
 module Constraints
   class UserUrlConstrainer
     def matches?(request)

lib/container_registry/blob.rb

+# frozen_string_literal: true
+
 module ContainerRegistry
   class Blob
     attr_reader :repository, :config

lib/container_registry/client.rb

+# frozen_string_literal: true
+
 require 'faraday'
 require 'faraday_middleware'
 

lib/container_registry/config.rb

+# frozen_string_literal: true
+
 module ContainerRegistry
   class Config
     attr_reader :tag, :blob, :data

lib/container_registry/path.rb

+# frozen_string_literal: true
+
 module ContainerRegistry
   ##
   # Class responsible for extracting project and repository name from

lib/container_registry/registry.rb

+# frozen_string_literal: true
+
 module ContainerRegistry
   class Registry
     attr_reader :uri, :client, :path

lib/container_registry/tag.rb

+# frozen_string_literal: true
+
 module ContainerRegistry
   class Tag
     attr_reader :repository, :name

lib/declarative_policy.rb

+# frozen_string_literal: true
+
 require_dependency 'declarative_policy/cache'
 require_dependency 'declarative_policy/condition'
 require_dependency 'declarative_policy/delegate_dsl'

lib/declarative_policy/base.rb

+# frozen_string_literal: true
+
 module DeclarativePolicy
   class Base
     # A map of ability => list of rules together with :enable

lib/declarative_policy/cache.rb

+# frozen_string_literal: true
+
 module DeclarativePolicy
   module Cache
     class << self

lib/declarative_policy/condition.rb

+# frozen_string_literal: true
+
 module DeclarativePolicy
   # A Condition is the data structure that is created by the
   # `condition` declaration on DeclarativePolicy::Base. It is

lib/declarative_policy/delegate_dsl.rb

+# frozen_string_literal: true
+
 module DeclarativePolicy
   # Used when the name of a delegate is mentioned in
   # the rule DSL.

lib/declarative_policy/policy_dsl.rb

+# frozen_string_literal: true
+
 module DeclarativePolicy
   # The return value of a rule { ... } declaration.
   # Can call back to register rules with the containing

lib/declarative_policy/preferred_scope.rb

-module DeclarativePolicy # rubocop:disable Naming/FileName
+# rubocop:disable Naming/FileName
+# frozen_string_literal: true
+
+module DeclarativePolicy
   PREFERRED_SCOPE_KEY = :"DeclarativePolicy.preferred_scope"
 
   class << self

lib/declarative_policy/rule.rb

+# frozen_string_literal: true
+
 module DeclarativePolicy
   module Rule
     # A Rule is the object that results from the `rule` declaration,

lib/declarative_policy/rule_dsl.rb

+# frozen_string_literal: true
+
 module DeclarativePolicy
   # The DSL evaluation context inside rule { ... } blocks.
   # Responsible for creating and combining Rule objects.

lib/declarative_policy/runner.rb

+# frozen_string_literal: true
+
 module DeclarativePolicy
   class Runner
     class State

lib/declarative_policy/step.rb

+# frozen_string_literal: true
+
 module DeclarativePolicy
   # This object represents one step in the runtime decision of whether
   # an ability is allowed. It contains a Rule and a context (instance

lib/expand_variables.rb

+# frozen_string_literal: true
+
 module ExpandVariables
   class << self
     def expand(value, variables)

lib/extracts_path.rb

+# frozen_string_literal: true
+
 # Module providing methods for dealing with separating a tree-ish string and a
 # file path string when combined in a request parameter
 module ExtractsPath
@@ -50,7 +52,9 @@ module ExtractsPath
       # branches and tags
 
       # Append a trailing slash if we only get a ref and no file path
-      id += '/' unless id.ends_with?('/')
+      unless id.ends_with?('/')
+        id = [id, '/'].join
+      end
 
       valid_refs = ref_names.select { |v| id.start_with?("#{v}/") }
 
@@ -151,9 +155,9 @@ module ExtractsPath
 
   # overriden in subclasses, do not remove
   def get_id
-    id = params[:id] || params[:ref]
-    id += "/" + params[:path] unless params[:path].blank?
-    id
+    id = [params[:id] || params[:ref]]
+    id << "/" + params[:path] unless params[:path].blank?
+    id.join
   end
 
   def ref_names

lib/feature.rb

+# frozen_string_literal: true
+
 require 'flipper/adapters/active_record'
 require 'flipper/adapters/active_support_cache_store'
 

lib/file_size_validator.rb

+# frozen_string_literal: true
+
 class FileSizeValidator < ActiveModel::EachValidator
   MESSAGES = { is: :wrong_size, minimum: :size_too_small, maximum: :size_too_big }.freeze
   CHECKS   = { is: :==, minimum: :>=, maximum: :<= }.freeze

lib/forever.rb

+# frozen_string_literal: true
+
 class Forever
   POSTGRESQL_DATE = DateTime.new(3000, 1, 1)
   MYSQL_DATE = DateTime.new(2038, 01, 19)

lib/gitlab.rb

+# frozen_string_literal: true
+
 require_dependency 'gitlab/popen'
 
 module Gitlab

lib/gt_one_coercion.rb

+# frozen_string_literal: true
+
 class GtOneCoercion < Virtus::Attribute
   def coerce(value)
     [1, value.to_i].max

lib/milestone_array.rb

+# frozen_string_literal: true
+
 module MilestoneArray
   class << self
     def sort(array, sort_method)

lib/mysql_zero_date.rb

+# frozen_string_literal: true
+
 # Disable NO_ZERO_DATE mode for mysql in rails 5.
 # We use zero date as a default value
 # (config/initializers/active_record_mysql_timestamp.rb), in

lib/static_model.rb

+# frozen_string_literal: true
+
 # Provides an ActiveRecord-like interface to a model whose data is not persisted to a database.
 module StaticModel
   extend ActiveSupport::Concern

lib/system_check.rb

+# frozen_string_literal: true
+
 # Library to perform System Checks
 #
 # Every Check is implemented as its own class inherited from SystemCheck::BaseCheck

lib/unfold_form.rb

+# frozen_string_literal: true
+
 require_relative 'gt_one_coercion'
 
 class UnfoldForm

lib/uploaded_file.rb

+# frozen_string_literal: true
+
 require "tempfile"
 require "tmpdir"
 require "fileutils"

lib/version_check.rb

+# frozen_string_literal: true
+
 require "base64"
 
 # This class is used to build image URL to