Merge branch 'ee-pipelines_show_refactor' into 'master'

Refactor pipelines show for webpack bundle tag removal (EE)

See merge request gitlab-org/gitlab-ee!4755

app/assets/javascripts/pages/projects/pipelines/builds/index.js

+import initPipelineDetails from '~/pipelines/pipeline_details_bundle';
 import initPipelines from '../init_pipelines';
 
-document.addEventListener('DOMContentLoaded', initPipelines);
+document.addEventListener('DOMContentLoaded', () => {
+  initPipelines();
+  initPipelineDetails();
+});

app/assets/javascripts/pages/projects/pipelines/show/index.js

+import initPipelineDetails from '~/pipelines/pipeline_details_bundle';
 import initPipelines from '../init_pipelines';
 
-document.addEventListener('DOMContentLoaded', initPipelines);
+document.addEventListener('DOMContentLoaded', () => {
+  initPipelines();
+  initPipelineDetails();
+});

app/assets/javascripts/pipelines/pipeline_details_bundle.js

@@ -12,9 +12,7 @@ import SastSummaryWidget from 'ee/pipelines/components/security_reports/sast_rep
 
 Vue.use(Translate);
 
-Vue.use(Translate);
-
-document.addEventListener('DOMContentLoaded', () => {
+export default () => {
   const dataset = document.querySelector('.js-pipeline-details-vue').dataset;
 
   const mediator = new PipelinesMediator({ endpoint: dataset.endpoint });
@@ -144,4 +142,4 @@ document.addEventListener('DOMContentLoaded', () => {
       },
     });
   }
-});
+};

app/views/projects/pipelines/show.html.haml

@@ -13,4 +13,3 @@
 
 - content_for :page_specific_javascripts do
   = webpack_bundle_tag('common_vue')
-  = webpack_bundle_tag('pipelines_details')

config/webpack.config.js

@@ -56,7 +56,6 @@ function generateEntries() {
     mr_notes:             './mr_notes/index.js',
     notebook_viewer:      './blob/notebook_viewer.js',
     pdf_viewer:           './blob/pdf_viewer.js',
-    pipelines_details:    './pipelines/pipeline_details_bundle.js',
     project_import_gl:    './projects/project_import_gitlab_project.js',
     protected_branches:   './protected_branches',
     protected_tags:       './protected_tags',

ee/app/assets/javascripts/pages/projects/pipelines/security/index.js

+import initPipelineDetails from '~/pipelines/pipeline_details_bundle';
 import initPipelines from '~/pages/projects/pipelines/init_pipelines';
 
-document.addEventListener('DOMContentLoaded', initPipelines);
+document.addEventListener('DOMContentLoaded', () => {
+  initPipelines();
+  initPipelineDetails();
+});