Merge branch 'rspec-empty-line-after-letitbe-ee-spec-services-ci' into 'master'

Fix RSpec/EmptyLineAfterFinalLetItBe for ee/spec/services/ci

See merge request gitlab-org/gitlab!58354

.rubocop_manual_todo.yml

@@ -574,15 +574,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - ee/spec/services/award_emojis/destroy_service_spec.rb
     - ee/spec/services/billable_members/destroy_service_spec.rb
     - ee/spec/services/boards/epic_boards/destroy_service_spec.rb
-    - ee/spec/services/ci/audit_variable_change_service_spec.rb
-    - ee/spec/services/ci/compare_license_scanning_reports_service_spec.rb
-    - ee/spec/services/ci/compare_metrics_reports_service_spec.rb
-    - ee/spec/services/ci/compare_security_reports_service_spec.rb
-    - ee/spec/services/ci/create_pipeline_service/needs_spec.rb
-    - ee/spec/services/ci/create_pipeline_service_spec.rb
-    - ee/spec/services/ci/external_pull_requests/process_github_event_service_spec.rb
-    - ee/spec/services/ci/pipeline_bridge_status_service_spec.rb
-    - ee/spec/services/ci/register_job_service_spec.rb
     - ee/spec/services/clusters/agent_tokens/create_service_spec.rb
     - ee/spec/services/compliance_management/frameworks/create_service_spec.rb
     - ee/spec/services/compliance_management/frameworks/update_service_spec.rb

ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-ci.yml

+---
+title: Fix RSpec/EmptyLineAfterFinalLetItBe rubocop offenses in ee/spec/services/ci
+merge_request: 58354
+author: Abdul Wadood @abdulwd
+type: fixed

ee/spec/services/ci/audit_variable_change_service_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe Ci::AuditVariableChangeService do
   subject(:execute) { service.execute }
 
   let_it_be(:user) { create(:user) }
+
   let(:group) { create(:group) }
   let(:variable) { create(:ci_group_variable) }
 

ee/spec/services/ci/compare_license_scanning_reports_service_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe Ci::CompareLicenseScanningReportsService do
   include ProjectForksHelper
 
   let_it_be(:project) { create(:project, :repository) }
+
   let(:service) { described_class.new(project, nil) }
 
   before do

ee/spec/services/ci/compare_metrics_reports_service_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Ci::CompareMetricsReportsService do
   let_it_be(:project) { create(:project, :repository) }
+
   let(:service) { described_class.new(project) }
 
   before do

ee/spec/services/ci/compare_security_reports_service_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Ci::CompareSecurityReportsService do
   let_it_be(:project) { create(:project, :repository) }
+
   let(:current_user) { project.owner }
 
   def collect_ids(collection)

ee/spec/services/ci/create_pipeline_service/needs_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Ci::CreatePipelineService do
   let_it_be(:downstream_project) { create(:project, name: 'project', namespace: create(:namespace, name: 'some')) }
+
   let(:project) { create(:project, :repository) }
   let(:user) { project.owner }
   let(:service) { described_class.new(project, user, { ref: 'refs/heads/master' }) }

ee/spec/services/ci/create_pipeline_service_spec.rb

@@ -8,6 +8,7 @@ RSpec.describe Ci::CreatePipelineService, '#execute' do
   let_it_be(:plan_limits) { create(:plan_limits, plan: ultimate_plan) }
   let_it_be(:project, reload: true) { create(:project, :repository, namespace: namespace) }
   let_it_be(:user) { create(:user) }
+
   let(:ref_name) { 'master' }
 
   let(:service) do

ee/spec/services/ci/external_pull_requests/process_github_event_service_spec.rb

@@ -5,6 +5,7 @@ require 'spec_helper'
 RSpec.describe Ci::ExternalPullRequests::ProcessGithubEventService do
   let_it_be(:project) { create(:project, :repository) }
   let_it_be(:user) { create(:user) }
+
   let(:action) { 'opened' }
   let(:params) do
     {

ee/spec/services/ci/pipeline_bridge_status_service_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Ci::PipelineBridgeStatusService do
   let_it_be(:project) { create(:project) }
+
   let(:user) { build(:user) }
   let(:pipeline) { build(:ci_pipeline, project: project) }
 

ee/spec/services/ci/register_job_service_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Ci::RegisterJobService do
   let_it_be(:shared_runner) { create(:ci_runner, :instance) }
+
   let!(:project) { create :project, shared_runners_enabled: true }
   let!(:pipeline) { create :ci_empty_pipeline, project: project }
   let!(:pending_build) { create :ci_build, pipeline: pipeline }