Merge branch 'vs-migrate-ci-variable-list-to-jest' into 'master'

Migrate ee/ci_variable_list to Jest

Closes #194273

See merge request gitlab-org/gitlab!28461

ee/spec/javascripts/ci_variable_list/ci_variable_list_ee_spec.js → ee/spec/frontend/ci_variable_list/ci_variable_list_ee_spec.js

 import $ from 'jquery';
-import getSetTimeoutPromise from 'spec/helpers/set_timeout_promise_helper';
 import VariableList from '~/ci_variable_list/ci_variable_list';
 
 describe('VariableList (EE features)', () => {
@@ -37,12 +36,12 @@ describe('VariableList (EE features)', () => {
         $row.find('.js-variable-environment-dropdown-wrapper .js-dropdown-create-new-item').click();
       }
 
-      it('should add another row when editing the last rows environment dropdown', done => {
+      it('should add another row when editing the last rows environment dropdown', () => {
         addRowByNewEnvironment('someenv');
 
-        getSetTimeoutPromise()
-          .then(() => {
-            expect($wrapper.find('.js-row').length).toBe(2);
+        jest.runOnlyPendingTimers();
+
+        expect($wrapper.find('.js-row')).toHaveLength(2);
 
         // Check for the correct default in the new row
         const $environmentInput = $wrapper
@@ -50,41 +49,36 @@ describe('VariableList (EE features)', () => {
           .find('input[name="variables[variables_attributes][][environment_scope]"]');
 
         expect($environmentInput.val()).toBe('*');
-          })
-          .then(done)
-          .catch(done.fail);
       });
 
-      it('should update dropdown with new environment values and remove values when row is removed', done => {
+      it('should update dropdown with new environment values and remove values when row is removed', () => {
         addRowByNewEnvironment('someenv');
 
         const $row = $wrapper.find('.js-row:last-child');
         $row.find('.js-variable-environment-toggle').click();
 
-        getSetTimeoutPromise()
-          .then(() => {
+        jest.runOnlyPendingTimers();
+
         const $dropdownItemsBeforeRemove = $row.find(
           '.js-variable-environment-dropdown-wrapper .dropdown-content a',
         );
 
-            expect($dropdownItemsBeforeRemove.length).toBe(2);
+        expect($dropdownItemsBeforeRemove).toHaveLength(2);
         expect($dropdownItemsBeforeRemove[0].textContent.trim()).toBe('someenv');
         expect($dropdownItemsBeforeRemove[1].textContent.trim()).toBe('* (All environments)');
 
         $wrapper.find('.js-row-remove-button').trigger('click');
 
-            expect($wrapper.find('.js-row').length).toBe(0);
-          })
-          .then(() => {
+        expect($wrapper.find('.js-row')).toHaveLength(0);
+
+        jest.runOnlyPendingTimers();
+
         const $dropdownItemsAfterRemove = $row.find(
           '.js-variable-environment-dropdown-wrapper .dropdown-content a',
         );
 
-            expect($dropdownItemsAfterRemove.length).toBe(1);
+        expect($dropdownItemsAfterRemove).toHaveLength(1);
         expect($dropdownItemsAfterRemove[0].textContent.trim()).toBe('* (All environments)');
-          })
-          .then(done)
-          .catch(done.fail);
       });
     });
   });