Merge branch 'lm-replace-dirty-submit' into 'master'

Replaces underscore with lodash in javascripts/dirty_submit

See merge request gitlab-org/gitlab!28386

app/assets/javascripts/dirty_submit/dirty_submit_form.js

-import _ from 'underscore';
+import { memoize, throttle } from 'lodash';
 import $ from 'jquery';
 
 class DirtySubmitForm {
@@ -21,8 +21,8 @@ class DirtySubmitForm {
   }
 
   registerListeners() {
-    const getThrottledHandlerForInput = _.memoize(() =>
-      _.throttle(event => this.updateDirtyInput(event), DirtySubmitForm.THROTTLE_DURATION),
+    const getThrottledHandlerForInput = memoize(() =>
+      throttle(event => this.updateDirtyInput(event), DirtySubmitForm.THROTTLE_DURATION),
     );
 
     const throttledUpdateDirtyInput = event => {

spec/javascripts/dirty_submit/dirty_submit_form_spec.js

@@ -70,6 +70,7 @@ describe('DirtySubmitForm', () => {
   describe('throttling tests', () => {
     beforeEach(() => {
       jasmine.clock().install();
+      jasmine.clock().mockDate();
       DirtySubmitForm.THROTTLE_DURATION = 100;
     });