Commit 8842a769 authored by Rémy Coutable's avatar Rémy Coutable

Merge branch 'danger-gitaly-bump' into 'master'

Add gitaly gem bump danger check

See merge request gitlab-org/gitlab!65325
parents 40ec9ce4 f06b84ef
# frozen_string_literal: true
TEMPLATE_MESSAGE = <<~MSG
This merge request requires coordination with gitaly deployments.
Before merging this merge request we should verify that gitaly
running in production already implements the new gRPC interface
included here.
Failing to do so will introduce a [non backward compatible
change](https://docs.gitlab.com/ee/development/multi_version_compatibility.html)
during canary depoyment that can cause an incident.
1. Identify the gitaly MR introducing the new interface
1. Verify that the environment widget contains a `gprd` deployment
MSG
changed_lines = helper.changed_lines('Gemfile.lock')
if changed_lines.any? { |line| line =~ /^\+\s+gitaly \(/ }
warn 'Changing gitaly gem can cause a multi-version incompatibility incident'
markdown(TEMPLATE_MESSAGE)
end
...@@ -221,7 +221,7 @@ RSpec.describe Tooling::Danger::ProjectHelper do ...@@ -221,7 +221,7 @@ RSpec.describe Tooling::Danger::ProjectHelper do
describe '.local_warning_message' do describe '.local_warning_message' do
it 'returns an informational message with rules that can run' do it 'returns an informational message with rules that can run' do
expect(described_class.local_warning_message).to eq('==> Only the following Danger rules can be run locally: changelog, database, datateam, documentation, duplicate_yarn_dependencies, eslint, karma, pajamas, pipeline, prettier, product_intelligence, utility_css') expect(described_class.local_warning_message).to eq('==> Only the following Danger rules can be run locally: changelog, database, datateam, documentation, duplicate_yarn_dependencies, eslint, gitaly, karma, pajamas, pipeline, prettier, product_intelligence, utility_css')
end end
end end
......
...@@ -10,6 +10,7 @@ module Tooling ...@@ -10,6 +10,7 @@ module Tooling
documentation documentation
duplicate_yarn_dependencies duplicate_yarn_dependencies
eslint eslint
gitaly
karma karma
pajamas pajamas
pipeline pipeline
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment