Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
89c8d226
Commit
89c8d226
authored
Jul 08, 2021
by
Olena Horal-Koretska
Committed by
Brandon Labuschagne
Jul 08, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Escalation rule updates do not trigger request parameters recalculation
parent
715fc55a
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
2 deletions
+4
-2
ee/app/assets/javascripts/escalation_policies/components/add_edit_escalation_policy_modal.vue
..._policies/components/add_edit_escalation_policy_modal.vue
+2
-2
ee/spec/frontend/escalation_policies/add_edit_escalation_policy_modal_spec.js
...alation_policies/add_edit_escalation_policy_modal_spec.js
+2
-0
No files found.
ee/app/assets/javascripts/escalation_policies/components/add_edit_escalation_policy_modal.vue
View file @
89c8d226
<
script
>
<
script
>
import
{
GlModal
,
GlAlert
}
from
'
@gitlab/ui
'
;
import
{
GlModal
,
GlAlert
}
from
'
@gitlab/ui
'
;
import
{
set
,
isEqual
}
from
'
lodash
'
;
import
{
isEqual
}
from
'
lodash
'
;
import
{
s__
,
__
}
from
'
~/locale
'
;
import
{
s__
,
__
}
from
'
~/locale
'
;
import
{
import
{
updateStoreOnEscalationPolicyCreate
,
updateStoreOnEscalationPolicyCreate
,
...
@@ -103,7 +103,7 @@ export default {
...
@@ -103,7 +103,7 @@ export default {
};
};
},
},
updateForm
({
field
,
value
})
{
updateForm
({
field
,
value
})
{
set
(
this
.
form
,
field
,
value
)
;
this
.
form
=
{
...
this
.
form
,
[
field
]:
value
}
;
this
.
validateForm
(
field
);
this
.
validateForm
(
field
);
},
},
createEscalationPolicy
()
{
createEscalationPolicy
()
{
...
...
ee/spec/frontend/escalation_policies/add_edit_escalation_policy_modal_spec.js
View file @
89c8d226
...
@@ -110,6 +110,7 @@ describe('AddEditsEscalationPolicyModal', () => {
...
@@ -110,6 +110,7 @@ describe('AddEditsEscalationPolicyModal', () => {
it
(
'
clears the form on modal cancel
'
,
async
()
=>
{
it
(
'
clears the form on modal cancel
'
,
async
()
=>
{
updateForm
();
updateForm
();
await
wrapper
.
vm
.
$nextTick
();
expect
(
findEscalationPolicyForm
().
props
(
'
form
'
)).
toMatchObject
({
expect
(
findEscalationPolicyForm
().
props
(
'
form
'
)).
toMatchObject
({
name
:
updatedName
,
name
:
updatedName
,
description
:
updatedDescription
,
description
:
updatedDescription
,
...
@@ -180,6 +181,7 @@ describe('AddEditsEscalationPolicyModal', () => {
...
@@ -180,6 +181,7 @@ describe('AddEditsEscalationPolicyModal', () => {
it
(
'
clears the form on modal cancel
'
,
async
()
=>
{
it
(
'
clears the form on modal cancel
'
,
async
()
=>
{
updateForm
();
updateForm
();
await
wrapper
.
vm
.
$nextTick
();
const
getForm
=
()
=>
findEscalationPolicyForm
().
props
(
'
form
'
);
const
getForm
=
()
=>
findEscalationPolicyForm
().
props
(
'
form
'
);
expect
(
getForm
()).
toMatchObject
({
expect
(
getForm
()).
toMatchObject
({
name
:
updatedName
,
name
:
updatedName
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment