Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
8ae71e79
Commit
8ae71e79
authored
Jan 13, 2022
by
Kushal Pandya
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add snowplow tracking to item title updates
Adds Snowplow tracking to Work Item Title update actions.
parent
a5d2ab99
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
51 additions
and
2 deletions
+51
-2
app/assets/javascripts/work_items/components/item_title.vue
app/assets/javascripts/work_items/components/item_title.vue
+4
-0
app/assets/javascripts/work_items/constants.js
app/assets/javascripts/work_items/constants.js
+2
-0
app/assets/javascripts/work_items/pages/work_item_root.vue
app/assets/javascripts/work_items/pages/work_item_root.vue
+15
-1
spec/frontend/work_items/pages/work_item_root_spec.js
spec/frontend/work_items/pages/work_item_root_spec.js
+30
-1
No files found.
app/assets/javascripts/work_items/components/item_title.vue
View file @
8ae71e79
...
...
@@ -2,7 +2,10 @@
import
{
escape
}
from
'
lodash
'
;
import
{
__
}
from
'
~/locale
'
;
import
{
WI_TITLE_TRACK_LABEL
}
from
'
../constants
'
;
export
default
{
WI_TITLE_TRACK_LABEL
,
props
:
{
initialTitle
:
{
type
:
String
,
...
...
@@ -56,6 +59,7 @@ export default {
role=
"textbox"
:aria-label=
"__('Title')"
:data-placeholder=
"placeholder"
:data-track-label=
"$options.WI_TITLE_TRACK_LABEL"
:contenteditable=
"!disabled"
class=
"gl-pseudo-placeholder"
@
blur=
"handleBlur"
...
...
app/assets/javascripts/work_items/constants.js
View file @
8ae71e79
export
const
widgetTypes
=
{
title
:
'
TITLE
'
,
};
export
const
WI_TITLE_TRACK_LABEL
=
'
item_title
'
;
app/assets/javascripts/work_items/pages/work_item_root.vue
View file @
8ae71e79
<
script
>
import
{
GlAlert
}
from
'
@gitlab/ui
'
;
import
Tracking
from
'
~/tracking
'
;
import
workItemQuery
from
'
../graphql/work_item.query.graphql
'
;
import
updateWorkItemMutation
from
'
../graphql/update_work_item.mutation.graphql
'
;
import
{
widgetTypes
}
from
'
../constants
'
;
import
{
widgetTypes
,
WI_TITLE_TRACK_LABEL
}
from
'
../constants
'
;
import
ItemTitle
from
'
../components/item_title.vue
'
;
const
trackingMixin
=
Tracking
.
mixin
();
export
default
{
titleUpdatedEvent
:
'
updated_title
'
,
components
:
{
ItemTitle
,
GlAlert
,
},
mixins
:
[
trackingMixin
],
props
:
{
id
:
{
type
:
String
,
...
...
@@ -34,6 +39,14 @@ export default {
},
},
computed
:
{
tracking
()
{
return
{
category
:
'
workItems:show
'
,
action
:
'
updated_title
'
,
label
:
WI_TITLE_TRACK_LABEL
,
property
:
'
[type_work_item]
'
,
};
},
titleWidgetData
()
{
return
this
.
workItem
?.
widgets
?.
nodes
?.
find
((
widget
)
=>
widget
.
type
===
widgetTypes
.
title
);
},
...
...
@@ -50,6 +63,7 @@ export default {
},
},
});
this
.
track
();
}
catch
{
this
.
error
=
true
;
}
...
...
spec/frontend/work_items/pages/work_item_root_spec.js
View file @
8ae71e79
...
...
@@ -3,6 +3,7 @@ import { shallowMount } from '@vue/test-utils';
import
VueApollo
from
'
vue-apollo
'
;
import
createMockApollo
from
'
helpers/mock_apollo_helper
'
;
import
waitForPromises
from
'
helpers/wait_for_promises
'
;
import
{
mockTracking
,
unmockTracking
}
from
'
helpers/tracking_helper
'
;
import
workItemQuery
from
'
~/work_items/graphql/work_item.query.graphql
'
;
import
updateWorkItemMutation
from
'
~/work_items/graphql/update_work_item.mutation.graphql
'
;
import
WorkItemsRoot
from
'
~/work_items/pages/work_item_root.vue
'
;
...
...
@@ -15,6 +16,7 @@ Vue.use(VueApollo);
const
WORK_ITEM_ID
=
'
1
'
;
describe
(
'
Work items root component
'
,
()
=>
{
const
mockUpdatedTitle
=
'
Updated title
'
;
let
wrapper
;
let
fakeApollo
;
...
...
@@ -53,7 +55,6 @@ describe('Work items root component', () => {
it
(
'
updates the title when it is edited
'
,
async
()
=>
{
createComponent
();
jest
.
spyOn
(
wrapper
.
vm
.
$apollo
,
'
mutate
'
);
const
mockUpdatedTitle
=
'
Updated title
'
;
await
findTitle
().
vm
.
$emit
(
'
title-changed
'
,
mockUpdatedTitle
);
...
...
@@ -91,4 +92,32 @@ describe('Work items root component', () => {
expect
(
findTitle
().
exists
()).
toBe
(
false
);
});
describe
(
'
tracking
'
,
()
=>
{
let
trackingSpy
;
beforeEach
(()
=>
{
trackingSpy
=
mockTracking
(
'
_category_
'
,
undefined
,
jest
.
spyOn
);
createComponent
();
});
afterEach
(()
=>
{
unmockTracking
();
});
it
(
'
tracks item title updates
'
,
async
()
=>
{
await
findTitle
().
vm
.
$emit
(
'
title-changed
'
,
mockUpdatedTitle
);
await
waitForPromises
();
expect
(
trackingSpy
).
toHaveBeenCalledTimes
(
1
);
expect
(
trackingSpy
).
toHaveBeenCalledWith
(
'
workItems:show
'
,
undefined
,
{
action
:
'
updated_title
'
,
category
:
'
workItems:show
'
,
label
:
'
item_title
'
,
property
:
'
[type_work_item]
'
,
});
});
});
});
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment