Extract abstract success with warnings CI/CD status

lib/gitlab/ci/status/pipeline/factory.rb

@@ -4,7 +4,7 @@ module Gitlab
       module Pipeline
         class Factory < Status::Factory
           def self.extended_statuses
-            [Pipeline::SuccessWithWarnings]
+            [Pipeline::SuccessWarning]
           end
 
           def self.common_helpers

lib/gitlab/ci/status/pipeline/success_with_warnings.rb → lib/gitlab/ci/status/pipeline/success_warning.rb

@@ -2,25 +2,7 @@ module Gitlab
   module Ci
     module Status
       module Pipeline
-        class SuccessWithWarnings < SimpleDelegator
-          include Status::Extended
-
-          def text
-            'passed'
-          end
-
-          def label
-            'passed with warnings'
-          end
-
-          def icon
-            'icon_status_warning'
-          end
-
-          def group
-            'success_with_warnings'
-          end
-
+        class SuccessWarning < Status::SuccessWarning
           def self.matches?(pipeline, user)
             pipeline.success? && pipeline.has_warnings?
           end

lib/gitlab/ci/status/success_warning.rb

+module Gitlab
+  module Ci
+    module Status
+      ##
+      # Abstract extended status used when pipeline/stage/build passed
+      # conditionally.
+      #
+      # This means that failed jobs that are allowed to fail were present.
+      #
+      class SuccessWarning < SimpleDelegator
+        include Status::Extended
+
+        def text
+          'passed'
+        end
+
+        def label
+          'passed with warnings'
+        end
+
+        def icon
+          'icon_status_warning'
+        end
+
+        def group
+          'success_with_warnings'
+        end
+
+        def self.matches?(subject, user)
+          raise NotImplementedError
+        end
+      end
+    end
+  end
+end

spec/lib/gitlab/ci/status/pipeline/factory_spec.rb

@@ -49,7 +49,7 @@ describe Gitlab::Ci::Status::Pipeline::Factory do
 
     it 'fabricates extended "success with warnings" status' do
       expect(status)
-        .to be_a Gitlab::Ci::Status::Pipeline::SuccessWithWarnings
+        .to be_a Gitlab::Ci::Status::Pipeline::SuccessWarning
     end
 
     it 'extends core status with common pipeline methods' do

spec/lib/gitlab/ci/status/pipeline/success_with_warnings_spec.rb → spec/lib/gitlab/ci/status/pipeline/success_warning_spec.rb

 require 'spec_helper'
 
-describe Gitlab::Ci::Status::Pipeline::SuccessWithWarnings do
+describe Gitlab::Ci::Status::Pipeline::SuccessWarning do
   subject do
     described_class.new(double('status'))
   end