Merge remote-tracking branch 'ee/master' into ce-to-ee-2018-01-22

* ee/master: (21 commits)
  Update Geo doc to restart PostgreSQL to changes take effect on secondary
  Move to EE section because it is no longer used in CE
  Update CHANGELOG.md for 10.3.6
  Update CHANGELOG-EE.md for 10.3.6-ee
  Remove left over test data before running tests
  Fix route for Geo 'Repair authentication'
  Add docs for playing a CI pipeline schedule
  Adds logging to remove remote worker
  Update CHANGELOG.md for 10.4.0
  Update CHANGELOG-EE.md for 10.4.0-ee
  Copy k8s service integration info into clusters
  Adds ExclusiveLeaseGuard to RepositoryRemoveRemoteWorker and restores RemoteMirror#refresh_remote to after_save callback
  Moves ExclusiveLeaseGuard from EE to CE
  Moves remove_remote to a background job
  Fix callback alignments
  refactor for projects-r*, s* (EE)
  Update icon to match EE
  Merge branch 'master' into vue-mr-widget-state
  Move mr_widget_auto_merge_failed component into a vue file
  Move EE-specific image to ee/app/assets/images
  ...

CHANGELOG-EE.md

 Please view this file on the master branch, on stable branches it's out of date.
 
+## 10.4.0 (2018-01-22)
+
+### Security (2 changes)
+
+- Fix LDAP external user/group bug on first sign in.
+- Deny persisting milestones from outside project/group scope on boards.
+
+### Fixed (19 changes, 1 of them is from the community)
+
+- Issue count now refreshes quicker on geo secondary. !3639
+- Prevent adding same role multiple times on repeated clicks. !3700
+- Geo - Fix difference in FDW / non-FDW queries for Geo::FileRegistry queries. !3714
+- Fix successful rebase throwing flash error message. !3727
+- Fix Merge Rquest widget rebase action in Internet Explorer. !3732
+- Geo - Use relative path for avatar images on a secondary node. !3857
+- Add missing wiki counts to prometheus metrics. !3875
+- Adjust content width for User Settings, Pipeline quota. !3895 (George Tsiolis)
+- Fix a bug where branch could not be delete due to a push rule config. !3900
+- Fix a few doc links to fast ssh key lookup. !3937
+- Handle node details load failure gracefully on UI. !3992
+- Use the fastest available method for various Geo status counts. !4024
+- Fix neutralCount computation to prevent negative values. !4044
+- Fix reordering of items when moved to top or bottom. !4050
+- Geo - Fix repository clean up when selective replication changes with hashed storage enabled. !4059
+- Fix JavaScript bundle running on Cluster update/destroy pages. !4112
+- Record EE instances without a license correctly in usage ping.
+- Fix export to CSV if a filter with multiple labels is used.
+- Stop authorization attempts with instance profile when static credentials are provided for AWS Elasticsearch.
+
+### Changed (6 changes)
+
+- Change MR widget failed icons to warning icons. !3669
+- Show clear message when set-geo-primary-node was successful. !3768
+- More descriptive error when clocks between Geo nodes are out of sync. !3860
+- Allow sidekiq to react to becoming a Geo primary or secondary without a restart. !3878
+- Geo admin screen enhancements. !3902
+- Geo UI polish.
+
+### Added (13 changes)
+
+- Split project repository and wiki repository status in Geo node status. !3560
+- Add reset pipeline minutes button to admin overview of groups and users. !3656
+- Show results from docker image scan in the merge request widget. !3672
+- Geo: Added Authorized Keys specific checks. !3728
+- Add some extra fields to Geo API node and status. !3858
+- Show results from DAST scan in the merge request widget. !3885
+- Add Geo support for CI job artifacts. !3935
+- Make it possible to enable/disable PostgreSQL FDW for Geo. !4020
+- Add support for reordering issues in epics.
+- Check if shard configuration is same across Geo nodes.
+- Add API for epics.
+- Add group boards API endpoint.
+- Add api for epic_issue associations.
+
+### Other (6 changes)
+
+- Document GitLab Geo with Object Storage. !3760
+- Update disaster recovery documentation with detailed steps. !3845
+- Fix broken alignment of database password in geo docs. !3939
+- Remove unnecessary NTP checks now included in gitlab:geo:check. !3940
+- Move geo status check after db replication to avoid anticipated failures. !3941
+- Make scoped issue board specs more reliable.
+
+
+## 10.3.6 (2018-01-22)
+
+### Fixed (3 changes)
+
+- Geo - Fix repository clean up when selective replication changes with hashed storage enabled. !4059
+- Fix JavaScript bundle running on Cluster update/destroy pages. !4112
+- Fix export to CSV if a filter with multiple labels is used.
+
+
 ## 10.3.5 (2018-01-18)
 
 - No changes.

app/assets/javascripts/dispatcher.js

 /* eslint-disable func-names, space-before-function-paren, no-var, prefer-arrow-callback, wrap-iife, no-shadow, consistent-return, one-var, one-var-declaration-per-line, camelcase, default-case, no-new, quotes, no-duplicate-case, no-case-declarations, no-fallthrough, max-len */
 import Milestone from './milestone';
-import NotificationsForm from './notifications_form';
 import notificationsDropdown from './notifications_dropdown';
 import LineHighlighter from './line_highlighter';
 import MergeRequest from './merge_request';
 import initCompareAutocomplete from './compare_autocomplete';
 import Sidebar from './right_sidebar';
 import Flash from './flash';
-import SecretValues from './behaviors/secret_values';
-import UserCallout from './user_callout';
 import BlobViewer from './blob/viewer/index';
 import GfmAutoComplete from './gfm_auto_complete';
 import Star from './star';
-import TreeView from './tree';
 import ZenMode from './zen_mode';
-import initSettingsPanels from './settings_panels';
 import PerformanceBar from './performance_bar';
 import initNotes from './init_notes';
 import initIssuableSidebar from './init_issuable_sidebar';
-import { ajaxGet, convertPermissionToBoolean } from './lib/utils/common_utils';
+import { convertPermissionToBoolean } from './lib/utils/common_utils';
 import GlFieldErrors from './gl_field_errors';
-import GLForm from './gl_form';
 import Shortcuts from './shortcuts';
-import ShortcutsNavigation from './shortcuts_navigation';
 import ShortcutsIssuable from './shortcuts_issuable';
 import U2FAuthenticate from './u2f/authenticate';
 import Diff from './diff';
 import SearchAutocomplete from './search_autocomplete';
-import Activities from './activities';
 
 // EE-only
 import UsersSelect from './users_select';
+import UserCallout from './user_callout';
 import initGeoInfoModal from 'ee/init_geo_info_modal'; // eslint-disable-line import/first
 import initGroupAnalytics from 'ee/init_group_analytics'; // eslint-disable-line import/first
 import initPathLocks from 'ee/path_locks'; // eslint-disable-line import/first
@@ -154,7 +147,9 @@ import initLDAPGroupsSelect from 'ee/ldap_groups_select'; // eslint-disable-line
             .catch(fail);
           break;
         case 'dashboard:todos:index':
-          import('./pages/dashboard/todos/index').then(callDefault).catch(fail);
+          import('./pages/dashboard/todos/index')
+            .then(callDefault)
+            .catch(fail);
           break;
         case 'admin:jobs:index':
           import('./pages/admin/jobs/index')
@@ -267,15 +262,21 @@ import initLDAPGroupsSelect from 'ee/ldap_groups_select'; // eslint-disable-line
             .catch(fail);
           break;
         case 'projects:snippets:show':
-          initNotes();
-          new ZenMode();
+          import('./pages/projects/snippets/show')
+            .then(callDefault)
+            .catch(fail);
           break;
         case 'projects:snippets:new':
-        case 'projects:snippets:edit':
         case 'projects:snippets:create':
+          import('./pages/projects/snippets/new')
+            .then(callDefault)
+            .catch(fail);
+          break;
+        case 'projects:snippets:edit':
         case 'projects:snippets:update':
-          new GLForm($('.snippet-form'), true);
-          new ZenMode();
+          import('./pages/projects/snippets/edit')
+            .then(callDefault)
+            .catch(fail);
           break;
         case 'snippets:new':
           import('./pages/snippets/new')
@@ -298,8 +299,9 @@ import initLDAPGroupsSelect from 'ee/ldap_groups_select'; // eslint-disable-line
             .catch(fail);
           break;
         case 'projects:releases:edit':
-          new ZenMode();
-          new GLForm($('.release-form'), true);
+          import('./pages/projects/releases/edit')
+            .then(callDefault)
+            .catch(fail);
           break;
         case 'projects:merge_requests:show':
           new Diff();
@@ -343,21 +345,13 @@ import initLDAPGroupsSelect from 'ee/ldap_groups_select'; // eslint-disable-line
           shortcut_handler = true;
           break;
         case 'projects:show':
-          shortcut_handler = new ShortcutsNavigation();
-          new NotificationsForm();
-          new UserCallout({
-            setCalloutPerProject: true,
-            className: 'js-autodevops-banner',
-          });
-
-          if ($('#tree-slider').length) new TreeView();
-          if ($('.blob-viewer').length) new BlobViewer();
-          if ($('.project-show-activity').length) new Activities();
-          $('#tree-slider').waitForImages(function() {
-            ajaxGet(document.querySelector('.js-tree-content').dataset.logsPath);
-          });
-
+          import('./pages/projects/show')
+            .then(callDefault)
+            .catch(fail);
+          shortcut_handler = true;
+          // ee-start
           initGeoInfoModal();
+          // ee-end
           break;
         case 'projects:edit':
           import('./pages/projects/edit')
@@ -525,20 +519,19 @@ import initLDAPGroupsSelect from 'ee/ldap_groups_select'; // eslint-disable-line
           import(/* webpackChunkName: "ee_audit_logs" */ 'ee/pages/admin/audit_logs').then(m => m.default()).catch(fail);
           break;
         case 'projects:settings:repository:show':
+          import('./pages/projects/settings/repository/show')
+            .then(callDefault)
+            .catch(fail);
+          // ee-start
           new UsersSelect();
           new UserCallout();
-          // Initialize expandable settings panels
-          initSettingsPanels();
+          // ee-end
           break;
         case 'projects:settings:ci_cd:show':
-          // Initialize expandable settings panels
-          initSettingsPanels();
-
-          const runnerToken = document.querySelector('.js-secret-runner-token');
-          if (runnerToken) {
-            const runnerTokenSecretValue = new SecretValues(runnerToken);
-            runnerTokenSecretValue.init();
-          }
+          import('./pages/projects/settings/ci_cd/show')
+            .then(callDefault)
+            .catch(fail);
+          break;
         case 'groups:settings:ci_cd:show':
           import('./pages/groups/settings/ci_cd/show')
             .then(callDefault)
@@ -546,13 +539,19 @@ import initLDAPGroupsSelect from 'ee/ldap_groups_select'; // eslint-disable-line
           break;
         case 'ci:lints:create':
         case 'ci:lints:show':
-          import('./pages/ci/lints').then(m => m.default()).catch(fail);
+          import('./pages/ci/lints')
+            .then(callDefault)
+            .catch(fail);
           break;
         case 'users:show':
-          import('./pages/users/show').then(callDefault).catch(fail);
+          import('./pages/users/show')
+            .then(callDefault)
+            .catch(fail);
           break;
         case 'admin:conversational_development_index:show':
-          import('./pages/admin/conversational_development_index/show').then(m => m.default()).catch(fail);
+          import('./pages/admin/conversational_development_index/show')
+            .then(callDefault)
+            .catch(fail);
           break;
         case 'snippets:show':
           import('./pages/snippets/show')
@@ -560,7 +559,9 @@ import initLDAPGroupsSelect from 'ee/ldap_groups_select'; // eslint-disable-line
             .catch(fail);
           break;
         case 'import:fogbugz:new_user_map':
-          import('./pages/import/fogbugz/new_user_map').then(m => m.default()).catch(fail);
+          import('./pages/import/fogbugz/new_user_map')
+            .then(callDefault)
+            .catch(fail);
           break;
         case 'profiles:personal_access_tokens:index':
           import('./pages/profiles/personal_access_tokens')

app/assets/javascripts/pages/projects/init_form.js

+import ZenMode from '~/zen_mode';
+import GLForm from '~/gl_form';
+
+export default function ($formEl) {
+  new ZenMode(); // eslint-disable-line no-new
+  new GLForm($formEl, true); // eslint-disable-line no-new
+}

app/assets/javascripts/pages/projects/releases/edit/index.js

+import initForm from '~/pages/projects/init_form';
+
+export default initForm($('.release-form'));

app/assets/javascripts/pages/projects/settings/ci_cd/show/index.js

+import initSettingsPanels from '~/settings_panels';
+import SecretValues from '~/behaviors/secret_values';
+
+export default function () {
+  // Initialize expandable settings panels
+  initSettingsPanels();
+  const runnerToken = document.querySelector('.js-secret-runner-token');
+  if (runnerToken) {
+    const runnerTokenSecretValue = new SecretValues(runnerToken);
+    runnerTokenSecretValue.init();
+  }
+
+  const secretVariableTable = document.querySelector('.js-secret-variable-table');
+  if (secretVariableTable) {
+    const secretVariableTableValues = new SecretValues(secretVariableTable);
+    secretVariableTableValues.init();
+  }
+}

app/assets/javascripts/pages/projects/settings/repository/show/index.js

+import initSettingsPanels from '~/settings_panels';
+
+export default initSettingsPanels;

app/assets/javascripts/pages/projects/show/index.js

+import ShortcutsNavigation from '~/shortcuts_navigation';
+import NotificationsForm from '~/notifications_form';
+import UserCallout from '~/user_callout';
+import TreeView from '~/tree';
+import BlobViewer from '~/blob/viewer/index';
+import Activities from '~/activities';
+import { ajaxGet } from '~/lib/utils/common_utils';
+
+export default () => {
+  new ShortcutsNavigation(); // eslint-disable-line no-new
+  new NotificationsForm(); // eslint-disable-line no-new
+  new UserCallout({ // eslint-disable-line no-new
+    setCalloutPerProject: true,
+    className: 'js-autodevops-banner',
+  });
+
+  if ($('#tree-slider').length) new TreeView(); // eslint-disable-line no-new
+  if ($('.blob-viewer').length) new BlobViewer(); // eslint-disable-line no-new
+  if ($('.project-show-activity').length) new Activities(); // eslint-disable-line no-new
+  $('#tree-slider').waitForImages(() => {
+    ajaxGet(document.querySelector('.js-tree-content').dataset.logsPath);
+  });
+};

app/assets/javascripts/pages/projects/snippets/edit/index.js

+import initForm from '~/pages/projects/init_form';
+
+export default initForm($('.snippet-form'));

app/assets/javascripts/pages/projects/snippets/new/index.js

+import initForm from '~/pages/projects/init_form';
+
+export default initForm($('.snippet-form'));

app/assets/javascripts/pages/projects/snippets/show/index.js

+import initNotes from '~/init_notes';
+import ZenMode from '~/zen_mode';
+
+export default function () {
+  initNotes();
+  new ZenMode(); // eslint-disable-line no-new
+}

app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_auto_merge_failed.js

-import eventHub from '../../event_hub';
-import statusIcon from '../mr_widget_status_icon';
-
-export default {
-  name: 'MRWidgetAutoMergeFailed',
-  props: {
-    mr: { type: Object, required: true },
-  },
-  data() {
-    return {
-      isRefreshing: false,
-    };
-  },
-  components: {
-    statusIcon,
-  },
-  methods: {
-    refreshWidget() {
-      this.isRefreshing = true;
-      eventHub.$emit('MRWidgetUpdateRequested', () => {
-        this.isRefreshing = false;
-      });
-    },
-  },
-  template: `
-    <div class="mr-widget-body media">
-      <status-icon status="warning" />
-      <div class="media-body space-children">
-        <span class="bold">
-          <template v-if="mr.mergeError">{{mr.mergeError}}.</template>
-          This merge request failed to be merged automatically
-        </span>
-        <button
-          @click="refreshWidget"
-          :disabled="isRefreshing"
-          type="button"
-          class="btn btn-xs btn-default">
-          <i
-            v-if="isRefreshing"
-            class="fa fa-spinner fa-spin"
-            aria-hidden="true" />
-          Refresh
-        </button>
-      </div>
-    </div>
-  `,
-};

app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_auto_merge_failed.vue

+<script>
+  import loadingIcon from '~/vue_shared/components/loading_icon.vue';
+  import eventHub from '../../event_hub';
+  import statusIcon from '../mr_widget_status_icon';
+
+  export default {
+    name: 'MRWidgetAutoMergeFailed',
+    components: {
+      statusIcon,
+      loadingIcon,
+    },
+    props: {
+      mr: {
+        type: Object,
+        required: true,
+      },
+    },
+    data() {
+      return {
+        isRefreshing: false,
+      };
+    },
+    methods: {
+      refreshWidget() {
+        this.isRefreshing = true;
+        eventHub.$emit('MRWidgetUpdateRequested', () => {
+          this.isRefreshing = false;
+        });
+      },
+    },
+  };
+</script>
+<template>
+  <div class="mr-widget-body media">
+    <status-icon status="warning" />
+    <div class="media-body space-children">
+      <span class="bold">
+        <template v-if="mr.mergeError">{{ mr.mergeError }}.</template>
+        {{ s__("mrWidget|This merge request failed to be merged automatically") }}
+      </span>
+      <button
+        @click="refreshWidget"
+        :disabled="isRefreshing"
+        type="button"
+        class="btn btn-xs btn-default"
+      >
+        <loading-icon v-if="isRefreshing" />
+        {{ s__("mrWidget|Refresh") }}
+      </button>
+    </div>
+  </div>
+</template>

app/assets/javascripts/vue_merge_request_widget/dependencies.js

@@ -33,7 +33,7 @@ export { default as PipelineBlockedState } from './components/states/mr_widget_p
 export { default as PipelineFailedState } from './components/states/mr_widget_pipeline_failed';
 export { default as MergeWhenPipelineSucceedsState } from './components/states/mr_widget_merge_when_pipeline_succeeds';
 export { default as RebaseState } from './components/states/mr_widget_rebase.vue';
-export { default as AutoMergeFailed } from './components/states/mr_widget_auto_merge_failed';
+export { default as AutoMergeFailed } from './components/states/mr_widget_auto_merge_failed.vue';
 export { default as CheckingState } from './components/states/mr_widget_checking';
 export { default as MRWidgetStore } from 'ee/vue_merge_request_widget/stores/mr_widget_store';
 export { default as MRWidgetService } from 'ee/vue_merge_request_widget/services/mr_widget_service';

app/models/repository.rb

@@ -1005,13 +1005,27 @@ class Repository
     add_remote(remote_name, url, mirror_refmap: refmap)
     fetch_remote(remote_name, forced: forced)
   ensure
-    remove_remote(remote_name) if tmp_remote_name
+    async_remove_remote(remote_name) if tmp_remote_name
   end
 
   def fetch_remote(remote, forced: false, ssh_auth: nil, no_tags: false)
     gitlab_shell.fetch_remote(raw_repository, remote, ssh_auth: ssh_auth, forced: forced, no_tags: no_tags)
   end
 
+  def async_remove_remote(remote_name)
+    return unless remote_name
+
+    job_id = RepositoryRemoveRemoteWorker.perform_async(project.id, remote_name)
+
+    if job_id
+      Rails.logger.info("Remove remote job scheduled for #{project.id} with remote name: #{remote_name} job ID #{job_id}.")
+    else
+      Rails.logger.info("Remove remote job failed to create for #{project.id} with remote name #{remote_name}.")
+    end
+
+    job_id
+  end
+
   def fetch_source_branch!(source_repository, source_branch, local_ref)
     raw_repository.fetch_source_branch!(source_repository.raw_repository, source_branch, local_ref)
   end

app/workers/all_queues.yml

@@ -93,6 +93,7 @@
 - rebase
 - repository_fork
 - repository_import
+- repository_remove_remote
 - storage_migrator
 - system_hook_push
 - update_merge_requests

app/workers/repository_remove_remote_worker.rb

+class RepositoryRemoveRemoteWorker
+  include ApplicationWorker
+  include ExclusiveLeaseGuard
+
+  LEASE_TIMEOUT = 1.hour
+
+  attr_reader :project, :remote_name
+
+  def perform(project_id, remote_name)
+    @remote_name = remote_name
+    @project = Project.find_by_id(project_id)
+
+    return unless @project
+
+    logger.info("Removing remote #{remote_name} from project #{project.id}")
+
+    try_obtain_lease do
+      remove_remote = @project.repository.remove_remote(remote_name)
+
+      if remove_remote
+        logger.info("Remote #{remote_name} was successfully removed from project #{project.id}")
+      else
+        logger.error("Could not remove remote #{remote_name} from project #{project.id}")
+      end
+    end
+  end
+
+  def lease_timeout
+    LEASE_TIMEOUT
+  end
+
+  def lease_key
+    "remove_remote_#{project.id}_#{remote_name}"
+  end
+end

changelogs/unreleased-ee/3501-fix-rebase-in-ie.yml

----
-title: Fix Merge Rquest widget rebase action in Internet Explorer
-merge_request: 3732
-author:
-type: fixed

changelogs/unreleased-ee/3841-fix-export-to-csv.yml

----
-title: Fix export to CSV if a filter with multiple labels is used
-merge_request:
-author:
-type: fixed

changelogs/unreleased-ee/3973-reset-pipeline-minutes-pipeline-quota-in-the-admin-ui.yml

----
-title: Add reset pipeline minutes button to admin overview of groups and users
-merge_request: 3656
-author:
-type: added

changelogs/unreleased-ee/39734-fix-protected-refs-roles.yml

----
-title: Prevent adding same role multiple times on repeated clicks
-merge_request: 3700
-author:
-type: fixed

changelogs/unreleased-ee/4048-sidekiq-cron-geo-2.yml

----
-title: Allow sidekiq to react to becoming a Geo primary or secondary without a restart
-merge_request: 3878
-author:
-type: changed

changelogs/unreleased-ee/4070-geo-caching-issue-count.yml

----
-title: Issue count now refreshes quicker on geo secondary
-merge_request: 3639
-author:
-type: fixed

changelogs/unreleased-ee/4078-fix-deleting-existing-branches-with-push-rule-config.yml

----
-title: Fix a bug where branch could not be delete due to a push rule config
-merge_request: 3900
-author:
-type: fixed

changelogs/unreleased-ee/4090-authorized-keys-check.yml

----
-title: 'Geo: Added Authorized Keys specific checks'
-merge_request: 3728
-author:
-type: added

changelogs/unreleased-ee/tc-geo-ux-polish.yml → changelogs/unreleased-ee/4099-remote-removal-port-to-background-job.yml

 ---
-title: Geo UI polish
+title: Ports remote removal to a background job
 merge_request:
 author:
 type: changed

changelogs/unreleased-ee/4133-icons-for-approvals-remaining-and-approvals-met.yml

----
-title: Change MR widget failed icons to warning icons
-merge_request: 3669
-author:
-type: changed

changelogs/unreleased-ee/4225-epic-api.yml

----
-title: Add API for epics
-merge_request:
-author:
-type: added

changelogs/unreleased-ee/4249-show-results-from-docker-image-scan-in-the-merge-request-widget.yml

----
-title: Show results from docker image scan in the merge request widget
-merge_request: 3672
-author:
-type: added

changelogs/unreleased-ee/4250-api-epic-issues.yml

----
-title: Add api for epic_issue associations
-merge_request:
-author:
-type: added

changelogs/unreleased-ee/4268-geo-admin-page.yml

----
-title: Geo admin screen enhancements
-merge_request: 3902
-author:
-type: changed

changelogs/unreleased-ee/4304-fix-successful-rebase.yml

----
-title: Fix successful rebase throwing flash error message
-merge_request: 3727
-author:
-type: fixed

changelogs/unreleased-ee/4348-show-dast-results-in-the-mr-widget.yml

----
-title: Show results from DAST scan in the merge request widget
-merge_request: 3885
-author:
-type: added

changelogs/unreleased-ee/4378-fix-cluster-js-not-running-on-update-page.yml

----
-title: Fix JavaScript bundle running on Cluster update/destroy pages
-merge_request: 4112
-author:
-type: fixed

changelogs/unreleased-ee/4414-add-wiki-total-synced-failed-to-prometheus-metrics.yml

----
-title: Add missing wiki counts to prometheus metrics
-merge_request: 3875
-author:
-type: fixed

changelogs/unreleased-ee/4491-geo-fdw-optimise-queries.yml

----
-title: Use the fastest available method for various Geo status counts
-merge_request: 4024
-author:
-type: fixed

changelogs/unreleased-ee/4511-handle-node-error-gracefully.yml

----
-title: Handle node details load failure gracefully on UI
-merge_request: 3992
-author:
-type: fixed

changelogs/unreleased-ee/4582-fix-incorrect-neutral-count.yml

----
-title: Fix neutralCount computation to prevent negative values
-merge_request: 4044
-author:
-type: fixed

changelogs/unreleased-ee/4587-fix-epic-issues-reordering.yml

----
-title: Fix reordering of items when moved to top or bottom
-merge_request: 4050
-author:
-type: fixed

changelogs/unreleased-ee/4596-fix-geo-repositoriescleanupworker-to-work-with-hashed-storage.yml

----
-title: Geo - Fix repository clean up when selective replication changes with hashed storage enabled
-merge_request: 4059
-author:
-type: fixed

changelogs/unreleased-ee/aws-es-connect-when-needed.yml

----
-title: Stop authorization attempts with instance profile when static credentials are
-  provided for AWS Elasticsearch
-merge_request:
-author:
-type: fixed

changelogs/unreleased-ee/da-fix-geo-file-registry-queries.yml

----
-title: Geo - Fix difference in FDW / non-FDW queries for Geo::FileRegistry queries
-merge_request: 3714
-author:
-type: fixed

changelogs/unreleased-ee/da-geo-fix-user-avatar-being-user-from-primary-node.yml

----
-title: Geo - Use relative path for avatar images on a secondary node
-merge_request: 3857
-author:
-type: fixed

changelogs/unreleased-ee/ee-issue_3413.yml

----
-title: Add group boards API endpoint
-merge_request:
-author:
-type: added

changelogs/unreleased-ee/feature-geo-split-fail-repos.yml

----
-title: Split project repository and wiki repository status in Geo node status
-merge_request: 3560
-author:
-type: added

changelogs/unreleased-ee/fix_ldap_external_on_login.yml

----
-title: Fix LDAP external user/group bug on first sign in
-merge_request:
-author:
-type: security

changelogs/unreleased-ee/jramsay-4399-clarify-dr-docs.yml

----
-title: Update disaster recovery documentation with detailed steps
-merge_request: 3845
-author:
-type: other

changelogs/unreleased-ee/jramsay-4481-move-gitlab-geo-check-after-database-replication.yml

----
-title: Move geo status check after db replication to avoid anticipated failures
-merge_request: 3941
-author:
-type: other

changelogs/unreleased-ee/jramsay-fix-alignment-geo-docs.yml

----
-title: Fix broken alignment of database password in geo docs
-merge_request: 3939
-author:
-type: other

changelogs/unreleased-ee/jramsay4480-remove-ntp-check-from-geo-docs.yml

----
-title: Remove unnecessary NTP checks now included in gitlab:geo:check
-merge_request: 3940
-author:
-type: other

changelogs/unreleased-ee/mk-add-geo-support-for-artifacts.yml

----
-title: Add Geo support for CI job artifacts
-merge_request: 3935
-author:
-type: added

changelogs/unreleased-ee/mk-fix-fast-ssh-key-lookup-links.yml

----
-title: Fix a few doc links to fast ssh key lookup
-merge_request: 3937
-author:
-type: fixed

changelogs/unreleased-ee/osw-10-3-security-milestone-data-exposure.yml

----
-title: Deny persisting milestones from outside project/group scope on boards
-merge_request:
-author:
-type: security

changelogs/unreleased-ee/osw-more-reliable-scoped-issue-board-specs.yml

----
-title: Make scoped issue board specs more reliable
-merge_request:
-author:
-type: other

changelogs/unreleased-ee/patch-5.yml

----
-title: Adjust content width for User Settings, Pipeline quota
-merge_request: 3895
-author: George Tsiolis
-type: fixed

changelogs/unreleased-ee/reorder-issues-epic.yml

----
-title: Add support for reordering issues in epics
-merge_request:
-author:
-type: added

changelogs/unreleased-ee/sh-api-shard-config.yml

----
-title: Check if shard configuration is same across Geo nodes
-merge_request:
-author:
-type: added

changelogs/unreleased-ee/show-correct-edition-for-ee-free.yml

----
-title: Record EE instances without a license correctly in usage ping
-merge_request:
-author:
-type: fixed

changelogs/unreleased-ee/tc-geo-backend-vue-admin.yml

----
-title: Add some extra fields to Geo API node and status
-merge_request: 3858
-author:
-type: added

changelogs/unreleased-ee/tc-geo-fdw-configurable.yml

----
-title: Make it possible to enable/disable PostgreSQL FDW for Geo
-merge_request: 4020
-author:
-type: added

changelogs/unreleased-ee/tc-geo-ntp-time-error.yml

----
-title: More descriptive error when clocks between Geo nodes are out of sync
-merge_request: 3860
-author:
-type: changed

changelogs/unreleased-ee/tc-geo-object-storage-docs.yml

----
-title: Document GitLab Geo with Object Storage
-merge_request: 3760
-author:
-type: other

changelogs/unreleased-ee/tc-geo-set_primary_node-success.yml

----
-title: Show clear message when set-geo-primary-node was successful
-merge_request: 3768
-author:
-type: changed

changelogs/unreleased/13695-order-contributors-in-api.yml

----
-title: Adds ordering to projects contributors in API
-merge_request: 15469
-author: Jacopo Beschi @jacopo-beschi
-type: added

changelogs/unreleased/15832-fix-access-level-update-for-requesters.yml

----
-title: Fix error that was preventing users to change the access level of access requests for Groups or Projects
-merge_request: 15832
-author:
-type: fixed

changelogs/unreleased/15922-validate-file-status-when-commiting-multiple-files.yml

----
-title: 'Validate file status when commiting multiple files'
-merge_request: 15922
-author:
-type: added

changelogs/unreleased/15955-improve-search-query.yml

----
-title: Improve search query for merge requests.
-merge_request:
-author:
-type: performance

changelogs/unreleased/16036-ignore-lost-found-folder-during-backup-on-a-volume.yml

----
-title: "Ignore lost+found folder during backup on a volume"
-merge_request: 16036
-author: Julien Millau
-type: fixed
\ No newline at end of file

changelogs/unreleased/16117-improve-search-for-issues.yml

----
-title: Improve search query for issues.
-merge_request:
-author:
-type: performance

changelogs/unreleased/20035-pause-resume-runners.yml

----
-title: Add pause/resume button to project runners
-merge_request: 16032
-author: Mario de la Ossa
-type: added

changelogs/unreleased/24347-dont-post-system-note-when-branch-creation-fails.yml

----
-title: Fix when branch creation fails don't post system note
-merge_request:
-author: Mateusz Bajorski
-type: fixed

changelogs/unreleased/25317-prioritize-author-date-over-commit.yml

----
-title: Show authored date rather than committed date on the commit list
-merge_request:
-author:
-type: fixed

changelogs/unreleased/28004-consider-refactoring-member-view-by-using-presenter.yml

----
-title: Refactor member view using a Presenter
-merge_request: 9645
-author: TM Lee

changelogs/unreleased/31995-project-limit-default-fix.yml

----
-title: User#projects_limit remove DB default and added NOT NULL constraint
-merge_request: 16165
-author: Mario de la Ossa
-type: fixed

changelogs/unreleased/32364-updating-slack-notification-not-working-by-api.yml

----
-title: Support new chat notifications parameters in Services API
-merge_request: 11435
-author:
-type: added

changelogs/unreleased/33028-event-tag-links.yml

----
-title: Fix tags in the Activity tab not being clickable
-merge_request: 15996
-author: Mario de la Ossa
-type: fixed

changelogs/unreleased/33609-hide-pagination.yml

----
-title: Disable Vue pagination when only one page of content is available
-merge_request: 15999
-author: Mario de la Ossa
-type: fixed

changelogs/unreleased/33926-update-issuable-icons.yml

----
-title: Update issuable status icons
-merge_request: 15898
-author:
-type: changed

changelogs/unreleased/34534-switch-to-axios.yml

----
-title: Fix some POST/DELETE requests in IE by switching some bundles to Axios for Ajax requests
-merge_request: 15951
-author:
-type: fixed

changelogs/unreleased/36020-private-npm-modules.yml

----
-title: Do not generate NPM links for private NPM modules in blob view
-merge_request: 16002
-author: Mario de la Ossa
-type: added

changelogs/unreleased/36669-default-mr-title-with-external-issues.yml

----
-title: Default merge request title is set correctly again when external issue tracker is activated
-merge_request: 16356
-author: Ben305
-type: fixed

changelogs/unreleased/36782-replace-team-user-role-with-add_role-user-in-specs.yml

----
-title: Replace '.team << [user, role]' with 'add_role(user)' in specs
-merge_request: 16069
-author: "@blackst0ne"
-type: other

changelogs/unreleased/36958-enable-ordering-projects-subgroups-by-name.yml

----
-title: Enable ordering of groups and their children by name
-merge_request:
-author:
-type: added

changelogs/unreleased/37843-ci-trace-ansi-colours-256-bold-have-no-css-due-wrongly-ansi2html-light-color-variant-conversion-feature.yml

----
-title: Fix ANSI 256 bold colors in pipelines job output
-merge_request:
-author:
-type: fixed

changelogs/unreleased/38019-hide-runner-token.yml

----
-title: Hide runner token in CI/CD settings page
-merge_request:
-author:
-type: added

changelogs/unreleased/38030-add-graph-value-to-hover.yml

----
-title: Display graph values on hover within monitoring page
-merge_request: 16261
-author:
-type: changed

changelogs/unreleased/38145_ux_issues_in_system_info_page.yml

----
-title: Fixes the wording of headers in system info page
-merge_request: 15802
-author: Gilbert Roulot
-type: fixed

changelogs/unreleased/38239-update-toggle-design.yml

----
-title: Update feature toggle design to use icons and make it i18n friendly
-merge_request: 15904
-author:
-type: changed

changelogs/unreleased/38318-search-merge-requests-with-api.yml

----
-title: Add optional search param for Merge Requests API
-merge_request:
-author:
-type: fixed

changelogs/unreleased/38541-cancel-alignment.yml

----
-title: fix button alignment on MWPS component
-merge_request:
-author:
-type: fixed

changelogs/unreleased/38596-fix-backspace-visual-token-clearing.yml

----
-title: Clears visual token on second backspace
-merge_request:
-author: Martin Wortschack
-type: fixed

changelogs/unreleased/38893-banzai-upload-filter-relative-urls.yml

----
-title: Use relative URLs when linking to uploaded files
-merge_request: 15751
-author:
-type: other

changelogs/unreleased/39246-fork-and-import-jobs-should-only-be-marked-as-failed-when-the-number-of-retries-was-exhausted.yml

----
-title: Only mark import and fork jobs as failed once all Sidekiq retries get exhausted
-merge_request: 15844
-author:
-type: changed

changelogs/unreleased/39298-list-of-avatars-2.yml

----
-title: List of avatars should never show +1
-merge_request: 15972
-author: Jacopo Beschi @jacopo-beschi
-type: added

changelogs/unreleased/39608-comment-on-image-discussions-tab-alignment.yml

----
-title: Update comment on image cursor and icons
-merge_request: 15760
-author:
-type: fixed

changelogs/unreleased/3968-protected-branch-is-not-set-for-default-branch-on-import.yml

----
-title: Protected branch is now created for default branch on import
-merge_request: 16198
-author:
-type: fixed

changelogs/unreleased/39957-redirect-to-gpc-page-if-users-try-to-create-a-cluster-but-the-account-is-not-enabled.yml

----
-title: Implement checking GCP project billing status in cluster creation form.
-merge_request: 15665
-author:
-type: changed

changelogs/unreleased/40031-include-assset_sync-gem.yml

----
-title: Add assets_sync gem to Gemfile
-merge_request: 15734
-author:
-type: added

changelogs/unreleased/40040-decouple-multi-file-editor-from-file-list.yml

----
-title: Adds the multi file editor as a new beta feature
-merge_request: 15430
-author: 
-type: feature