Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
8b9a1932
Commit
8b9a1932
authored
Jul 28, 2021
by
David Pisek
Committed by
Olena Horal-Koretska
Jul 28, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Pipeline Vulnerabilities: Fix layout issue for GraphQL list
parent
ef7cb02f
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
86 additions
and
85 deletions
+86
-85
ee/app/assets/stylesheets/components/vulnerability_list.scss
ee/app/assets/stylesheets/components/vulnerability_list.scss
+84
-0
ee/app/assets/stylesheets/page_bundles/pipeline.scss
ee/app/assets/stylesheets/page_bundles/pipeline.scss
+1
-0
ee/app/assets/stylesheets/page_bundles/security_dashboard.scss
...p/assets/stylesheets/page_bundles/security_dashboard.scss
+1
-85
No files found.
ee/app/assets/stylesheets/components/vulnerability_list.scss
0 → 100644
View file @
8b9a1932
$security-filter-height
:
90px
;
$selection-summary-height
:
66px
;
$selection-summary-with-error-height
:
118px
;
@mixin
sticky-top-positioning
(
$extra
:
0
)
{
top
:
$header-height
+
$extra
;
.with-performance-bar
&
{
top
:
$header-height
+
$performance-bar-height
+
$extra
;
}
}
.security-dashboard-filters
{
@include
sticky-top-positioning
();
}
.vulnerability-list
{
@media
(
min-width
:
$breakpoint-sm
)
{
.checkbox
{
@include
gl-pl-4
;
@include
gl-pr-0
;
width
:
1px
;
+
td
,
+
th
{
@include
gl-pl-4
;
}
}
.detected
{
width
:
9%
;
}
.status
{
width
:
8%
;
}
.severity
{
@include
gl-w-10p
;
}
.description
{
max-width
:
0
;
}
.identifier
{
width
:
16%
;
}
.scanner
{
@include
gl-w-10p
;
}
.activity
{
width
:
5%
;
}
}
// Due to position: sticky not being supported on Chrome (https://caniuse.com/#feat=css-sticky),
// the property is assigned to the th element as a workaround
.selection-summary
,
thead
th
{
@include
gl-sticky
;
// Some input elements have a z-index of "1" so we need to place this higher
@include
gl-z-index-2
;
@include
sticky-top-positioning
(
$security-filter-height
);
}
thead
th
{
box-shadow
:
0
1px
$gray-100
;
}
thead
.below-selection-summary
th
{
@include
sticky-top-positioning
(
$security-filter-height
+
$selection-summary-height
);
}
tr
:hover
.vulnerability-title
{
@include
gl-text-decoration-underline
;
}
.card.with-error
+
table
thead
.below-selection-summary
th
{
@include
sticky-top-positioning
(
$security-filter-height
+
$selection-summary-with-error-height
);
}
}
ee/app/assets/stylesheets/page_bundles/pipeline.scss
View file @
8b9a1932
@import
'../../../../../app/assets/stylesheets/page_bundles/pipeline'
;
@import
'../components/vulnerability_list'
;
@import
'../components/generic_vulnerability_report'
;
/**
...
...
ee/app/assets/stylesheets/page_bundles/security_dashboard.scss
View file @
8b9a1932
@import
'page_bundles/mixins_and_variables_and_functions'
;
@import
'../components/vulnerability_list'
;
@import
'../components/generic_vulnerability_report'
;
$security-filter-height
:
90px
;
$selection-summary-height
:
66px
;
$selection-summary-with-error-height
:
118px
;
@mixin
sticky-top-positioning
(
$extra
:
0
)
{
top
:
$header-height
+
$extra
;
.with-performance-bar
&
{
top
:
$header-height
+
$performance-bar-height
+
$extra
;
}
}
.vulnerabilities-row
{
&
.dismissed
.table-mobile-content
:not
(
.action-buttons
)
{
opacity
:
0
.5
;
...
...
@@ -38,10 +27,6 @@ $selection-summary-with-error-height: 118px;
}
}
.security-dashboard-filters
{
@include
sticky-top-positioning
();
}
.security-dashboard-accordion
>
ul
{
@include
gl-display-flex
;
@include
gl-flex-grow-1
;
...
...
@@ -51,72 +36,3 @@ $selection-summary-with-error-height: 118px;
flex
:
1
1
40%
;
margin
:
1rem
;
}
.vulnerability-list
{
@media
(
min-width
:
$breakpoint-sm
)
{
.checkbox
{
padding-left
:
$gl-spacing-scale-4
;
padding-right
:
0
;
width
:
1px
;
+
td
,
+
th
{
padding-left
:
$gl-spacing-scale-4
;
}
}
.detected
{
width
:
9%
;
}
.status
{
width
:
8%
;
}
.severity
{
width
:
10%
;
}
.description
{
max-width
:
0
;
}
.identifier
{
width
:
16%
;
}
.scanner
{
width
:
10%
;
}
.activity
{
width
:
5%
;
}
}
// Due to position: sticky not being supported on Chrome (https://caniuse.com/#feat=css-sticky),
// the property is assigned to the th element as a workaround
.selection-summary
,
thead
th
{
position
:
-
webkit-sticky
;
position
:
sticky
;
z-index
:
1
;
@include
sticky-top-positioning
(
$security-filter-height
);
}
thead
th
{
box-shadow
:
0
1px
$gray-100
;
}
thead
.below-selection-summary
th
{
@include
sticky-top-positioning
(
$security-filter-height
+
$selection-summary-height
);
}
tr
:hover
.vulnerability-title
{
text-decoration
:
underline
;
}
.card.with-error
+
table
thead
.below-selection-summary
th
{
@include
sticky-top-positioning
(
$security-filter-height
+
$selection-summary-with-error-height
);
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment