Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
8fdfd521
Commit
8fdfd521
authored
Apr 03, 2019
by
Alexandru Croitor
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Extract due quick action to shared example
parent
6844ba2d
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
26 additions
and
43 deletions
+26
-43
spec/features/issues/user_uses_quick_actions_spec.rb
spec/features/issues/user_uses_quick_actions_spec.rb
+1
-28
spec/support/shared_examples/quick_actions/issue/due_quick_action_shared_examples.rb
...s/quick_actions/issue/due_quick_action_shared_examples.rb
+25
-15
No files found.
spec/features/issues/user_uses_quick_actions_spec.rb
View file @
8fdfd521
...
@@ -60,34 +60,7 @@ describe 'Issues > User uses quick actions', :js do
...
@@ -60,34 +60,7 @@ describe 'Issues > User uses quick actions', :js do
it_behaves_like
'remove_due_date quick action'
it_behaves_like
'remove_due_date quick action'
it_behaves_like
'duplicate quick action'
it_behaves_like
'duplicate quick action'
it_behaves_like
'create_merge_request quick action'
it_behaves_like
'create_merge_request quick action'
it_behaves_like
'due quick action'
describe
'adding a due date from note'
do
let
(
:issue
)
{
create
(
:issue
,
project:
project
)
}
it_behaves_like
'due quick action available and date can be added'
context
'when the current user cannot update the due date'
do
let
(
:guest
)
{
create
(
:user
)
}
before
do
project
.
add_guest
(
guest
)
gitlab_sign_out
sign_in
(
guest
)
visit
project_issue_path
(
project
,
issue
)
end
it_behaves_like
'due quick action not available'
end
end
describe
'toggling the WIP prefix from the title from note'
do
let
(
:issue
)
{
create
(
:issue
,
project:
project
)
}
it
'does not recognize the command nor create a note'
do
add_note
(
"/wip"
)
expect
(
page
).
not_to
have_content
'/wip'
end
end
describe
'move the issue to another project'
do
describe
'move the issue to another project'
do
let
(
:issue
)
{
create
(
:issue
,
project:
project
)
}
let
(
:issue
)
{
create
(
:issue
,
project:
project
)
}
...
...
spec/support/shared_examples/quick_actions/issue/due_quick_action_shared_examples.rb
View file @
8fdfd521
# frozen_string_literal: true
# frozen_string_literal: true
shared_examples
'due quick action not available'
do
shared_examples
'due quick action'
do
it
'does not set the due date'
do
context
'due quick action available and date can be added'
do
add_note
(
'/due 2016-08-28'
)
expect
(
page
).
not_to
have_content
'Commands applied'
expect
(
page
).
not_to
have_content
'/due 2016-08-28'
end
end
shared_examples
'due quick action available and date can be added'
do
it
'sets the due date accordingly'
do
it
'sets the due date accordingly'
do
add_note
(
'/due 2016-08-28'
)
add_note
(
'/due 2016-08-28'
)
...
@@ -22,4 +14,22 @@ shared_examples 'due quick action available and date can be added' do
...
@@ -22,4 +14,22 @@ shared_examples 'due quick action available and date can be added' do
expect
(
page
).
to
have_content
'Aug 28, 2016'
expect
(
page
).
to
have_content
'Aug 28, 2016'
end
end
end
end
end
context
'due quick action not available'
do
let
(
:guest
)
{
create
(
:user
)
}
before
do
project
.
add_guest
(
guest
)
gitlab_sign_out
sign_in
(
guest
)
visit
project_issue_path
(
project
,
issue
)
end
it
'does not set the due date'
do
add_note
(
'/due 2016-08-28'
)
expect
(
page
).
not_to
have_content
'Commands applied'
expect
(
page
).
not_to
have_content
'/due 2016-08-28'
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment