Fixed CiServices validation

90720982 · Gabriel Mazetto · f479ed30 · 90720982 · 90720982
Commit 90720982 authored Dec 15, 2015 by Gabriel Mazetto
Showing with 4 additions and 4 deletions

app/models/project_services/bamboo_service.rb app/models/project_services/bamboo_service.rb +2 -2

app/models/project_services/teamcity_service.rb app/models/project_services/teamcity_service.rb +2 -2

No files found.
--- a/app/models/project_services/bamboo_service.rb
+++ b/app/models/project_services/bamboo_service.rb
@@ -27,10 +27,10 @@ class BambooService < CiService
  validates :build_key, presence: true, if: :activated?
  validates :username,
    presence: true,
-    if: ->(service) { service.activated? && service.password? }
+    if: ->(service) { service.activated? && service.password }
  validates :password,
    presence: true,
-    if: ->(service) { service.activated? && service.username? }
+    if: ->(service) { service.activated? && service.username }

  attr_accessor :response


--- a/app/models/project_services/teamcity_service.rb
+++ b/app/models/project_services/teamcity_service.rb
@@ -27,10 +27,10 @@ class TeamcityService < CiService
  validates :build_type, presence: true, if: :activated?
  validates :username,
    presence: true,
-    if: ->(service) { service.activated? && service.password? }
+    if: ->(service) { service.activated? && service.password }
  validates :password,
    presence: true,
-    if: ->(service) { service.activated? && service.username? }
+    if: ->(service) { service.activated? && service.username }

  attr_accessor :response