Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
92a2674a
Commit
92a2674a
authored
Jan 14, 2021
by
Gary Holtz
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add a /request_review alias for /assign_reviewer
parent
3ecd6f80
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
12 additions
and
1 deletion
+12
-1
changelogs/unreleased/25381-add-request-review-alias.yml
changelogs/unreleased/25381-add-request-review-alias.yml
+5
-0
lib/gitlab/quick_actions/merge_request_actions.rb
lib/gitlab/quick_actions/merge_request_actions.rb
+1
-1
spec/services/quick_actions/interpret_service_spec.rb
spec/services/quick_actions/interpret_service_spec.rb
+6
-0
No files found.
changelogs/unreleased/25381-add-request-review-alias.yml
0 → 100644
View file @
92a2674a
---
title
:
Add a /request_review alias for /assign_reviewer
merge_request
:
51751
author
:
type
:
added
lib/gitlab/quick_actions/merge_request_actions.rb
View file @
92a2674a
...
...
@@ -187,7 +187,7 @@ module Gitlab
parse_params
do
|
reviewer_param
|
extract_users
(
reviewer_param
)
end
command
:assign_reviewer
,
:reviewer
do
|
users
|
command
:assign_reviewer
,
:reviewer
,
:request_review
do
|
users
|
next
if
users
.
empty?
if
quick_action_target
.
allows_multiple_reviewers?
...
...
spec/services/quick_actions/interpret_service_spec.rb
View file @
92a2674a
...
...
@@ -945,6 +945,12 @@ RSpec.describe QuickActions::InterpretService do
it_behaves_like
'assign_reviewer command'
end
context
'with the "request_review" alias'
do
let
(
:content
)
{
"/request_review @
#{
developer
.
username
}
"
}
it_behaves_like
'assign_reviewer command'
end
context
'with no user'
do
let
(
:content
)
{
'/assign_reviewer'
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment