Commit 93676c82 authored by Kerri Miller's avatar Kerri Miller

Test uncached files are added during #write_if_empty

parent 4cd99b39
...@@ -73,7 +73,7 @@ describe Gitlab::Diff::HighlightCache, :clean_gitlab_redis_cache do ...@@ -73,7 +73,7 @@ describe Gitlab::Diff::HighlightCache, :clean_gitlab_redis_cache do
end end
describe '#write_if_empty' do describe '#write_if_empty' do
let(:backend) { double('backend', read: {}).as_null_object } let(:backend) { Rails.cache }
it 'filters the key/value list of entries to be caches for each invocation' do it 'filters the key/value list of entries to be caches for each invocation' do
expect(cache).to receive(:write_to_redis_hash) expect(cache).to receive(:write_to_redis_hash)
...@@ -82,6 +82,19 @@ describe Gitlab::Diff::HighlightCache, :clean_gitlab_redis_cache do ...@@ -82,6 +82,19 @@ describe Gitlab::Diff::HighlightCache, :clean_gitlab_redis_cache do
2.times { cache.write_if_empty } 2.times { cache.write_if_empty }
end end
context 'different diff_collections for the same diffable' do
before do
cache.write_if_empty
end
it 'writes an uncached files in the collection to the same redis hash' do
Gitlab::Redis::Cache.with { |r| r.hdel(cache_key, "files/whitespace") }
expect { cache.write_if_empty }
.to change { Gitlab::Redis::Cache.with { |r| r.hgetall(cache_key) } }
end
end
end end
describe '#write_to_redis_hash' do describe '#write_to_redis_hash' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment