Commit 94e9562a authored by Vitali Tatarintev's avatar Vitali Tatarintev

Merge branch 'Fix-GraphQL/OrderedArguments-offense-(Part-3/6)' into 'master'

Fix GraphQL/OrderedArguments offense (Part 3/6)

See merge request gitlab-org/gitlab!76025
parents 5afe750b 55c5417e
...@@ -4,9 +4,6 @@ GraphQL/OrderedArguments: ...@@ -4,9 +4,6 @@ GraphQL/OrderedArguments:
- app/graphql/resolvers/base_issues_resolver.rb - app/graphql/resolvers/base_issues_resolver.rb
- app/graphql/resolvers/design_management/designs_resolver.rb - app/graphql/resolvers/design_management/designs_resolver.rb
- app/graphql/resolvers/design_management/version/design_at_version_resolver.rb - app/graphql/resolvers/design_management/version/design_at_version_resolver.rb
- app/graphql/resolvers/design_management/version/designs_at_version_resolver.rb
- app/graphql/resolvers/design_management/version_in_collection_resolver.rb
- app/graphql/resolvers/group_milestones_resolver.rb
- app/graphql/resolvers/merge_requests_resolver.rb - app/graphql/resolvers/merge_requests_resolver.rb
- app/graphql/resolvers/paginated_tree_resolver.rb - app/graphql/resolvers/paginated_tree_resolver.rb
- app/graphql/resolvers/tree_resolver.rb - app/graphql/resolvers/tree_resolver.rb
......
...@@ -13,13 +13,13 @@ module Resolvers ...@@ -13,13 +13,13 @@ module Resolvers
DesignID = ::Types::GlobalIDType[::DesignManagement::Design] DesignID = ::Types::GlobalIDType[::DesignManagement::Design]
argument :ids, [DesignID],
required: false,
description: 'Filters designs by their ID.'
argument :filenames, argument :filenames,
[GraphQL::Types::String], [GraphQL::Types::String],
required: false, required: false,
description: 'Filters designs by their filename.' description: 'Filters designs by their filename.'
argument :ids, [DesignID],
required: false,
description: 'Filters designs by their ID.'
def self.single def self.single
::Resolvers::DesignManagement::Version::DesignAtVersionResolver ::Resolvers::DesignManagement::Version::DesignAtVersionResolver
......
...@@ -15,13 +15,13 @@ module Resolvers ...@@ -15,13 +15,13 @@ module Resolvers
VersionID = ::Types::GlobalIDType[::DesignManagement::Version] VersionID = ::Types::GlobalIDType[::DesignManagement::Version]
argument :sha, GraphQL::Types::String,
required: false,
description: "SHA256 of a specific version."
argument :id, VersionID, argument :id, VersionID,
as: :version_id, as: :version_id,
required: false, required: false,
description: 'Global ID of the version.' description: 'Global ID of the version.'
argument :sha, GraphQL::Types::String,
required: false,
description: "SHA256 of a specific version."
def resolve(version_id: nil, sha: nil) def resolve(version_id: nil, sha: nil)
# TODO: remove this line when the compatibility layer is removed # TODO: remove this line when the compatibility layer is removed
......
...@@ -2,12 +2,12 @@ ...@@ -2,12 +2,12 @@
module Resolvers module Resolvers
class GroupMilestonesResolver < MilestonesResolver class GroupMilestonesResolver < MilestonesResolver
argument :include_descendants, GraphQL::Types::Boolean,
required: false,
description: 'Include milestones from all subgroups and subprojects.'
argument :include_ancestors, GraphQL::Types::Boolean, argument :include_ancestors, GraphQL::Types::Boolean,
required: false, required: false,
description: 'Include milestones from all parent groups.' description: 'Include milestones from all parent groups.'
argument :include_descendants, GraphQL::Types::Boolean,
required: false,
description: 'Include milestones from all subgroups and subprojects.'
type Types::MilestoneType.connection_type, null: true type Types::MilestoneType.connection_type, null: true
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment