NXD Make HTTP to be the default clone protocol

Both fetch and push are possible over https, which is selected by http if
gitlab was configured to use https in external url.

This way to reduce security vectors and possible ways to interact with gitlab
we use https only without ssh at all.

app/helpers/projects_helper.rb

@@ -416,6 +416,8 @@ module ProjectsHelper
   end
 
   def default_url_to_repo(project = @project)
+    # always HTTP:
+    return project.http_url_to_repo
     case default_clone_protocol
     when 'ssh'
       project.ssh_url_to_repo
@@ -429,8 +431,9 @@ module ProjectsHelper
   end
 
   def default_clone_protocol
+    # always HTTP:
     if allowed_protocols_present?
-      enabled_protocol
+      "http"
     else
       extra_default_clone_protocol
     end

[Jérome Perrin]

@alain.takoudjou this also seem supported out of the box. In /admin/application_settings we have:

( I have not confirmed this provides all the functionality our patch provided )

[Alain Takoudjou]

@jerome I think we can drop this commit Enabled Git access protocols should be enought