Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
9726601c
Commit
9726601c
authored
Oct 21, 2021
by
Aakriti Gupta
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove FF verification_state_backfill_worker
Changelog: added EE: true
parent
bda1af7e
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
19 deletions
+5
-19
ee/app/models/concerns/geo/verifiable_replicator.rb
ee/app/models/concerns/geo/verifiable_replicator.rb
+1
-1
ee/config/feature_flags/development/verification_state_backfill_worker.yml
..._flags/development/verification_state_backfill_worker.yml
+0
-8
ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb
.../models/concerns/verifiable_replicator_shared_examples.rb
+4
-10
No files found.
ee/app/models/concerns/geo/verifiable_replicator.rb
View file @
9726601c
...
@@ -51,7 +51,7 @@ module Geo
...
@@ -51,7 +51,7 @@ module Geo
::
Geo
::
ReverificationBatchWorker
.
perform_with_capacity
(
replicable_name
)
::
Geo
::
ReverificationBatchWorker
.
perform_with_capacity
(
replicable_name
)
if
Feature
.
enabled?
(
:verification_state_backfill_worker
,
default_enabled: :yaml
)
&&
verification_query_class
.
separate_verification_state_table?
if
verification_query_class
.
separate_verification_state_table?
::
Geo
::
VerificationStateBackfillWorker
.
perform_async
(
replicable_name
)
::
Geo
::
VerificationStateBackfillWorker
.
perform_async
(
replicable_name
)
end
end
end
end
...
...
ee/config/feature_flags/development/verification_state_backfill_worker.yml
deleted
100644 → 0
View file @
bda1af7e
---
name
:
verification_state_backfill_worker
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/69301
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/340648
milestone
:
'
14.4'
type
:
development
group
:
group::geo
default_enabled
:
false
ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb
View file @
9726601c
...
@@ -144,18 +144,12 @@ RSpec.shared_examples 'a verifiable replicator' do
...
@@ -144,18 +144,12 @@ RSpec.shared_examples 'a verifiable replicator' do
described_class
.
trigger_background_verification
described_class
.
trigger_background_verification
end
end
context
'when verification_state_backfill_worker feature flag is enabled'
do
before
do
stub_feature_flags
(
verification_state_backfill_worker:
true
)
expect
(
described_class
.
model
).
to
receive
(
:separate_verification_state_table?
).
and_return
(
true
)
end
it
'enqueues VerificationStateBackfillWorker'
do
it
'enqueues VerificationStateBackfillWorker'
do
expect
(
described_class
.
model
).
to
receive
(
:separate_verification_state_table?
).
and_return
(
true
)
expect
(
::
Geo
::
VerificationStateBackfillWorker
).
to
receive
(
:perform_async
).
with
(
described_class
.
replicable_name
)
expect
(
::
Geo
::
VerificationStateBackfillWorker
).
to
receive
(
:perform_async
).
with
(
described_class
.
replicable_name
)
described_class
.
trigger_background_verification
described_class
.
trigger_background_verification
end
end
end
context
'for a Geo secondary'
do
context
'for a Geo secondary'
do
it
'does not enqueue ReverificationBatchWorker'
do
it
'does not enqueue ReverificationBatchWorker'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment