Merge branch 'dblb-split-ns-resolution' into 'master'

Catch NoResponseError from Net::DNS in LoadBalancing::Resolver

See merge request gitlab-org/gitlab!57187

ee/changelogs/unreleased/dblb-split-ns-resolution.yml

+---
+title: Catch NoResponseError from Net::DNS in LoadBalancing::Resolver
+merge_request: 57187
+author:
+type: fixed

ee/lib/gitlab/database/load_balancing/resolver.rb

@@ -43,6 +43,8 @@ module Gitlab
           return if answer.empty?
 
           answer.first.address
+        rescue Net::DNS::Resolver::NoResponseError
+          raise UnresolvableNameserverError, "no response from DNS server(s)"
         end
       end
     end

ee/spec/lib/gitlab/database/load_balancing/resolver_spec.rb

@@ -57,6 +57,23 @@ RSpec.describe Gitlab::Database::LoadBalancing::Resolver do
             )
           end
         end
+
+        context 'when DNS does not respond' do
+          it 'raises an exception' do
+            allow_next_instance_of(Resolv::Hosts) do |instance|
+              allow(instance).to receive(:getaddress).with('localhost').and_raise(Resolv::ResolvError)
+            end
+
+            allow(Net::DNS::Resolver).to receive(:start)
+              .with('localhost', Net::DNS::A)
+              .and_raise(Net::DNS::Resolver::NoResponseError)
+
+            expect { subject }.to raise_exception(
+              described_class::UnresolvableNameserverError,
+              'no response from DNS server(s)'
+            )
+          end
+        end
       end
     end
   end