Commit 9a93aee0 authored by Marcia Ramos's avatar Marcia Ramos

Merge branch 'code-review-code-style' into 'master'

Automate code style reviews

See merge request gitlab-org/gitlab!35096
parents 5c463a05 32d03bfe
...@@ -386,9 +386,12 @@ author. ...@@ -386,9 +386,12 @@ author.
- Learning how to find the right balance takes time; that is why we have - Learning how to find the right balance takes time; that is why we have
reviewers that become maintainers after some time spent on reviewing merge reviewers that become maintainers after some time spent on reviewing merge
requests. requests.
- Finding bugs and improving code style is important, but thinking about good - Finding bugs is important, but thinking about good design is important as
design is important as well. Building abstractions and good design is what well. Building abstractions and good design is what makes it possible to hide
makes it possible to hide complexity and makes future changes easier. complexity and makes future changes easier.
- Enforcing and improving [code style](contributing/style_guides.md) should be primarily done through
[automation](https://about.gitlab.com/handbook/values/#cleanup-over-sign-off)
instead of review comments.
- Asking the author to change the design sometimes means the complete rewrite - Asking the author to change the design sometimes means the complete rewrite
of the contributed code. It's usually a good idea to ask another maintainer or of the contributed code. It's usually a good idea to ask another maintainer or
reviewer before doing it, but have the courage to do it when you believe it is reviewer before doing it, but have the courage to do it when you believe it is
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment