Merge branch 'ab/partition-creator-kwargs' into 'master'

Further remove deprecation warning around WithLockRetries usage

See merge request gitlab-org/gitlab!43108

lib/gitlab/database/partitioning/partition_creator.rb

@@ -72,10 +72,10 @@ module Gitlab
         end
 
         def with_lock_retries(&block)
-          Gitlab::Database::WithLockRetries.new(**{
+          Gitlab::Database::WithLockRetries.new(
             klass: self.class,
             logger: Gitlab::AppLogger
-          }).run(&block)
+          ).run(&block)
         end
 
         def connection

lib/gitlab/database/reindexing/concurrent_reindex.rb

@@ -99,7 +99,7 @@ module Gitlab
         def with_lock_retries(&block)
           arguments = { klass: self.class, logger: logger }
 
-          Gitlab::Database::WithLockRetries.new(arguments).run(raise_on_exhaustion: true, &block)
+          Gitlab::Database::WithLockRetries.new(**arguments).run(raise_on_exhaustion: true, &block)
         end
 
         delegate :execute, to: :connection

lib/gitlab/database/schema_helpers.rb

@@ -68,10 +68,10 @@ module Gitlab
       end
 
       def with_lock_retries(&block)
-        Gitlab::Database::WithLockRetries.new({
+        Gitlab::Database::WithLockRetries.new(
           klass: self.class,
           logger: Gitlab::BackgroundMigration::Logger
-        }).run(&block)
+        ).run(&block)
       end
 
       def assert_not_in_transaction_block(scope:)