Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
a04a9c38
Commit
a04a9c38
authored
May 31, 2017
by
Dmitriy Zaporozhets
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Improve usability of the code quality widget
Signed-off-by:
Dmitriy Zaporozhets
<
dmitriy.zaporozhets@gmail.com
>
parent
9fd035a1
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
10 additions
and
9 deletions
+10
-9
app/assets/javascripts/vue_merge_request_widget/ee/components/mr_widget_code_quality.vue
...e_request_widget/ee/components/mr_widget_code_quality.vue
+7
-7
app/assets/javascripts/vue_merge_request_widget/ee/components/mr_widget_code_quality_issues.vue
...st_widget/ee/components/mr_widget_code_quality_issues.vue
+1
-0
spec/javascripts/vue_mr_widget/components/mr_widget_code_quality_issues_spec.js
...r_widget/components/mr_widget_code_quality_issues_spec.js
+2
-2
No files found.
app/assets/javascripts/vue_merge_request_widget/ee/components/mr_widget_code_quality.vue
View file @
a04a9c38
...
@@ -151,19 +151,19 @@ export default {
...
@@ -151,19 +151,19 @@ export default {
class=
"code-quality-container"
class=
"code-quality-container"
v-if=
"hasIssues"
v-if=
"hasIssues"
v-show=
"!isCollapsed"
>
v-show=
"!isCollapsed"
>
<issues-block
class=
"js-mr-code-new-issues"
v-if=
"mr.codeclimateMetrics.newIssues.length"
type=
"failed"
:issues=
"mr.codeclimateMetrics.newIssues"
/>
<issues-block
<issues-block
class=
"js-mr-code-resolved-issues"
class=
"js-mr-code-resolved-issues"
v-if=
"mr.codeclimateMetrics.resolvedIssues.length"
v-if=
"mr.codeclimateMetrics.resolvedIssues.length"
type=
"success"
type=
"success"
:issues=
"mr.codeclimateMetrics.resolvedIssues"
:issues=
"mr.codeclimateMetrics.resolvedIssues"
/>
/>
<issues-block
class=
"js-mr-code-new-issues"
v-if=
"mr.codeclimateMetrics.newIssues.length"
type=
"failed"
:issues=
"mr.codeclimateMetrics.newIssues"
/>
</div>
</div>
</div>
</div>
<div
<div
...
...
app/assets/javascripts/vue_merge_request_widget/ee/components/mr_widget_code_quality_issues.vue
View file @
a04a9c38
...
@@ -31,6 +31,7 @@ export default {
...
@@ -31,6 +31,7 @@ export default {
aria-hidden="true">
aria-hidden="true">
</i>
</i>
<span>
<span>
<span
v-if=
"type === 'success'"
>
Fixed:
</span>
{{
issue
.
check_name
}}
{{
issue
.
check_name
}}
{{
issue
.
location
.
path
}}
{{
issue
.
location
.
path
}}
{{
issue
.
location
.
positions
}}
{{
issue
.
location
.
positions
}}
...
...
spec/javascripts/vue_mr_widget/components/mr_widget_code_quality_issues_spec.js
View file @
a04a9c38
...
@@ -30,7 +30,7 @@ describe('Merge Request Code Quality Issues', () => {
...
@@ -30,7 +30,7 @@ describe('Merge Request Code Quality Issues', () => {
it
(
'
should render issue
'
,
()
=>
{
it
(
'
should render issue
'
,
()
=>
{
expect
(
expect
(
vm
.
$el
.
querySelector
(
'
li span
'
).
textContent
.
trim
().
replace
(
/
\s
+/g
,
''
),
vm
.
$el
.
querySelector
(
'
li span
'
).
textContent
.
trim
().
replace
(
/
\s
+/g
,
''
),
).
toEqual
(
'
foobar8121
'
);
).
toEqual
(
'
Fixed:
foobar8121
'
);
});
});
});
});
...
@@ -50,7 +50,7 @@ describe('Merge Request Code Quality Issues', () => {
...
@@ -50,7 +50,7 @@ describe('Merge Request Code Quality Issues', () => {
it
(
'
should render issue without position and lines
'
,
()
=>
{
it
(
'
should render issue without position and lines
'
,
()
=>
{
expect
(
expect
(
vm
.
$el
.
querySelector
(
'
li span
'
).
textContent
.
trim
().
replace
(
/
\s
+/g
,
''
),
vm
.
$el
.
querySelector
(
'
li span
'
).
textContent
.
trim
().
replace
(
/
\s
+/g
,
''
),
).
toEqual
(
'
foobar
'
);
).
toEqual
(
'
Fixed:
foobar
'
);
});
});
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment