Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
a34fe472
Commit
a34fe472
authored
Jul 20, 2020
by
Dheeraj Joshi
Committed by
Andrew Fontaine
Jul 20, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Smartly truncate URLs in DAST Modal
parent
1399d4a0
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
37 additions
and
37 deletions
+37
-37
ee/app/assets/javascripts/vue_shared/security_reports/components/dast_modal.vue
...pts/vue_shared/security_reports/components/dast_modal.vue
+32
-37
ee/changelogs/unreleased/dast-modal-truncation.yml
ee/changelogs/unreleased/dast-modal-truncation.yml
+5
-0
No files found.
ee/app/assets/javascripts/vue_shared/security_reports/components/dast_modal.vue
View file @
a34fe472
<
script
>
<
script
>
import
{
GlModal
,
GlIcon
,
GlSprintf
}
from
'
@gitlab/ui
'
;
import
{
GlModal
,
GlIcon
,
GlSprintf
,
GlTruncate
}
from
'
@gitlab/ui
'
;
import
{
n__
,
__
}
from
'
~/locale
'
;
import
{
n__
,
__
}
from
'
~/locale
'
;
export
default
{
export
default
{
components
:
{
GlModal
,
GlIcon
,
GlSprintf
},
components
:
{
GlModal
,
GlIcon
,
GlSprintf
,
GlTruncate
},
props
:
{
props
:
{
scannedUrls
:
{
scannedUrls
:
{
required
:
true
,
required
:
true
,
...
@@ -40,7 +40,7 @@ export default {
...
@@ -40,7 +40,7 @@ export default {
variant
:
'
success
'
,
variant
:
'
success
'
,
class
:
'
btn-secondary gl-button
'
,
class
:
'
btn-secondary gl-button
'
,
href
:
this
.
downloadLink
,
href
:
this
.
downloadLink
,
download
:
true
,
download
:
''
,
'
data-testid
'
:
'
download-button
'
,
'
data-testid
'
:
'
download-button
'
,
},
},
};
};
...
@@ -56,22 +56,18 @@ export default {
...
@@ -56,22 +56,18 @@ export default {
v-bind=
"$options.modal"
v-bind=
"$options.modal"
:action-secondary=
"downloadButton"
:action-secondary=
"downloadButton"
>
>
<div
class=
"gl-px-3"
>
<!-- heading -->
<!-- heading -->
<div
class=
"gl-display-flex
gl-text-gray-600"
>
<div
class=
"row
gl-text-gray-600"
>
<div
class=
"gl-w-1
1"
>
{{
__
(
'
Method
'
)
}}
</div>
<div
class=
"col-
1"
>
{{
__
(
'
Method
'
)
}}
</div>
<div
class=
"gl-flex-fill-
1"
>
{{
__
(
'
URL
'
)
}}
</div>
<div
class=
"col-1
1"
>
{{
__
(
'
URL
'
)
}}
</div>
</div>
</div>
<hr
class=
"gl-my-3"
/>
<hr
class=
"gl-my-3"
/>
<!-- rows -->
<!-- rows -->
<div
v-for=
"(url, index) in limitedScannedUrls"
:key=
"index"
class=
"gl-display-flex gl-my-2"
>
<div
v-for=
"(url, index) in limitedScannedUrls"
:key=
"index"
class=
"row gl-my-2"
>
<div
class=
"gl-w-11"
>
{{
url
.
requestMethod
.
toUpperCase
()
}}
</div>
<div
class=
"col-1"
>
{{
url
.
requestMethod
.
toUpperCase
()
}}
</div>
<div
<div
class=
"col-11"
data-testid=
"dast-scanned-url"
>
class=
"gl-flex-fill-1 gl-overflow-hidden gl-white-space-nowrap gl-text-overflow-ellipsis"
<gl-truncate
:text=
"url.url"
position=
"middle"
/>
data-testid=
"dast-scanned-url"
>
{{
url
.
url
}}
</div>
</div>
</div>
</div>
...
@@ -93,6 +89,5 @@ export default {
...
@@ -93,6 +89,5 @@ export default {
</gl-sprintf>
</gl-sprintf>
</b>
</b>
</div>
</div>
</div>
</gl-modal>
</gl-modal>
</template>
</template>
ee/changelogs/unreleased/dast-modal-truncation.yml
0 → 100644
View file @
a34fe472
---
title
:
Smartly truncate URLs in DAST Modal
merge_request
:
37078
author
:
type
:
changed
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment