Merge branch 'remove-DOMContentLoaded-group-milestone-Pages' into 'master'

Remove DOMContentLoaded Eventlisteners

See merge request gitlab-org/gitlab!47775

ee/app/assets/javascripts/pages/groups/contribution_analytics/show/index.js

 import initContributionAanalyticsCharts from 'ee/analytics/contribution_analytics/contribution_analytics_bundle';
 import initGroupMemberContributions from 'ee/group_member_contributions';
 
-document.addEventListener('DOMContentLoaded', () => {
-  const dataEl = document.getElementById('js-analytics-data');
-  if (dataEl) {
+const dataEl = document.getElementById('js-analytics-data');
+if (dataEl) {
   initContributionAanalyticsCharts(dataEl);
   initGroupMemberContributions();
-  }
-});
+}

ee/app/assets/javascripts/pages/groups/ldap_group_links/index.js

 import initLDAPGroupsSelect from 'ee/ldap_groups_select';
 import initLDAPGroupLinks from 'ee/groups/ldap_group_links';
 
-document.addEventListener('DOMContentLoaded', () => {
-  initLDAPGroupsSelect();
-  initLDAPGroupLinks();
-});
+initLDAPGroupsSelect();
+initLDAPGroupLinks();

ee/app/assets/javascripts/pages/groups/omniauth_callbacks/index.js

 import { mount2faAuthentication } from '~/authentication/mount_2fa';
 
-document.addEventListener('DOMContentLoaded', mount2faAuthentication);
+mount2faAuthentication();

ee/app/assets/javascripts/pages/groups/sso/index.js

 import UsernameValidator from '~/pages/sessions/new/username_validator';
 import initConfirmDangerModal from '~/confirm_danger_modal';
 
-document.addEventListener('DOMContentLoaded', () => {
-  new UsernameValidator(); // eslint-disable-line no-new
-  initConfirmDangerModal();
-});
+new UsernameValidator(); // eslint-disable-line no-new
+initConfirmDangerModal();