Merge branch 'qa-cleanup-project-milestone-resource' into 'master'

Clean up project milestone resources and specs

See merge request gitlab-org/gitlab!33537

ee/app/views/shared/milestones/_burndown.html.haml

@@ -10,7 +10,7 @@
   .burndown-chart.mb-2{ data: { start_date: burndown.start_date.strftime("%Y-%m-%d"),
     due_date: burndown.due_date.strftime("%Y-%m-%d"),
     milestone_id: milestone.id,
-    burndown_events_path: expose_url(burndown_endpoint), burnup_events_path: expose_url(burnup_endpoint), qa_selector: 'burndown_chart' } }
+    burndown_events_path: expose_url(burndown_endpoint), burnup_events_path: expose_url(burnup_endpoint) } }
 
 - elsif show_burndown_placeholder?(milestone, warning)
   .burndown-hint.content-block.container-fluid

qa/qa/ee.rb

@@ -187,7 +187,6 @@ module QA
     module Resource
       autoload :License, 'qa/ee/resource/license'
       autoload :Epic, 'qa/ee/resource/epic'
-      autoload :ProjectMilestone, 'qa/ee/resource/project_milestone'
       autoload :GroupLabel, 'qa/ee/resource/group_label.rb'
 
       module Board

qa/qa/ee/page/project/milestone/show.rb

@@ -6,10 +6,6 @@ module QA
       module Project
         module Milestone
           class Show < ::QA::Page::Base
-            view 'ee/app/views/shared/milestones/_burndown.html.haml' do
-              element :burndown_chart
-            end
-
             view 'ee/app/views/shared/milestones/_weight.html.haml' do
               element :total_issue_weight_value
             end

qa/qa/ee/resource/board/board_list/project/milestone_board_list.rb

@@ -8,7 +8,7 @@ module QA
           module Project
             class MilestoneBoardList < BaseBoardList
               attribute :project_milestone do
-                QA::EE::Resource::ProjectMilestone.fabricate_via_api! do |project_milestone|
+                QA::Resource::ProjectMilestone.fabricate_via_api! do |project_milestone|
                   project_milestone.project = board.project
                   project_milestone.title = '1.0'
                 end

qa/qa/ee/resource/project_milestone.rb

-# frozen_string_literal: true
-
-module QA
-  module EE
-    module Resource
-      class ProjectMilestone < QA::Resource::ProjectMilestone
-        attr_writer :start_date, :due_date
-
-        def api_post_body
-          {
-            title: title
-          }.tap do |hash|
-            hash[:start_date] = @start_date if @start_date
-            hash[:due_date] = @due_date if @due_date
-          end
-        end
-      end
-    end
-  end
-end

qa/qa/resource/project_milestone.rb

@@ -3,6 +3,8 @@
 module QA
   module Resource
     class ProjectMilestone < Base
+      attr_writer :start_date, :due_date
+
       attribute :id
       attribute :title
 
@@ -27,7 +29,10 @@ module QA
       def api_post_body
         {
           title: title
-        }
+        }.tap do |hash|
+          hash[:start_date] = @start_date if @start_date
+          hash[:due_date] = @due_date if @due_date
+        end
       end
     end
   end

qa/qa/specs/features/ee/browser_ui/2_plan/burndown_chart/burndown_chart_spec.rb

@@ -6,7 +6,7 @@ module QA
       include ::QA::Support::Dates
 
       let(:milestone) do
-        QA::EE::Resource::ProjectMilestone.fabricate_via_api! do |m|
+        Resource::ProjectMilestone.fabricate_via_api! do |m|
           m.start_date = current_date_yyyy_mm_dd
           m.due_date = next_month_yyyy_mm_dd
         end

qa/qa/specs/features/ee/browser_ui/2_plan/issues_weight/issue_weight_visualization_spec.rb

@@ -8,7 +8,7 @@ module QA
       end
 
       let(:milestone) do
-        QA::EE::Resource::ProjectMilestone.fabricate_via_api!
+        Resource::ProjectMilestone.fabricate_via_api!
       end
 
       let(:weight) { 1000 }