Commit a688c435 authored by Vitaly Slobodin's avatar Vitaly Slobodin

Merge branch 'ui-text-error-tracking' into 'master'

UI text edits for error tracking

See merge request gitlab-org/gitlab!57276
parents fe2022ba 024e7176
...@@ -33,7 +33,7 @@ export default { ...@@ -33,7 +33,7 @@ export default {
<p class="form-text text-muted"> <p class="form-text text-muted">
{{ {{
s__( s__(
"ErrorTracking|If you self-host Sentry, enter the full URL of your Sentry instance. If you're using Sentry's hosted solution, enter https://sentry.io", "ErrorTracking|If you self-host Sentry, enter your Sentry instance's full URL. If you use Sentry's hosted solution, enter https://sentry.io",
) )
}} }}
</p> </p>
...@@ -75,12 +75,12 @@ export default { ...@@ -75,12 +75,12 @@ export default {
</div> </div>
</div> </div>
<p v-if="connectError" class="gl-field-error"> <p v-if="connectError" class="gl-field-error">
{{ s__('ErrorTracking|Connection has failed. Re-check Auth Token and try again.') }} {{ s__('ErrorTracking|Connection failed. Check Auth Token and try again.') }}
</p> </p>
<p v-else class="form-text text-muted"> <p v-else class="form-text text-muted">
{{ {{
s__( s__(
"ErrorTracking|After adding your Auth Token, use the 'Connect' button to load projects", 'ErrorTracking|After adding your Auth Token, select the Connect button to load projects.',
) )
}} }}
</p> </p>
......
...@@ -34,8 +34,8 @@ export const invalidProjectLabel = (state) => { ...@@ -34,8 +34,8 @@ export const invalidProjectLabel = (state) => {
export const projectSelectionLabel = (state) => { export const projectSelectionLabel = (state) => {
if (state.token) { if (state.token) {
return s__( return s__(
"ErrorTracking|Click 'Connect' to re-establish the connection to Sentry and activate the dropdown.", 'ErrorTracking|Click Connect to reestablish the connection to Sentry and activate the dropdown.',
); );
} }
return s__('ErrorTracking|To enable project selection, enter a valid Auth Token'); return s__('ErrorTracking|To enable project selection, enter a valid Auth Token.');
}; };
---
title: Updated UI text to match style guidelines
merge_request: 57276
author:
type: other
...@@ -12320,19 +12320,19 @@ msgstr "" ...@@ -12320,19 +12320,19 @@ msgstr ""
msgid "ErrorTracking|Active" msgid "ErrorTracking|Active"
msgstr "" msgstr ""
msgid "ErrorTracking|After adding your Auth Token, use the 'Connect' button to load projects" msgid "ErrorTracking|After adding your Auth Token, select the Connect button to load projects."
msgstr "" msgstr ""
msgid "ErrorTracking|Auth Token" msgid "ErrorTracking|Auth Token"
msgstr "" msgstr ""
msgid "ErrorTracking|Click 'Connect' to re-establish the connection to Sentry and activate the dropdown." msgid "ErrorTracking|Click Connect to reestablish the connection to Sentry and activate the dropdown."
msgstr "" msgstr ""
msgid "ErrorTracking|Connection has failed. Re-check Auth Token and try again." msgid "ErrorTracking|Connection failed. Check Auth Token and try again."
msgstr "" msgstr ""
msgid "ErrorTracking|If you self-host Sentry, enter the full URL of your Sentry instance. If you're using Sentry's hosted solution, enter https://sentry.io" msgid "ErrorTracking|If you self-host Sentry, enter your Sentry instance's full URL. If you use Sentry's hosted solution, enter https://sentry.io"
msgstr "" msgstr ""
msgid "ErrorTracking|No projects available" msgid "ErrorTracking|No projects available"
...@@ -12341,7 +12341,7 @@ msgstr "" ...@@ -12341,7 +12341,7 @@ msgstr ""
msgid "ErrorTracking|Select project" msgid "ErrorTracking|Select project"
msgstr "" msgstr ""
msgid "ErrorTracking|To enable project selection, enter a valid Auth Token" msgid "ErrorTracking|To enable project selection, enter a valid Auth Token."
msgstr "" msgstr ""
msgid "Errors" msgid "Errors"
......
...@@ -146,7 +146,7 @@ RSpec.describe 'Projects > Settings > For a forked project', :js do ...@@ -146,7 +146,7 @@ RSpec.describe 'Projects > Settings > For a forked project', :js do
click_button('Connect') click_button('Connect')
assert_text('Connection has failed. Re-check Auth Token and try again.') assert_text('Connection failed. Check Auth Token and try again.')
end end
end end
end end
......
...@@ -44,13 +44,13 @@ describe('error tracking settings form', () => { ...@@ -44,13 +44,13 @@ describe('error tracking settings form', () => {
const pageText = wrapper.text(); const pageText = wrapper.text();
expect(pageText).toContain( expect(pageText).toContain(
"If you self-host Sentry, enter the full URL of your Sentry instance. If you're using Sentry's hosted solution, enter https://sentry.io", "If you self-host Sentry, enter your Sentry instance's full URL. If you use Sentry's hosted solution, enter https://sentry.io",
); );
expect(pageText).toContain( expect(pageText).toContain(
"After adding your Auth Token, use the 'Connect' button to load projects", 'After adding your Auth Token, select the Connect button to load projects.',
); );
expect(pageText).not.toContain('Connection has failed. Re-check Auth Token and try again'); expect(pageText).not.toContain('Connection failed. Check Auth Token and try again.');
expect(wrapper.findAll(GlFormInput).at(0).attributes('placeholder')).toContain( expect(wrapper.findAll(GlFormInput).at(0).attributes('placeholder')).toContain(
'https://mysentryserver.com', 'https://mysentryserver.com',
); );
...@@ -80,9 +80,7 @@ describe('error tracking settings form', () => { ...@@ -80,9 +80,7 @@ describe('error tracking settings form', () => {
}); });
it('does not show an error', () => { it('does not show an error', () => {
expect(wrapper.text()).not.toContain( expect(wrapper.text()).not.toContain('Connection failed. Check Auth Token and try again.');
'Connection has failed. Re-check Auth Token and try again',
);
}); });
}); });
...@@ -96,7 +94,7 @@ describe('error tracking settings form', () => { ...@@ -96,7 +94,7 @@ describe('error tracking settings form', () => {
}); });
it('shows an error', () => { it('shows an error', () => {
expect(wrapper.text()).toContain('Connection has failed. Re-check Auth Token and try again'); expect(wrapper.text()).toContain('Connection failed. Check Auth Token and try again.');
}); });
}); });
}); });
...@@ -78,7 +78,7 @@ describe('Error Tracking Settings - Getters', () => { ...@@ -78,7 +78,7 @@ describe('Error Tracking Settings - Getters', () => {
describe('projectSelectionLabel', () => { describe('projectSelectionLabel', () => {
it('should show the correct message when the token is empty', () => { it('should show the correct message when the token is empty', () => {
expect(getters.projectSelectionLabel(state)).toEqual( expect(getters.projectSelectionLabel(state)).toEqual(
'To enable project selection, enter a valid Auth Token', 'To enable project selection, enter a valid Auth Token.',
); );
}); });
...@@ -86,7 +86,7 @@ describe('Error Tracking Settings - Getters', () => { ...@@ -86,7 +86,7 @@ describe('Error Tracking Settings - Getters', () => {
state.token = 'test-token'; state.token = 'test-token';
expect(getters.projectSelectionLabel(state)).toEqual( expect(getters.projectSelectionLabel(state)).toEqual(
"Click 'Connect' to re-establish the connection to Sentry and activate the dropdown.", 'Click Connect to reestablish the connection to Sentry and activate the dropdown.',
); );
}); });
}); });
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment