Merge branch '223718-change-rate-limit-for-issues-creation-to-be-disabled-by-default' into 'master'

Change default value for issues_create_limit

See merge request gitlab-org/gitlab!36558

changelogs/unreleased/223718-change-rate-limit-for-issues-creation-to-be-disabled-by-default.yml

+---
+title: Change default value in application_settings.issues_create_limit to be 0
+merge_request: 36558
+author:
+type: changed

db/migrate/20200710105332_change_issues_create_limit_default.rb

+# frozen_string_literal: true
+
+class ChangeIssuesCreateLimitDefault < ActiveRecord::Migration[6.0]
+  include Gitlab::Database::MigrationHelpers
+
+  DOWNTIME = false
+
+  def up
+    with_lock_retries do
+      change_column_default :application_settings, :issues_create_limit, from: 300, to: 0
+    end
+  end
+
+  def down
+    with_lock_retries do
+      change_column_default :application_settings, :issues_create_limit, from: 0, to: 300
+    end
+  end
+end

db/structure.sql

@@ -9149,7 +9149,7 @@ CREATE TABLE public.application_settings (
     namespace_storage_size_limit bigint DEFAULT 0 NOT NULL,
     seat_link_enabled boolean DEFAULT true NOT NULL,
     container_expiration_policies_enable_historic_entries boolean DEFAULT false NOT NULL,
-    issues_create_limit integer DEFAULT 300 NOT NULL,
+    issues_create_limit integer DEFAULT 0 NOT NULL,
     push_rule_id bigint,
     group_owners_can_manage_default_branch_protection boolean DEFAULT true NOT NULL,
     container_registry_vendor text DEFAULT ''::text NOT NULL,
@@ -23766,6 +23766,7 @@ COPY "schema_migrations" (version) FROM STDIN;
 20200707095849
 20200708080631
 20200710102846
+20200710105332
 20200710130234
 \.
 

doc/user/admin_area/settings/rate_limit_on_issues_creation.md

@@ -10,10 +10,9 @@ info: To determine the technical writer assigned to the Stage/Group associated w
 > [Introduced](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/28129) in GitLab 12.10.
 
 This setting allows you to rate limit the requests to the issue creation endpoint.
-It defaults to 300 requests per minute.
-You can change it in **Admin Area > Settings > Network > Issues Rate Limits**.
+You can change its value in **Admin Area > Settings > Network > Issues Rate Limits**.
 
-For example, requests using the
+For example, if you set a limit of 300, requests using the
 [Projects::IssuesController#create](https://gitlab.com/gitlab-org/gitlab/raw/master/app/controllers/projects/issues_controller.rb)
 action exceeding a rate of 300 per minute are blocked. Access to the endpoint is allowed after one minute.
 
@@ -23,6 +22,6 @@ This limit is:
 
 - Applied independently per project and per user.
 - Not applied per IP address.
-- Active by default. To disable it, set the option to `0`.
+- Disabled by default. To enable it, set the option to any value other than `0`.
 
 Requests over the rate limit are logged into the `auth.log` file.