Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
ad271952
Commit
ad271952
authored
Dec 19, 2016
by
http://jneen.net/
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
add a spec for RemoveApprovalService
parent
d5869aa3
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
54 additions
and
0 deletions
+54
-0
spec/services/merge_requests/remove_approval_service_spec.rb
spec/services/merge_requests/remove_approval_service_spec.rb
+54
-0
No files found.
spec/services/merge_requests/remove_approval_service_spec.rb
0 → 100644
View file @
ad271952
require
'rails_helper'
describe
MergeRequests
::
RemoveApprovalService
,
services:
true
do
describe
'#execute'
do
let
(
:user
)
{
create
(
:user
)
}
let
(
:merge_request
)
{
create
(
:merge_request
)
}
let
(
:project
)
{
merge_request
.
project
}
subject
(
:service
)
{
described_class
.
new
(
project
,
user
)
}
def
execute!
service
.
execute
(
merge_request
)
end
context
'with a user who has approved'
do
before
do
merge_request
.
approvals
.
create
(
user:
user
)
end
it
'removes the approval'
do
expect
(
merge_request
.
approvals
.
size
).
to
eq
1
execute!
expect
(
merge_request
.
approvals
).
to
be_empty
end
it
'creates an unapproval note'
do
expect
(
SystemNoteService
).
to
receive
(
:unapprove_mr
)
execute!
end
it
'does not send a notification'
do
expect
(
Notify
).
not_to
receive
(
:unapprove_mr
)
execute!
end
end
context
'with an approved merge request'
do
let
(
:notify
)
{
Object
.
new
}
before
do
merge_request
.
update_attribute
:approvals_before_merge
,
1
merge_request
.
approvals
.
create
(
user:
user
)
allow
(
service
).
to
receive
(
:notification_service
).
and_return
(
notify
)
end
it
'sends a notification'
do
expect
(
notify
).
to
receive
(
:unapprove_mr
)
execute!
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment