Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
b24e475b
Commit
b24e475b
authored
Nov 09, 2019
by
Sean Arnold
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make external_url public and add test to ensure it
parent
c4b114cd
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
12 additions
and
4 deletions
+12
-4
app/services/error_tracking/list_issues_service.rb
app/services/error_tracking/list_issues_service.rb
+4
-4
spec/services/error_tracking/list_issues_service_spec.rb
spec/services/error_tracking/list_issues_service_spec.rb
+8
-0
No files found.
app/services/error_tracking/list_issues_service.rb
View file @
b24e475b
...
@@ -5,6 +5,10 @@ module ErrorTracking
...
@@ -5,6 +5,10 @@ module ErrorTracking
DEFAULT_ISSUE_STATUS
=
'unresolved'
DEFAULT_ISSUE_STATUS
=
'unresolved'
DEFAULT_LIMIT
=
20
DEFAULT_LIMIT
=
20
def
external_url
project_error_tracking_setting
&
.
sentry_external_url
end
private
private
def
fetch
def
fetch
...
@@ -15,10 +19,6 @@ module ErrorTracking
...
@@ -15,10 +19,6 @@ module ErrorTracking
{
issues:
response
[
:issues
]
}
{
issues:
response
[
:issues
]
}
end
end
def
external_url
project_error_tracking_setting
&
.
sentry_external_url
end
def
issue_status
def
issue_status
params
[
:issue_status
]
||
DEFAULT_ISSUE_STATUS
params
[
:issue_status
]
||
DEFAULT_ISSUE_STATUS
end
end
...
...
spec/services/error_tracking/list_issues_service_spec.rb
View file @
b24e475b
...
@@ -45,4 +45,12 @@ describe ErrorTracking::ListIssuesService do
...
@@ -45,4 +45,12 @@ describe ErrorTracking::ListIssuesService do
include_examples
'error tracking service unauthorized user'
include_examples
'error tracking service unauthorized user'
include_examples
'error tracking service disabled'
include_examples
'error tracking service disabled'
end
end
describe
'#external_url'
do
it
'calls the project setting sentry_external_url'
do
expect
(
error_tracking_setting
).
to
receive
(
:sentry_external_url
)
subject
.
external_url
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment