Remove vulnerability counter from security tab

- Removed the counter from the DOM and the Javascript responsible for
updating its value
- Replaced the screenshot on the documentation to reflect this change

changelogs/unreleased/13978-pipeline-security-remove-vuln-count.yml

+---
+title: Remove vulnerability counter from security tab
+merge_request: 20800
+author:
+type: changed

doc/user/application_security/security_dashboard/index.md

@@ -42,7 +42,7 @@ At the pipeline level, the Security Dashboard displays the vulnerabilities prese
 
 Visit the page for any pipeline which has run any of the [supported reports](#supported-reports). Click the **Security** tab to view the Security Dashboard.
 
-![Pipeline Security Dashboard](img/pipeline_security_dashboard_v12_3.png)
+![Pipeline Security Dashboard](img/pipeline_security_dashboard_v12_6.png)
 
 ## Project Security Dashboard
 

doc/user/project/import/gemnasium.md

@@ -98,7 +98,7 @@ back to both GitLab and GitHub when completed.
 
 1. The result of the job will be visible directly from the pipeline view:
 
-   ![Security Dashboard](../../application_security/security_dashboard/img/pipeline_security_dashboard_v12_3.png)
+   ![Security Dashboard](../../application_security/security_dashboard/img/pipeline_security_dashboard_v12_6.png)
 
 NOTE: **Note:**
 If you don't commit very often to your project, you may want to use

ee/app/assets/javascripts/pages/projects/pipelines/show/security_report.js

@@ -6,7 +6,6 @@ import createDashboardStore from 'ee/security_dashboard/store';
 import SecurityDashboardApp from 'ee/security_dashboard/components/app.vue';
 import SecurityReportApp from 'ee/vue_shared/security_reports/split_security_reports_app.vue';
 import createStore from 'ee/vue_shared/security_reports/store';
-import { updateBadgeCount } from './utils';
 
 Vue.use(Translate);
 
@@ -33,11 +32,6 @@ const initSecurityDashboardApp = el => {
           vulnerabilitiesEndpoint,
           vulnerabilityFeedbackHelpPath,
         },
-        on: {
-          vulnerabilitiesCountChanged(count) {
-            updateBadgeCount('.js-security-counter', count);
-          },
-        },
         scopedSlots: {
           emptyState: () =>
             createElement(GlEmptyState, {
@@ -111,11 +105,6 @@ const initSplitSecurityReportsApp = el => {
           canCreateMergeRequest: Boolean(createVulnerabilityFeedbackMergeRequestPath),
           canDismissVulnerability: Boolean(createVulnerabilityFeedbackDismissalPath),
         },
-        on: {
-          updateBadgeCount: count => {
-            updateBadgeCount('.js-security-counter', count);
-          },
-        },
       });
     },
   });

ee/app/assets/javascripts/vue_shared/security_reports/split_security_reports_app.vue

@@ -157,11 +157,6 @@ export default {
       );
     },
   },
-  watch: {
-    issuesCount() {
-      this.$emit('updateBadgeCount', this.issuesCount);
-    },
-  },
   created() {
     // update the store with the received props
     this.setHeadBlobPath(this.headBlobPath);

ee/app/views/projects/pipelines/_tabs_holder.html.haml

@@ -5,7 +5,6 @@
   %li.js-security-tab-link
     = link_to security_project_pipeline_path(project, pipeline), data: { target: '#js-tab-security', action: 'security', toggle: 'tab', qa_selector: 'security_tab' }, class: 'security-tab' do
       = _("Security")
-      %span.badge.badge-pill.js-security-counter.hidden{ 'data-qa-selector': 'security_counter' }
 
 - if pipeline.expose_license_scanning_data?
   %li.js-licenses-tab-link

qa/qa/ee/page/project/pipeline/show.rb

@@ -10,7 +10,6 @@ module QA::EE
           page.module_eval do
             view 'ee/app/views/projects/pipelines/_tabs_holder.html.haml' do
               element :security_tab
-              element :security_counter
               element :licenses_tab
               element :licenses_counter
             end
@@ -22,7 +21,6 @@ module QA::EE
 
             view 'ee/app/views/projects/pipelines/_tabs_holder.html.haml' do
               element :security_tab
-              element :security_counter
             end
           end
         end
@@ -31,10 +29,6 @@ module QA::EE
           click_element(:security_tab)
         end
 
-        def has_vulnerability_count_of?(count)
-          find_element(:security_counter).has_content?(count)
-        end
-
         def filter_report_type(report)
           click_element(:filter_report_type_dropdown)
           within_element(:filter_dropdown_content) do