Merge branch 'qa-fix-static-analysis-jobs' into 'master'

Fix rubocop offense and enable jobs for qa

See merge request gitlab-org/gitlab-ce!18613

.gitlab-ci.yml

@@ -110,7 +110,7 @@ stages:
 # Jobs that only need to pull cache
 .dedicated-no-docs-pull-cache-job: &dedicated-no-docs-pull-cache-job
   <<: *dedicated-runner
-  <<: *except-docs-and-qa
+  <<: *except-docs
   <<: *pull-cache
   dependencies:
     - setup-test-env

qa/qa/factory/repository/push.rb

@@ -3,7 +3,9 @@ module QA
     module Repository
       class Push < Factory::Base
         attr_accessor :file_name, :file_content, :commit_message,
-                      :branch_name, :new_branch, :remote_branch
+                      :branch_name, :new_branch
+
+        attr_writer :remote_branch
 
         dependency Factory::Resource::Project, as: :project do |project|
           project.name = 'project-with-code'

qa/qa/runtime/key/ecdsa.rb

+# rubocop:disable Naming/FileName
 module QA
   module Runtime
     module Key

qa/qa/runtime/key/ed25519.rb

+# rubocop:disable Naming/FileName
 module QA
   module Runtime
     module Key