Merge branch '4610-ee-edit' into 'master'

Resolve "EE-only js for project edit page"

Closes #4610

See merge request gitlab-org/gitlab-ee!4135

app/assets/javascripts/dispatcher.js

@@ -336,7 +336,7 @@ var Dispatcher;
           // ee-end
           break;
         case 'projects:edit':
-          import('./pages/projects/edit')
+          import(/* webpackChunkName: "ee_projects_edit" */ 'ee/pages/projects/edit')
             .then(callDefault)
             .catch(fail);
           break;

app/assets/javascripts/pages/projects/edit/index.js

 /* eslint-disable no-new */
-import UsersSelect from '~/users_select';
-import UserCallout from '~/user_callout';
-import groupsSelect from '~/groups_select';
 import initSettingsPanels from '~/settings_panels';
 import setupProjectEdit from '~/project_edit';
 import ProjectNew from '../shared/project_new';
 import projectAvatar from '../shared/project_avatar';
 import initProjectPermissionsSettings from '../shared/permissions';
 
-// EE imports
-import ApproversSelect from 'ee/approvers_select'; // eslint-disable-line import/first
-
 export default () => {
   new ProjectNew(); // eslint-disable-line no-new
-  new UsersSelect();
-  groupsSelect();
   setupProjectEdit();
   // Initialize expandable settings panels
   initSettingsPanels();
   projectAvatar();
   initProjectPermissionsSettings();
-
-  new UserCallout({ className: 'js-service-desk-callout' });
-  new UserCallout({ className: 'js-mr-approval-callout' });
-
-  // EE imports
-  new ApproversSelect(); // eslint-disable-line no-new
 };

ee/app/assets/javascripts/pages/projects/edit/index.js

+/* eslint-disable no-new */
+import initCePage from '~/pages/projects/edit';
+import UsersSelect from '~/users_select';
+import UserCallout from '~/user_callout';
+import groupsSelect from '~/groups_select';
+import ApproversSelect from 'ee/approvers_select';
+
+export default () => {
+  new UsersSelect();
+  groupsSelect();
+  initCePage();
+
+  new UserCallout({ className: 'js-service-desk-callout' });
+  new UserCallout({ className: 'js-mr-approval-callout' });
+  new ApproversSelect();
+};